Received: by 2002:a05:6520:4211:b029:f4:110d:56bc with SMTP id o17csp1619905lkv; Wed, 19 May 2021 14:13:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUnOhmQRtBFZTWbMA3VPfId9z9u464DNlzSaDnb3fewfQhOg+R6j9+8CXQxP8NOLpXBfdx X-Received: by 2002:a05:6402:177a:: with SMTP id da26mr1072133edb.180.1621458808033; Wed, 19 May 2021 14:13:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621458808; cv=none; d=google.com; s=arc-20160816; b=lSINRXLxU0RTzCoYpt7VVzyVg5Q/OufFSPoirfKLfIrSbnC1M9cp2QAWIHGpNjXt4g XLtzdGXh5dVsrMCiqFAwpjLZnPez+oGUn2N1WlSGACXHc29Hgpd5+IMYV0fZBypIIGA1 UsRZxgeqnGb9AQdBJ1uZ42ogwuKUJC0D4B1t6EN4rYg0WEKoiQqE5Q7trfL3QY/j8fTN 4g5ppbCxJVChXXCmFoz1YPTFkNFSjSSeBmIN9mJ3ClJP8XUREZFOz4dEr8/0RnXtitBu 90Jah+G/iYEeKxKkWv6RBPi5wUQKU8ndLw6VqlgwkmhNRHOnh8EJB+f1xYBrWl55ivf7 qUIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cbkhpI5vBR81uL1ocKfn+lLS/ohpu52DP40R54riGhg=; b=SLZB1SRqAiQGhZFp6+/I7Nh0LQozuWaIB7LpyH1UM0+dDI88Agpu6lpCfpIPAyNqWI tWvGlUpIhWAgQvp8P7xsiamhKoPJ4+zIy6BA1T/MRozpW+nul+3V8K+NSTOF1KiR+I4Y 73TfcaPgqqZKaEfWFa2L3E/JGsNHEzigjw8ltU7rsNTEsLSPl5vvQKfSui0BWyihJsdp Rc5iNud3/IQftDFMEP9j6IkhazJYOA6O24AaG3lIIMb+UClgOig+oHP6sUbEhhQLEOzv 8lRCtdAGiXagGQto+mxYZmdBrr3FG4O6EXiHttHMZgYHFV/g35a0y//hc1l7m7pHrBuI SeYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=fPe9MAdQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c5si296727edr.365.2021.05.19.14.12.55; Wed, 19 May 2021 14:13:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=fPe9MAdQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346529AbhESNHl (ORCPT + 99 others); Wed, 19 May 2021 09:07:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:34422 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241090AbhESNHj (ORCPT ); Wed, 19 May 2021 09:07:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1621429578; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cbkhpI5vBR81uL1ocKfn+lLS/ohpu52DP40R54riGhg=; b=fPe9MAdQw7ZpB+CKxHWk2JKhOwonQ7H9YIcb8aiNyLgqvPppg0JwrY+O5cRkKXei2JVI/4 WO41hO1S0jzcnPKuK+xJVE0fi+xfNabgyQGfKe1OAPdYG0UjytDCGHIj7M9siEe5r7ZGGe RM1LK3O+WcRPbwpWzCWCpVze/nh+pMA= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D6351AED7; Wed, 19 May 2021 13:06:18 +0000 (UTC) Date: Wed, 19 May 2021 15:06:18 +0200 From: Michal Hocko To: chenguanyou Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, keescook@chromium.org, lukas.bulwahn@gmail.com, vbabka@suse.cz, gpiccoli@canonical.com, chenguanyou Subject: Re: [PATCH] hungtask: add filter kthread/check comm Message-ID: References: <20210519121325.22083-1-chenguanyou@xiaomi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210519121325.22083-1-chenguanyou@xiaomi.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 19-05-21 20:13:25, chenguanyou wrote: > Some kernel threads are always in D state, when we enable hung_task, > it will misjudge, we should skip these to narrow the scope. Why they are in the D state in the first place? Also you are proposing a new user interface which would need to be maintained for ever. This means that any such a proposal has to be very carefully justified. Always make sure to cc linux-api mailing list in these cases. From the (not much) information you have provided this interface seems more like a workaround for buggy code so far. -- Michal Hocko SUSE Labs