Received: by 2002:a05:6520:4211:b029:f4:110d:56bc with SMTP id o17csp1621602lkv; Wed, 19 May 2021 14:15:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz71ZxqHGgxMlC0+yvt81+QlobSW4LxrrTNoXEf+4AkZq8EoVJA2Uj+TT1kSWVfmr32gpbu X-Received: by 2002:a02:688:: with SMTP id 130mr1447077jav.48.1621458958303; Wed, 19 May 2021 14:15:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621458958; cv=none; d=google.com; s=arc-20160816; b=i5MwnhAEHOTtMLPdOqR7MrLjodYPEUdCrG0XVhVhB38Vaq7pLrPhHOYoF+JOLwmOwb 4CKb/hpEu1+ESX0vZ0org/heRqWlem72YcsN2Bl5FXTqFc77/M/7v9NB9JQukiYXjeyM Z8B8ZdngQLMDfeBnDvlKpXWX6l+BwIRVZVPwJvJHnAk3mrTY1nQ6cnb598WAYwJUHEJR QDkymyzQFIBlqz1nBuoa2YdP+C/6DW05ss3G6RjUoB+Yheh2J8hlz1dS9Qug9ApVhoTz D14Z3s+9R9z+buCl1d2YZ6+ugOG1/sMmhNEV9xcWfdHa68RIt39zMe3sbVNUKVk3WbQN oK7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=1HUXUWVIfWhQRHh1W1y106aW0AdVfM2HaCxzSzZGna8=; b=atjqb259jjeCt0tOaZ1+yNRvG1dBfE8hs/n7ntNF7Hp+mBETB88c2uVhcwkduR/LFg j61Ueor+aj3NywRDfSE/LdxYDAH9i63ljnSiBfHIVGHgxls+NQbVVKlKrFvauiyowURk tBjKTBSiye0SPkc6NRLm6mimPvtLcsLCAX4Kp9Tz7I5N1+Jen9K4uiWegmv1CZb8qdjp ymJSYd00Lqmk8Im+0lZh0dm0EZ+KiykOwB4T/9BMbI47cgfZjZdy95dcRNapUKKgO/lI YxcX25RnRFI6PUIlI9xRg9xjlZvZ/BVEyc3U6JRCRKXodoiiZYZEhCX7Gb0Nkvx/kusH z66w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n12si546702jat.1.2021.05.19.14.15.45; Wed, 19 May 2021 14:15:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353762AbhESNsf (ORCPT + 99 others); Wed, 19 May 2021 09:48:35 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:3601 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346671AbhESNse (ORCPT ); Wed, 19 May 2021 09:48:34 -0400 Received: from dggems703-chm.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FlYyd3rkxzmX7b; Wed, 19 May 2021 21:44:57 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggems703-chm.china.huawei.com (10.3.19.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 19 May 2021 21:47:13 +0800 Received: from huawei.com (10.175.103.91) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 19 May 2021 21:47:13 +0800 From: Yang Yingliang To: , , , CC: , Subject: [PATCH -next] drm/rockchip: cdn-dp-core: add missing clk_disable_unprepare() on error in cdn_dp_grf_write() Date: Wed, 19 May 2021 21:49:28 +0800 Message-ID: <20210519134928.2696617-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After calling clk_prepare_enable(), clk_disable_unprepare() need be called when calling regmap_write() failed. Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c index a4a45daf93f2..6802d9b65f82 100644 --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c @@ -73,6 +73,7 @@ static int cdn_dp_grf_write(struct cdn_dp_device *dp, ret = regmap_write(dp->grf, reg, val); if (ret) { DRM_DEV_ERROR(dp->dev, "Could not write to GRF: %d\n", ret); + clk_disable_unprepare(dp->grf_clk); return ret; } -- 2.25.1