Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Heiko =?ISO-8859-1?Q?St=FCbner?= <heiko@sntech.de>
To:     linus.walleij@linaro.org, robh+dt@kernel.org,
        Jianqun Xu <jay.xu@rock-chips.com>
Cc:     linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org,
        linux-kernel@vger.kernel.org, Jianqun Xu <jay.xu@rock-chips.com>
Subject: Re: [PATCH 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type
Date:   Thu, 20 May 2021 01:26:42 +0200
Message-ID: <1817539.g5d078U9FE@diego>
In-Reply-To: <20210510063734.506063-1-jay.xu@rock-chips.com>
References: <20210510063602.505829-1-jay.xu@rock-chips.com> <20210510063734.506063-1-jay.xu@rock-chips.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Am Montag, 10. Mai 2021, 08:37:34 CEST schrieb Jianqun Xu:
> There has spin lock for irq set type already, so drop irq_gc_lock and
> irq_gc_unlock.
> 
> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>

I've looked that up, and yes the irq_gc_lock stuff really seems to be
redundant when there is already another spinlock in place, so

Reviewed-by: Heiko Stuebner <heiko@sntech.de>