Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1879356pxj; Wed, 19 May 2021 16:32:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0/zKtguWVwZYJnlMhdBfW1PeprOLwVtH3GDiRHzXjATe8WPI3FrYVQfafSUvi4Dt63g8K X-Received: by 2002:a17:907:7848:: with SMTP id lb8mr1667300ejc.494.1621467162224; Wed, 19 May 2021 16:32:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621467162; cv=none; d=google.com; s=arc-20160816; b=dxyCG1pyLUweylfRcx+h0dxt67UoXaB34XoeFE3znDGZZnWp7dB+Smre+cUy4LK3+s KVIPfE1cjI7/Sm6hBesAa/1otA1M+PwiXG4nfNRorASdg1cimE28PW+OxN8I4kFxg3fo S8mZEhBmiF5C15qCizcN+PzkRv4uEfGkWTl6UwJOBsqstYLaQg8WvvzF9gqyebrJ+3zS fZiPdWxm7c8R+Y5XflpxNg0beniRZ5nCIQiWLqVXnzsZW9ltAJ2pValdsU71E/uMnoDr m6MgwA/ltAa1QoT/9K67R18/USxoZ4SKaEMXhRY7KmrotiZ8rpza7MzICpHa6G4Tfzku 2B9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to :message-id:mime-version:user-agent:dkim-signature; bh=VG3UAsMCmxMpsEQCnw/yPGnm0hoTF6aNAxZYdD9H9zo=; b=JACewyHq6ghKLpxLQVtOI894uS/arMXxtg8YcuF77cg+E1A9b/y6trFI98HJ0PxgPi clMfXbtu1FFxg0nKWGFmpSEzhrElC6rdY4MN7slJmHj9wgNZbQ65Hl2tIeZzNaAThOed kbbZnRCGaVfm1HBkE6vlzdVOfwjnePN5N4SDPgpQ+BmgbUSR6eSUhyDl+/4/X9zSk8FQ H59xqbZd51uSfw7nDkOCDSIStUortpny95pqFmYPWGB5fWI9CVI90T/JOqjTmNWNEt2u w2NFRcWXm1QzcPKsj4lLgnvn88EXpxXZvPJsz9c+Ci44f18T9ws8dkay5xh4VQVmpVpa KgTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pdeWnBCO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h11si698983ede.61.2021.05.19.16.32.18; Wed, 19 May 2021 16:32:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pdeWnBCO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230071AbhESXbX (ORCPT + 99 others); Wed, 19 May 2021 19:31:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:44514 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbhESXbW (ORCPT ); Wed, 19 May 2021 19:31:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 44CC6611AB; Wed, 19 May 2021 23:30:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621467002; bh=8xvSSE3H35qcDXVWBq8krJ/CkeS4P86f6MpxZY+FQsI=; h=In-Reply-To:References:Date:From:To:Cc:Subject:From; b=pdeWnBCOnInNDm8x6YAc+z9QI+Wu0uGxbXPy3JyYre/HD1tUr1yp6Kj89MZ/+rP4j yP5bCoD92a0n36gX2BAgc3g5ShKUr18Xw+WgAzNI8SNW/Sk5rU/KyTIrmiiul6h1Wg eT0zgg4taZ/bludKSSGnXyBVkQKxorWMOnB8PG4P7W2+I07XYaArz+llvLdH4G+O+N tzQE4mXkQcKNXTuv5CU/EnJ5oulujaPddY2b+jkmjSUcR6D3RjGV/vScxk/7tTfePz k34YWGiA5fjDL/STm/OGEjTDauJfOd+tL9eNhUJyrdSknsk/RRxsjrst6a35PUaLNs FdW6geIgOvIKg== Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailauth.nyi.internal (Postfix) with ESMTP id 550F327C0054; Wed, 19 May 2021 19:30:00 -0400 (EDT) Received: from imap21 ([10.202.2.71]) by compute2.internal (MEProxy); Wed, 19 May 2021 19:30:00 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejtddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdetnhgu hicunfhuthhomhhirhhskhhifdcuoehluhhtoheskhgvrhhnvghlrdhorhhgqeenucggtf frrghtthgvrhhnpeegjefghfdtledvfeegfeelvedtgfevkeeugfekffdvveeffeetieeh ueetveekfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegrnhguhidomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqudduiedukeeh ieefvddqvdeifeduieeitdekqdhluhhtoheppehkvghrnhgvlhdrohhrgheslhhinhhugi drlhhuthhordhush X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 155B051C0060; Wed, 19 May 2021 19:29:58 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-448-gae190416c7-fm-20210505.004-gae190416 Mime-Version: 1.0 Message-Id: <86701a5e-87b5-4e73-9b7a-557d8c855f89@www.fastmail.com> In-Reply-To: References: Date: Wed, 19 May 2021 16:29:37 -0700 From: "Andy Lutomirski" To: "Borislav Petkov" , "Ashish Kalra" , "Sean Christopherson" Cc: "Paolo Bonzini" , "Thomas Gleixner" , "Ingo Molnar" , "H. Peter Anvin" , "Joerg Roedel" , thomas.lendacky@amd.com, "the arch/x86 maintainers" , "kvm list" , "Linux Kernel Mailing List" , srutherford@google.com, venu.busireddy@oracle.com, brijesh.singh@amd.com Subject: =?UTF-8?Q?Re:_[PATCH_v2_2/4]_mm:_x86:_Invoke_hypercall_when_page_encrypt?= =?UTF-8?Q?ion_status_is_changed?= Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 12, 2021, at 6:15 AM, Borislav Petkov wrote: > On Fri, Apr 23, 2021 at 03:58:43PM +0000, Ashish Kalra wrote: > > +static inline void notify_page_enc_status_changed(unsigned long pfn, > > + int npages, bool enc) > > +{ > > + PVOP_VCALL3(mmu.notify_page_enc_status_changed, pfn, npages, enc); > > +} > > Now the question is whether something like that is needed for TDX, and, > if so, could it be shared by both. The TDX MapGPA call can fail, and presumably it will fail if the page is not sufficiently quiescent from the host's perspective. It seems like a mistake to me to have a KVM-specific hypercall for this that cannot cleanly fail.