Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] pinctrl/amd: Add device HID for new AMD GPIO controller
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        stable <stable@vger.kernel.org>, Sachi King <nakato@nakato.io>
References: <20210512210316.1982416-1-luzmaximilian@gmail.com>
 <CACRpkdZpm4w6Ym2p9xTsYpkU7CR531aLUUxXj54tssoqd6c9=Q@mail.gmail.com>
From:   Maximilian Luz <luzmaximilian@gmail.com>
Message-ID: <582afe8b-76c0-7c72-bb08-5e3cca70d1a6@gmail.com>
Date:   Thu, 20 May 2021 02:14:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <CACRpkdZpm4w6Ym2p9xTsYpkU7CR531aLUUxXj54tssoqd6c9=Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20/05/2021 01:50, Linus Walleij wrote:
> On Wed, May 12, 2021 at 11:03 PM Maximilian Luz <luzmaximilian@gmail.com> wrote:
> 
>> Add device HID AMDI0031 to the AMD GPIO controller driver match table.
>> This controller can be found on Microsoft Surface Laptop 4 devices and
>> seems similar enough that we can just copy the existing AMDI0030 entry.
>>
>> Cc: <stable@vger.kernel.org> # 5.10+
> 
> Why? It's hardly a regression?

Because that ID is already in use on the Surface Laptop 4 and
potentially other AMD-based laptops that are already available for
purchase. Not having it in stable means that people may have to deal
with some things not working (as this may prevent other drivers relying
on GPIOs from working) until 5.14 is available on their distribution of
choice.

Given the size of this change, I hardly think that's necessary. Which
is, I believe, also why the stable-kernel-rules doc points out that new
device IDs are (generally) allowed.

Regards,
Max