Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1969098pxj; Wed, 19 May 2021 19:15:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0J8GQ42KaOA4K1WFzHP2reSsgKcbtnCdg0aafLJ2PY1bSDqYm2kAFU4nDMMHDjAPzTfDU X-Received: by 2002:a05:6e02:104e:: with SMTP id p14mr2737274ilj.109.1621476959575; Wed, 19 May 2021 19:15:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621476959; cv=none; d=google.com; s=arc-20160816; b=SDbiNMdj7vpOrc9y47Q8rG9zsNdQE2Zv0KZon1JsZF9RzspepKtClKG5L9+nxcQ/xL vA7a9cONdS+pZkPdtZ8eksVxmtlfUkayxjbLKI3pfpXJFVPh9OlX9ZwUvywohU8VFeKJ o8vecFLupyCzjL+ZeRlczzjeUh0cJ84W5PZCrPz/zyA427bkx4GWsn/P25XGFvaN2b7Q YcwSQhKpPZ9HgWm29zTT4n4WvdWAHMA2YesmzpHtdt7TsSfhuWYgXujHg4jz3OZrp+M1 0r/mspDwWuH2RPQMZgBk6pgoyt3fGZ0Ny06tZ5cZQwEz3dwMsbp0XwIKXbtVptHJPNyS vNgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=odecAKUaHKQG4X3qJBH558YiNF7tYkLnTOKSXP3atJM=; b=ZjoyuUmg4hn0b7AIWM69bsvFQJrwylBRLzHvLJCJRs9I4WJBMEgewLU0rCd4DHOy15 wgs8g73hbILPN05Gwc7RDKGvf/CL6rXskxp/g7FHEEeXkEPn8XIy7IJU5ch0q35v0Jdu SYW4MjxnB3cKdqMVaPkvRlEVtXVvLaVVbMDLAQWchUhoT9RqT7Tb1FqbluLjQH9EQNOJ q3OuGjXZgIl2hn7xF7Zd/S6l4wAg+k5GoPk7fqlyX6PRwWU1SP7tYfjrUF7pNKyNM4eB Tsr8Dw75JHmY4XvXZjU+wnFpsPV29jKotXMhRZWEDFdS+WSS7bqu+FHHDAXWLV+GY+tr NqCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@aj.id.au header.s=fm2 header.b=TBAjCkk+; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=ajPVZwIR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g2si1168610jaj.107.2021.05.19.19.15.45; Wed, 19 May 2021 19:15:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@aj.id.au header.s=fm2 header.b=TBAjCkk+; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=ajPVZwIR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230342AbhETCQL (ORCPT + 99 others); Wed, 19 May 2021 22:16:11 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:34237 "EHLO new1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230308AbhETCPu (ORCPT ); Wed, 19 May 2021 22:15:50 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id ACA925808EB; Wed, 19 May 2021 22:13:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 19 May 2021 22:13:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=from :to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm2; bh=odecAKUaHKQG4X3qJBH558YiNF 7tYkLnTOKSXP3atJM=; b=TBAjCkk+uY2vL+OPwD/lYfZ9Qd6hy31ihSr8xd0dER PAhQvk5iYF7YH9Yvo8H2rOcZGIc+JjioT2xksAA+5QM6/HRC2xe94VBjExBy/FhF MGqjFe0RWKq60dai30WXXqO4IsJXrc34UIvxcctz9BqHbDSLzX2pzkgILvtmvjDQ b2k8t2xr6ZQTQ+wb23M2rYocYszl5wjFwXC9feT0j9PDvdwFoYJE0ARQGoHitZNL idcfpvX5BO1Ai500+DqKTMofPg+IPjidnX6VcyeHc6T+Xt2wvZNnQ/tNzo4yHFkK RM8vQUUax0XWYWW4VVQYN9JDDZCmJg85nJW5ag3eHIqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=odecAKUaHKQG4X3qJ BH558YiNF7tYkLnTOKSXP3atJM=; b=ajPVZwIRN8x1f044hZZ78SjOdzZ2dcid7 4O6D8HV1KWmQxN+3WPnvpC0HCqGiV4QRKIsofQhNldfU/IZJFNQ0HroscZdCsjtI 21SuRslEESk2tql30Hb2Ryu8Y54iI0JaOEW9y0mu9VC7oL68I/4++1XEifSKRTyi tAVkRR2lEJh7O5Ldk+q46JxM8DF/+yPv/k53jlg7rJflyJN8ckBrI49tZAo+AjnQ KH5jL39tibMDPP5TANRlf1IFKXi2HOqnuGQW/K8PCioBUD797wBgVF9ttEy0CFI3 FW3RdwTvQNBqrP7N758PDBV/moyULfKMQ0yQRv2QDuj8tmJxuCSUw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejtddgheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomheptehnughrvgifucflvghffhgvrhihuceorghnughrvgifsegrjhdr ihgurdgruheqnecuggftrfgrthhtvghrnhepieetheduveelhfdvvdejleeuhfelteevhe ffgfeitdefgeekjeefieevgfehhefgnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghen ucfkphepvddtfedrheejrddvudehrdeknecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomheprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Received: from mistburn.lan (203-57-215-8.dyn.iinet.net.au [203.57.215.8]) by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 May 2021 22:13:43 -0400 (EDT) From: Andrew Jeffery To: linux-serial@vger.kernel.org Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, joel@jms.id.au, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, jenmin_yuan@aspeedtech.com, ryan_chen@aspeedtech.com, miltonm@us.ibm.com Subject: [PATCH v3 0/2] serial: 8250: Mitigate Tx stall risk for Aspeed VUARTs Date: Thu, 20 May 2021 11:43:32 +0930 Message-Id: <20210520021334.497341-1-andrew@aj.id.au> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Briefly, the series works around a hardware race condition in the Tx path for Aspeed virtual UARTs. A write burst to THR on the APB interface may provoke a transfer stall where LSR[DR] on the LPC interface remains clear despite the presence of data in the Rx FIFO. v3 addresses comments from Jiri on v2. v2 can be found here: https://lore.kernel.org/lkml/20210519000704.3661773-1-andrew@aj.id.au/ The documentation patch that fell out of the discussion of patch 2 of v2 can be found here: https://lore.kernel.org/lkml/20210520015704.489737-1-andrew@aj.id.au/T/#u Please review! Andrew Andrew Jeffery (2): serial: 8250: Add UART_BUG_TXRACE workaround for Aspeed VUART serial: 8250: Use BIT(x) for UART_{CAP,BUG}_* drivers/tty/serial/8250/8250.h | 32 +++++++++++---------- drivers/tty/serial/8250/8250_aspeed_vuart.c | 1 + drivers/tty/serial/8250/8250_port.c | 12 ++++++++ 3 files changed, 30 insertions(+), 15 deletions(-) -- 2.30.2