Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com;
Envelope-to: robh@kernel.org,
 mdf@kernel.org,
 devicetree@vger.kernel.org,
 linux-fpga@vger.kernel.org,
 linux-kernel@vger.kernel.org,
 trix@redhat.com
Subject: Re: [PATCH V6 XRT Alveo 16/20] fpga: xrt: clock driver
To:     Tom Rix <trix@redhat.com>, Lizhi Hou <lizhi.hou@xilinx.com>,
        <linux-kernel@vger.kernel.org>
CC:     <linux-fpga@vger.kernel.org>, <maxz@xilinx.com>,
        <sonal.santan@xilinx.com>, <yliu@xilinx.com>,
        <michal.simek@xilinx.com>, <stefanos@xilinx.com>,
        <devicetree@vger.kernel.org>, <mdf@kernel.org>, <robh@kernel.org>,
        Max Zhen <max.zhen@xilinx.com>
References: <20210512015339.5649-1-lizhi.hou@xilinx.com>
 <20210512015339.5649-17-lizhi.hou@xilinx.com>
 <f4a18fa4-f023-d4e5-0622-e15108de90b9@redhat.com>
From:   Lizhi Hou <lizhi.hou@xilinx.com>
Message-ID: <d58eeee5-e47d-4e2b-9b49-15f798c305ed@xilinx.com>
Date:   Wed, 19 May 2021 19:49:03 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <f4a18fa4-f023-d4e5-0622-e15108de90b9@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2021 02:49:05.7569
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0375914d-06a6-4ee5-f974-08d91b39d585
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT035.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8062
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 05/13/2021 08:48 AM, Tom Rix wrote:
>
>
>> +
>> +static int get_freq(struct clock *clock, u16 *freq)
>> +{
>
>> +
>> +     /*
>> +      * Multiply both numerator (mul0) and the denominator (div1) with
>> +      * 1000 to account for fractional portion of divider
>> +      */
>> +
>> +     div1 *= 1000;
>> +     div1 += div_frac1;
>> +     div0 *= div1;
>> +     mul0 *= 1000;
>> +     if (div0 == 0) {
>> +             CLOCK_ERR(clock, "clockwiz 0 divider");
>
> This prevents a divide by zero, but returns 0 without setting freq
>
> A -EINVAL should be returned or freq initialized to some default value
Sure.
>
>> +             return 0;
>> +     }
>> +
>> +     input = mul0 * 100;
>> +     do_div(input, div0);
>> +     *freq = (u16)input;
>> +
>> +     return 0;
>> +}
>> +
>>
>> +
>> +static int clock_verify_freq(struct clock *clock)
>> +{
>> +     u32 lookup_freq, clock_freq_counter, request_in_khz, tolerance;
>> +     int err = 0;
>> +     u16 freq;
>> +
>> +     mutex_lock(&clock->clock_lock);
>> +
>> +     err = get_freq(clock, &freq);
>> +     if (err) {
>> +             xrt_err(clock->xdev, "get freq failed, %d", err);
>> +             goto end;
>> +     }
>> +
>> +     err = get_freq_counter(clock, &clock_freq_counter);
>> +     if (err) {
>> +             xrt_err(clock->xdev, "get freq counter failed, %d", err);
>> +             goto end;
>> +     }
>> +
>> +     lookup_freq = find_matching_freq(freq, frequency_table,
>> + ARRAY_SIZE(frequency_table));
>
> I am running v6 through clang's static analyzer, it shows a problem here
>
> drivers/fpga/xrt/lib/xleaf/clock.c:474:16: warning: 1st function call
> argument is an uninitialized value
>         lookup_freq = find_matching_freq(freq, frequency_table,
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> See problem with get_freq above
Sure.

Thanks,
Lizhi
>
> Tom
>
>