Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4 1/2] docs: perf: Add description for HiSilicon PCIe PMU
 driver
To:     John Garry <john.garry@huawei.com>, <will@kernel.org>,
        <mark.rutland@arm.com>, <bhelgaas@google.com>
CC:     <linux-pci@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
        <zhangshaokun@hisilicon.com>
References: <1621417741-5229-1-git-send-email-liuqi115@huawei.com>
 <1621417741-5229-2-git-send-email-liuqi115@huawei.com>
 <b6988fa7-a1e6-90c2-1c76-7795a0bc4c0a@huawei.com>
From:   "liuqi (BA)" <liuqi115@huawei.com>
Message-ID: <fdee07c8-b8bb-5dd5-a01e-6b6421ad997e@huawei.com>
Date:   Thu, 20 May 2021 11:22:20 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <b6988fa7-a1e6-90c2-1c76-7795a0bc4c0a@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk


Hi John,
On 2021/5/19 19:44, John Garry wrote:
> On 19/05/2021 10:49, Qi Liu wrote:
>> PCIe PMU Root Complex Integrated End Point(RCiEP) device is supported on
>> HiSilicon HIP09 platform. Document it to provide guidance on how to
>> use it.
>>
>> Signed-off-by: Qi Liu<liuqi115@huawei.com>
> 
> Reviewed-by: John Garry <john.garry@huawei.com>
> 
> JFYI, perf tool iostat support is in 5.13-rc1, so we can look to add 
> support for this HW as well in future.
> 
> My impression is that we should use metricgroups.
> 

Yes, perf iostat makes it easier for users to monitor PCIe bandwidth. 
I'll add perf iostat for HiSilicon PCIe PMU latter.

Thanks, Qi
> Thanks,
> John
> 
> .