Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: skakit=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 20 May 2021 11:55:15 +0530
From:   skakit@codeaurora.org
To:     Matthias Kaehlcke <mka@chromium.org>
Cc:     Vinod Koul <vkoul@kernel.org>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, kgunda@codeaurora.org
Subject: Re: [RESEND PATCH V4 2/8] arm64: dts: qcom: sc7280: Add thermal-zones
 node
In-Reply-To: <YKPq84r7soE0yjMA@google.com>
References: <1621318822-29332-1-git-send-email-skakit@codeaurora.org>
 <1621318822-29332-3-git-send-email-skakit@codeaurora.org>
 <YKOog43JZghth3Np@vkoul-mobl.Dlink> <YKPq84r7soE0yjMA@google.com>
Message-ID: <f7d2584dfd69d514c8f2aed053204b66@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

Hi Matthias,

On 2021-05-18 21:57, Matthias Kaehlcke wrote:
> On Tue, May 18, 2021 at 05:14:03PM +0530, Vinod Koul wrote:
>> On 18-05-21, 11:50, satya priya wrote:
>> > Add thermal-zones node for SC7280 SoC.
>> >
>> > Signed-off-by: satya priya <skakit@codeaurora.org>
>> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
>> > ---
>> > Changes in RESEND V4:
>> >  - No Changes.
>> >
>> >  arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
>> >  1 file changed, 3 insertions(+)
>> >
>> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> > index 2cc4785..2a7d488 100644
>> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> > @@ -1125,4 +1125,7 @@
>> >  			     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
>> >  			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
>> >  	};
>> > +
>> > +	thermal_zones: thermal-zones {
>> > +	};
>> 
>> Empty node..? what am i missing here...
> 
> The 'thermal-zones' node with the SoC thermal zones is usually created
> in the <soc>.dtsi, however it doesn't exist yet. The 'Add DT bindings
> and device tree nodes for TSENS in SC7280' series
> (https://patchwork.kernel.org/project/linux-arm-msm/list/?series=478225)
> is creating it, but the series hasn't landed yet.
> 
> The node is needed by other patches in this series that add non-SoC
> thermal zones. Hence either an empty node needs to be added (for now)
> or this series should 'officially' depend on the TSENS series mentioned
> above.

I will add the dependency in cover letter and drop this patch.

Thanks,
Satya Priya