Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2114263pxj; Wed, 19 May 2021 23:59:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHH0LO3yIaULkqcGmiNrnEFl8OhIsjLSfy72bu9Z9yJzwx1amq882WivNInXPYoszwDaji X-Received: by 2002:aa7:ca0c:: with SMTP id y12mr3337375eds.380.1621493971201; Wed, 19 May 2021 23:59:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621493971; cv=none; d=google.com; s=arc-20160816; b=ybdINeCyIoXVwLpKKN7uOliYLmKxvc0X7mEtg3q8loUpbWTyQG+q3VuQE48s4rP2r9 rFBI+uqBnqUK/bLaMZ8yDhTuT/nMj7Woaq942ORzdmx9R7gNst1A6DoxgV84lHo2fFej osMj6Ae+R+wv8VmJ2FIlMT4voHdWoXeXHgHACMLiLrg8C9WtVoGZjbgixqTbMnV/vd6n 2VMPDSbRlCOwqsLPgPqna+xKZiWabTQ63Z7YBtRQ7A6CZ3cJl829qjYYmnzAHd3/ZN2v 28KT4nSUEjUrWiLTh8JtR6lCXAHyJsPUgsAd8MDwmDGU/5YunkVNK4GDOwUP1rqkJChR HC5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date:to :from:subject:message-id:dkim-signature; bh=ZjS8xGFFsqpY9xijPZhdC83gL+fsRNLiJRhnKCIKzUQ=; b=FnmkEuZ2Eo0I0w80eoZZwEotKdlw7iBF7ek4W18WbPgpgcX3vD1PLESMWy4cc7spoY lqU2yLGaN52gkNY+Sp1FxIdc1u54ZNRJ7qImqM1+txqoCIdgbp9+SqODueyqzdeA2ND1 hfw3dTaFSzGS29Emn5LrpqPDvc5cPGp/Daj3YYqj7IkZdKlRrgwRZKHgu15LBYaugunK ybOvpmkjfgUT17HKPZGGsonqZ2Qyjg+9TVRhlNHi7/YK9GyxXHeLyX7iMER/Hn1jPfOP EmvravI5XiEPYmUyhfrlOQAZkZGTIxXE3n2A8Ohdn5mmQRGvtDxB1Ftjo9yPZd5U9e9F QzAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@areca-com-tw.20150623.gappssmtp.com header.s=20150623 header.b=1iZbCenG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g20si1534647edt.518.2021.05.19.23.59.08; Wed, 19 May 2021 23:59:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@areca-com-tw.20150623.gappssmtp.com header.s=20150623 header.b=1iZbCenG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230514AbhETG4p (ORCPT + 99 others); Thu, 20 May 2021 02:56:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231166AbhETG4h (ORCPT ); Thu, 20 May 2021 02:56:37 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA90EC06138A for ; Wed, 19 May 2021 23:55:16 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id k15so11157412pgb.10 for ; Wed, 19 May 2021 23:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=areca-com-tw.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:date:mime-version :content-transfer-encoding; bh=ZjS8xGFFsqpY9xijPZhdC83gL+fsRNLiJRhnKCIKzUQ=; b=1iZbCenGWJR+Gq+PkkIqnRRZ+TQLPknki+a/FzBCbMOIYlG1lE5Qjy53Fbl2ArcV8v eYLoTN6qmfiOKcWk81FSAO7E4N3l69XwQb/Yj2OPrtNtedrmKCjFA3dVnRyt/UgUVJ/Q rFvB42vp33aMC3vCO5mD7EuC9agSBgGHoGwF2RlXyZI7DCCv89HN4wSxyX6D0DX1qqop OqSuekeZsLN9drD+WumT7XJhuYGBUAv3xwrz3vFtXDi4z8b28UtpjzOAFZepPGuuUAC9 QxkkO7wBB0yKH22+udP4ozFjzvrNY80VMSHoJbxzrvjZ+Yfc2S6E15S4WfTH+UMJEn7U gZ1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:mime-version :content-transfer-encoding; bh=ZjS8xGFFsqpY9xijPZhdC83gL+fsRNLiJRhnKCIKzUQ=; b=Uml7WWFki0fnKr2PGpPpMrocr7isphJb4CNWibMo1JptNPCm3yC7GBBW3xaZDML39k s/EIBJNp3H9PiidqV6QBOg/pbfK2CYEuJeuBE4kSPtA7zneOioQ5ZkZXIh6v7Th/2j1L kl1AimXB5r4KengHMbRTV2TvOU2tQd2f7EbdqbJcOUvOXyv4JMbeISppVQSuLW8xzwcG j2cirX+sfPh4aWF7o3PH77lJY+uDk8+f2Ta6kgU+MZv/HRrXmfho/EipZz2K0VXGOYRi Qb6BjhzlXa+1BlCtyaFb+zuLk96DeIk6eDJ0aMI5WvtNU1DYarA9mG/HNouF+xO4RqIC +hkw== X-Gm-Message-State: AOAM532rEyl9dNMDFMuDU2KO8xIluBVvfNlh4y/no3/QZcqqslfBG/oX EoNodFII5DDYz9wGz4Oabpz78w== X-Received: by 2002:a63:3dc5:: with SMTP id k188mr3071051pga.140.1621493716420; Wed, 19 May 2021 23:55:16 -0700 (PDT) Received: from centos78 (60-248-88-209.HINET-IP.hinet.net. [60.248.88.209]) by smtp.gmail.com with ESMTPSA id g202sm1160918pfb.54.2021.05.19.23.55.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 May 2021 23:55:16 -0700 (PDT) Message-ID: Subject: [PATCH 1/2] scsi: arcmsr: fix doorbell status may arrived late on ARC-1886 From: ching Huang To: martin.petersen@oracle.com, James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org, Linux Kernel Mailing List Date: Thu, 20 May 2021 14:55:15 +0800 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: ching Huang This patch fix the doorbell status coming from IOP may late. The doorbell status value should not be 0. Signed-off-by: ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 930972c..98e3d57 100644 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c @@ -2419,10 +2419,18 @@ static void arcmsr_hbaD_doorbell_isr(struct AdapterControlBlock *pACB) static void arcmsr_hbaE_doorbell_isr(struct AdapterControlBlock *pACB) { - uint32_t outbound_doorbell, in_doorbell, tmp; + uint32_t outbound_doorbell, in_doorbell, tmp, i; struct MessageUnit_E __iomem *reg = pACB->pmuE; - in_doorbell = readl(®->iobound_doorbell); + if (pACB->adapter_type == ACB_ADAPTER_TYPE_F) { + for (i = 0; i < 5; i++) { + in_doorbell = readl(®->iobound_doorbell); + if (in_doorbell != 0) + break; + } + } + else + in_doorbell = readl(®->iobound_doorbell); outbound_doorbell = in_doorbell ^ pACB->in_doorbell; do { writel(0, ®->host_int_status); /* clear interrupt */