Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
        Andy Lutomirski <luto@kernel.org>,
        Borislav Petkov <bp@alien8.de>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/8] x86/traps: add X86_NR_HW_TRAPS to <asm/trapnr.h>
In-Reply-To: <E1F71F76-747B-4A22-98A2-5FBF17B83A1A@zytor.com>
References: <20210519212154.511983-1-hpa@zytor.com> <20210519212154.511983-2-hpa@zytor.com> <87bl96cqqy.ffs@nanos.tec.linutronix.de> <E1F71F76-747B-4A22-98A2-5FBF17B83A1A@zytor.com>
Date:   Thu, 20 May 2021 09:10:41 +0200
Message-ID: <878s49dgni.ffs@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Wed, May 19 2021 at 15:24, H. Peter Anvin wrote:

  A: Because it messes up the order in which people normally read text.
  Q: Why is top-posting such a bad thing?

  A: Top-posting.
  Q: What is the most annoying thing in e-mail?

  A: No.
  Q: Should I include quotations after my reply?

> On May 19, 2021 3:17:57 PM PDT, Thomas Gleixner <tglx@linutronix.de> wrote:
>> On Wed, May 19 2021 at 14:21, H. Peter Anvin wrote:
>>> The x86 architecture supports up to 32 trap vectors. Add that
>>> constant to <asm/trapnr.h>.
>>
>> Where is that actually used?
>
> It is not right now, but it will be used in the FRED enabling patchset
> at the very least (since the number of exception vectors and
> FIRST_EXTERNAL_VECTOR are not necessarily the same anymore.)

Then add it with FRED. Defining unused stuff will just result in cleanup
patches which removed unused defines...

Thanks,

        tglx