Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp62608pxj; Thu, 20 May 2021 04:38:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwX4Yg2++cDAz/Ow4hLB/vt4473uxIpxeMra5xUGrvK1jWQ1NtWgzXBjYxRJwawNjpLVc9M X-Received: by 2002:aa7:cd90:: with SMTP id x16mr4491269edv.182.1621510680602; Thu, 20 May 2021 04:38:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621510680; cv=none; d=google.com; s=arc-20160816; b=mDY/e7EeoN91UQmu/Gzbarsfrd3n/P8wdmGsYPFCitfaaNHln7/1YzMOZtjreOibrP lyfoEw+Og9GNqqghbphaW+uVB+u/2xpw4szVm1pDv9/Dfrp0T6kWU3f0A4v/J/o+UcBD lUNRo0u4mU32DhP/jShUi/F7uUvCmbYHjdGYtd5ooVq+//ue11qIytQLdMKN4N8ounBa LiNHnD7WIncBdga6CGiSdntbEkI95suApiUVFMFEnBgGKjyQenPwUtR5ZfGPaRfU/wjq 158B7DIeyE9+EG+H7XDqZGcOviVi+YBCu16pJ88xiR4rrGrKmR7IsrxbwpVZJpNM6M8H yPHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OR8cvMYCm479qAt9Ii8cZE/1y72JdnBsXAhFsR6Uioc=; b=MYwPMrvjFBfWN0BbHkP0t3yjAI+ITtGwHIyK0mAPsxvIRPquFAxNaVylZiESzEVu3W E3eIZNBowBHUtaZDE0HkEoTM9Co9AZbKxFH5A37b/Rtl7dmZYDcFCpIL3fgy64qnGLjD yaG8XBQsm87Ji+6lysiVRcIGESol02RhmHK7cMTpHS2JU5Aqxcep9ZRpqtOL3DWqYDNs X6Da6CSo+c7jxOejwSFB73B3ojUTLVBTkdvokIPP5kRtCO0MANcSGX7xuaM8prv8f0y8 Bt2Fh1WS2uRtDhXsBKb5sPVSydXTkqmkI3yntFmwXUMdZSjvlSDp2k/OSasGSFYSn5tR ZwYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kfqk0fV6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g11si1911828edw.414.2021.05.20.04.37.37; Thu, 20 May 2021 04:38:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kfqk0fV6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241699AbhETLgs (ORCPT + 99 others); Thu, 20 May 2021 07:36:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:39590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239944AbhETLQf (ORCPT ); Thu, 20 May 2021 07:16:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3E13761D67; Thu, 20 May 2021 10:09:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621505357; bh=g6IBgH9k1AU6t67QxwQ1Nh8XnByBxwJzzVpT9p7ZfsE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kfqk0fV6hqZcfcq/hIcbzE5+8kQl8CkvgGpDIIauriRPkCcJSEbnWMVTcGpBFtQW3 /mDEA338HiZ0rg8OavLasAc/ewMhGKbjqUQT5UyA6DxEu3cYaZFycUukyjqV52CX9C diNdf3p1Su/AnlOILdkjO4D04mHAW8Woc0/xkLR8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Yang Yingliang , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.4 098/190] media: omap4iss: return error code when omap4iss_get() failed Date: Thu, 20 May 2021 11:22:42 +0200 Message-Id: <20210520092105.442733665@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210520092102.149300807@linuxfoundation.org> References: <20210520092102.149300807@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 8938c48fa25b491842ece9eb38f0bea0fcbaca44 ] If omap4iss_get() failed, it need return error code in iss_probe(). Fixes: 59f0ad807681 ("[media] v4l: omap4iss: Add support for OMAP4...") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/staging/media/omap4iss/iss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c index aa76ccda5b42..130d09d28e1d 100644 --- a/drivers/staging/media/omap4iss/iss.c +++ b/drivers/staging/media/omap4iss/iss.c @@ -1406,8 +1406,10 @@ static int iss_probe(struct platform_device *pdev) if (ret < 0) goto error; - if (!omap4iss_get(iss)) + if (!omap4iss_get(iss)) { + ret = -EINVAL; goto error; + } ret = iss_reset(iss); if (ret < 0) -- 2.30.2