Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965463AbWJ3BTz (ORCPT ); Sun, 29 Oct 2006 20:19:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965466AbWJ3BTz (ORCPT ); Sun, 29 Oct 2006 20:19:55 -0500 Received: from smtp.osdl.org ([65.172.181.4]:36318 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S965463AbWJ3BTy (ORCPT ); Sun, 29 Oct 2006 20:19:54 -0500 Date: Sun, 29 Oct 2006 17:19:38 -0800 (PST) From: Linus Torvalds To: "Martin J. Bligh" cc: Andy Whitcroft , Andrew Morton , "Martin J. Bligh" , Linux Kernel Mailing List , linux-mm Subject: Re: Slab panic on 2.6.19-rc3-git5 (-git4 was OK) In-Reply-To: <4545325D.8080905@mbligh.org> Message-ID: References: <454442DC.9050703@google.com> <20061029000513.de5af713.akpm@osdl.org> <4544E92C.8000103@shadowen.org> <4545325D.8080905@mbligh.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2014 Lines: 62 On Sun, 29 Oct 2006, Martin J. Bligh wrote: > > Seems like that doesn't fix it, I'm afraid. Does the one in the current -git tree? It's commit 5211e6e6c671f0d4b1e1a1023384d20227d8ee65, as below.. Linus --- commit 5211e6e6c671f0d4b1e1a1023384d20227d8ee65 Author: Giridhar Pemmasani Date: Sun Oct 29 04:46:55 2006 -0800 [PATCH] Fix GFP_HIGHMEM slab panic As reported by Martin J. Bligh , we let through some non-slab bits to slab allocation through __get_vm_area_node when doing a vmalloc. I haven't been able to reproduce this, although I understand why it happens: vmalloc allocates memory with GFP_KERNEL | __GFP_HIGHMEM and commit 52fd24ca1db3a741f144bbc229beefe044202cac resulted in the same flags are passed down to cache_alloc_refill, causing the BUG. The following patch fixes it. Note that when calling kmalloc_node, I am masking off __GFP_HIGHMEM with GFP_LEVEL_MASK, whereas __vmalloc_area_node does the same with ~(__GFP_HIGHMEM | __GFP_ZERO). IMHO, using GFP_LEVEL_MASK is preferable, but either should fix this problem. Signed-off-by: Giridhar Pemmasani (pgiri@yahoo.com) Cc: Martin J. Bligh Cc: Andrew Morton Signed-off-by: Linus Torvalds diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 6d381df..46606c1 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -182,7 +182,7 @@ static struct vm_struct *__get_vm_area_n addr = ALIGN(start, align); size = PAGE_ALIGN(size); - area = kmalloc_node(sizeof(*area), gfp_mask, node); + area = kmalloc_node(sizeof(*area), gfp_mask & GFP_LEVEL_MASK, node); if (unlikely(!area)) return NULL; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/