Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 20 May 2021 10:00:24 +0100
From:   "Russell King (Oracle)" <linux@armlinux.org.uk>
To:     "Xu, Yanfei" <yanfei.xu@windriver.com>
Cc:     rppt@kernel.org, ardb@kernel.org, linus.walleij@linaro.org,
        akpm@linux-foundation.org, carver4lio@163.com,
        tiantao6@hisilicon.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ARM: change vmalloc_min to vmalloc_start
Message-ID: <20210520090024.GB30436@shell.armlinux.org.uk>
References: <20210518120633.GW12395@shell.armlinux.org.uk>
 <E1liyda-0005B4-Kk@rmk-PC.armlinux.org.uk>
 <a7ad5c03-025a-4cf8-e4b1-2d150bfe3066@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a7ad5c03-025a-4cf8-e4b1-2d150bfe3066@windriver.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: Russell King (Oracle) <linux@armlinux.org.uk>
Precedence: bulk

On Wed, May 19, 2021 at 12:41:10PM +0800, Xu, Yanfei wrote:
> On 5/18/21 8:15 PM, Russell King (Oracle) wrote:
> > -static unsigned long __initdata vmalloc_min =
> > -       VMALLOC_END - (240 << 20) - VMALLOC_OFFSET;
> > +static unsigned long __initdata vmalloc_start = VMALLOC_END - (240 << 20);
> > 
> >   /*
> >    * vmalloc=size forces the vmalloc area to be exactly 'size'
> > @@ -1169,7 +1168,8 @@ void __init adjust_lowmem_bounds(void)
> >           * and may itself be outside the valid range for which phys_addr_t
> >           * and therefore __pa() is defined.
> >           */
> > -       vmalloc_limit = (u64)vmalloc_min - PAGE_OFFSET + PHYS_OFFSET;
> > +       vmalloc_limit = (u64)vmalloc_start -
> > +                       (PAGE_OFFSET + PHYS_OFFSET + VMALLOC_OFFSET);
> > 
> Here is bug, it should be
> 
>        vmalloc_limit = (u64)vmalloc_start -
>                        (PAGE_OFFSET + VMALLOC_OFFSET) + PHYS_OFFSET;

Yes, you're absolutely right, thanks for catching that!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!