Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp302178pxj; Thu, 20 May 2021 09:38:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJtZ6xG674FC1IzxSPZgr+CgB0253Tl7tGGGSDwl8vjjto0poKwhaJhZ2ha0oHrhjkrD9V X-Received: by 2002:a05:6402:1713:: with SMTP id y19mr5917350edu.286.1621528731031; Thu, 20 May 2021 09:38:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621528731; cv=none; d=google.com; s=arc-20160816; b=gv1NIAJe0cPQXYqvYrEhCO1o1SADJFZ+YHuD515dfJKMKc3Q3ebDHXoI8frdLjFUdf MqQrKEhfhUMqNZyR7LD6FaDS9GIEOYw3tIcsGs4GCl9eKCEthLVsrIepPe9hh+f4ueP7 O7K5hL3EKlhtrDqmW2aVz06uKUMa3ZJiTbsNGKM1tVy0JCcixxf/+X2s1GQk04IjicuC uQ5UV2Sv7oOsCAXPNhXD8dVUfK4eC1Wg7aSl/y8rKUY2f2RwV73SNh4F1+wIZSh+Zrxb 4IGGw/IJ6V8WK4WMsGYY+1CetN1T9VsD6UDqYTyjSCpzUNxAuinXspiyDN/wRU0tJIqU zFow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YhfMM1YPOZm7/PILkXymPoHHJUhHSXRHQ8HOX+xCL38=; b=V1iiwKfUcbOAO7RlMA1VmGBPrPEVTiPtfT9LHaOM9Ddvyp8LKk25yD+tmcmY65/heH jT1O26UWIDw0TO0JvDEQne7et1Wmt55KGfr6eq8Z8vQN2XJMjuaAcxYI5izJfqK+ETtX kyGg8AX3QLeYEPLd1E9GiHmSHL8q4wORXcBDpyOj72LUCv+E8w+iOJkNAMse5ZE023Wd S2W7rfJjtpXt984i3qNKVhst54qX5qen1mEBaq07aQbfEc3E0kazNih45ucRkiqO1/r0 5xbQ/zaN+CsWLHeSViawALQ9keOfDX9baaqpquk2spARV28tWjj1+mRKN2BISTMBnuII qtbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=c6EfCJIs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e14si2840880edc.52.2021.05.20.09.38.27; Thu, 20 May 2021 09:38:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=c6EfCJIs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232870AbhETJkL (ORCPT + 99 others); Thu, 20 May 2021 05:40:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:41074 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233208AbhETJib (ORCPT ); Thu, 20 May 2021 05:38:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 515B560C3F; Thu, 20 May 2021 09:30:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621503044; bh=p8mI+Wuhtfl8p1E0bTgw9kbTE5SG8jh1j6N6+az7v8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c6EfCJIs4AaS03A7ClIthT9CnYv18vKfmAU4sUfEPIR2Y47OFojaaD1Q/osg4BVl9 4ZhO0HKgClvSlHaiBhFLyP9qnsBrfqTWq3o83jh8zlf7RnU/xyl+SWXI3HMhJEexA4 RBwabe7HFsYSRPJ6PHSl8xoQmJaxOkJBqriH3bb4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mike Christie , Johannes Thumshirn , Chaitanya Kulkarni , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.19 044/425] scsi: target: pscsi: Fix warning in pscsi_complete_cmd() Date: Thu, 20 May 2021 11:16:53 +0200 Message-Id: <20210520092132.871795270@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210520092131.308959589@linuxfoundation.org> References: <20210520092131.308959589@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chaitanya Kulkarni [ Upstream commit fd48c056a32ed6e7754c7c475490f3bed54ed378 ] This fixes a compilation warning in pscsi_complete_cmd(): drivers/target/target_core_pscsi.c: In function ‘pscsi_complete_cmd’: drivers/target/target_core_pscsi.c:624:5: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] ; /* XXX: TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE */ Link: https://lore.kernel.org/r/20210228055645.22253-5-chaitanya.kulkarni@wdc.com Reviewed-by: Mike Christie Reviewed-by: Johannes Thumshirn Signed-off-by: Chaitanya Kulkarni Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/target/target_core_pscsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c index 02c4e3beb264..1b52cd4d793f 100644 --- a/drivers/target/target_core_pscsi.c +++ b/drivers/target/target_core_pscsi.c @@ -633,8 +633,9 @@ static void pscsi_complete_cmd(struct se_cmd *cmd, u8 scsi_status, unsigned char *buf; buf = transport_kmap_data_sg(cmd); - if (!buf) + if (!buf) { ; /* XXX: TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE */ + } if (cdb[0] == MODE_SENSE_10) { if (!(buf[3] & 0x80)) -- 2.30.2