Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp309932pxj; Thu, 20 May 2021 09:49:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTJpRYnEWedX+RlkabegIPJkitWz3U70/RhpIkJULB7lfdtKWPV5kc64X1dPNhj/5TwMzG X-Received: by 2002:aa7:cd83:: with SMTP id x3mr5836791edv.373.1621529363315; Thu, 20 May 2021 09:49:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621529363; cv=none; d=google.com; s=arc-20160816; b=udSvflSQ/3AIC3AuGe96vxSGqUvgpzhMSsTy8caBEt90J3GYSGtHOPlj4Bepc293Zt VOUgcnAe+mdt6Sa+3v7qoHgvRqfyosE4grmwFEFcWE2DsusR76c6B4P39eN4iFTh3hiP ZqdyXDiC+iHIE3M1kB3I6ahAYvsnFGkG9utujM0FSxMXnPRCE1BJoMHjduL0MlBkxZs2 GetkudhnbVfRc7IhhCzVCK5vVNbW66CnqwVl/pdysDwHciYJQCJLmlZxe0gt7m6iXqew XsKgZM/hEmZsAikLD5xbL4ysu5zUCwr3amY1zPUKaY6exHugpouZDCPAxUtA5qwP+rSn CtqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=glMgdw0IWCzYteg7UEMRhIjiDtTqwPMJNVPQAWLuQUo=; b=VkoY/ExwkKQ6HTJxxw/JzZqPZLE47+ijnFi/G0k0TR697Uk5A3Le+Of7+j7SSy4Oyx TQWUX+WJcgW0WdxaSvqDiCbkYDcQ7m9BzogQMCZ9QzaUeXdYgBM3uEKe8aLDzWJmALbO R1X3UiSwkKv4OPkQppFVqSKTv1i2rKSWDSxgmfsat+8yfbxGi4JSOSW8sbqDdxOzZXBc LMDyXpctO3XzXV0dTuPkhJ5BzRUJ5F6DWliJ5jH77JItG9X6Ayuim1FZSxc3PDkraozc XRteXT4WqHayQDGWShbDHEEyATwz5t22wugQQ2+QK36ob8y2cgrqZDxym8a2t4t8IZ3Y 9Hpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ffcyNybZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ds10si3293649ejc.709.2021.05.20.09.48.58; Thu, 20 May 2021 09:49:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ffcyNybZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233734AbhETJut (ORCPT + 99 others); Thu, 20 May 2021 05:50:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:47556 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233568AbhETJsF (ORCPT ); Thu, 20 May 2021 05:48:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EDB6D61469; Thu, 20 May 2021 09:34:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621503274; bh=yxpHJJ/oK/1gEMlaFBhh+loU3+XnIaEbH6Bn0PlWoqg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ffcyNybZvAXPgBuy6vxGjh1oSJasSQpJk88h0Fg3Db7J3rNvlk9qoD6J7kJiwjx/d v9jJ1xB/ev5+CwE3Y0D16Fj+Op8D42CTPotTq5A3gPY09CPkeDlqGYm96GsllNojmk IIBVTsTcS362MC9H9WlFZh+HmHTg8i8X3xGUGoKs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marek Vasut , Amitkumar Karwar , Angus Ainslie , "David S. Miller" , Jakub Kicinski , Kalle Valo , Karun Eagalapati , Martin Kepplinger , Sebastian Krzyszkowiak , Siva Rebbagondla , netdev@vger.kernel.org Subject: [PATCH 4.19 113/425] rsi: Use resume_noirq for SDIO Date: Thu, 20 May 2021 11:18:02 +0200 Message-Id: <20210520092135.161796297@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210520092131.308959589@linuxfoundation.org> References: <20210520092131.308959589@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marek Vasut commit c434e5e48dc4e626364491455f97e2db0aa137b1 upstream. The rsi_resume() does access the bus to enable interrupts on the RSI SDIO WiFi card, however when calling sdio_claim_host() in the resume path, it is possible the bus is already claimed and sdio_claim_host() spins indefinitelly. Enable the SDIO card interrupts in resume_noirq instead to prevent anything else from claiming the SDIO bus first. Fixes: 20db07332736 ("rsi: sdio suspend and resume support") Signed-off-by: Marek Vasut Cc: Amitkumar Karwar Cc: Angus Ainslie Cc: David S. Miller Cc: Jakub Kicinski Cc: Kalle Valo Cc: Karun Eagalapati Cc: Martin Kepplinger Cc: Sebastian Krzyszkowiak Cc: Siva Rebbagondla Cc: netdev@vger.kernel.org Cc: stable@vger.kernel.org Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20210327235932.175896-1-marex@denx.de Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/rsi/rsi_91x_sdio.c +++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c @@ -1400,7 +1400,7 @@ static int rsi_restore(struct device *de } static const struct dev_pm_ops rsi_pm_ops = { .suspend = rsi_suspend, - .resume = rsi_resume, + .resume_noirq = rsi_resume, .freeze = rsi_freeze, .thaw = rsi_thaw, .restore = rsi_restore,