Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp316376pxj; Thu, 20 May 2021 09:59:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7Ipy/TA/QEql5OD9UpRvaNdfxcxht+s9P2sORGe5PxLnahgRfj9Og01G8cslJlsT8rzoJ X-Received: by 2002:a05:6e02:1b8f:: with SMTP id h15mr6318953ili.151.1621529940099; Thu, 20 May 2021 09:59:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621529940; cv=none; d=google.com; s=arc-20160816; b=BrWVPJkcg3xBGiWDg6tfYbUJUvBHdzbgRCeJaNwhElDmOKjENbl/MvkJHfgZJjkDTM VB8FBbGhVnFTjHCfcQ9j/0lSNeb8mCz0K7m8AlxzIm9q9kmxRpfzHVfZ0IvJ96dzUkjZ IEGfj4/vLWX64Lj3hGQajU/Gxuim2mDFLqZQgsySmMiknvCfBl0zYAsnqUu+95x4noLn vLaM0FlarjwusQd2vsK5r0nsvPctcFGqgmIORXLA2qGPUuHZab4fHezRJl2sVykhC+GJ m4BoFlzhIG2uswt6QF+doodvz4FNK8Khoy8KUU8e9xnMUePuHoBZwkAx5ju3O+HIpyBY aK7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4KQG3NNZzPjtja5hA6dCDne0vh7aFoPJtnNmCuhh4EU=; b=M2c4Y0EcLhK5Is5R9D7g6OIen5jtGo3owKjCNr2h16iCVLkh8emjTrq+BTZ1ZdaQNV jm3nZIAaUR7xLaG0pqDaO42gxIQndEThG+/mR5w7GathZ2gF9PXfF71vdReSCVZTEjl1 dBgWG+kIi/eNtGRzSJ5E/MirvxB8Tm9NX6F8HL2ciFdFZxK+EGbsPTVf7rxLe4rjY2ed EbidwVwvGpqWgzwHKYba9w/iu/c9uSrvxhUZA3a2uXOXY5rief8enwqIxDbhvTAa3vAW 2qvO7uM8iHbv8ALuiDZb6UNgJIJqlQTGhqsgEOCcEQQAZ8cLelNgvyv/i3nymplHV9Tw QXXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=swpsB329; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p31si3065810jac.95.2021.05.20.09.58.46; Thu, 20 May 2021 09:59:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=swpsB329; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234686AbhETKAc (ORCPT + 99 others); Thu, 20 May 2021 06:00:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:59150 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235145AbhETJzw (ORCPT ); Thu, 20 May 2021 05:55:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EF97E6140E; Thu, 20 May 2021 09:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621503449; bh=5y/e6ypZhSnhJtFtOgihi9LlIy/BfVv728prfW6YeHM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=swpsB329kyeijVNvHyWg7FAuxCRsKf4k+iLdhd9ewPNKwAQrb7Rhm3PKLl2mI8xAE AYLlbVl4Mkjy4BoM7NB7zfbgjvGHBzOgO05Xv3xkVeYrxI+Ne+hyNwFoa/Wp653bKp ahPtrmHefG7MyBFTLiMYLX9XuUM25ECdeo3/1JtI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Yang Yingliang , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.19 227/425] media: omap4iss: return error code when omap4iss_get() failed Date: Thu, 20 May 2021 11:19:56 +0200 Message-Id: <20210520092138.890347624@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210520092131.308959589@linuxfoundation.org> References: <20210520092131.308959589@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 8938c48fa25b491842ece9eb38f0bea0fcbaca44 ] If omap4iss_get() failed, it need return error code in iss_probe(). Fixes: 59f0ad807681 ("[media] v4l: omap4iss: Add support for OMAP4...") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/staging/media/omap4iss/iss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c index b1036baebb03..d796e754610c 100644 --- a/drivers/staging/media/omap4iss/iss.c +++ b/drivers/staging/media/omap4iss/iss.c @@ -1244,8 +1244,10 @@ static int iss_probe(struct platform_device *pdev) if (ret < 0) goto error; - if (!omap4iss_get(iss)) + if (!omap4iss_get(iss)) { + ret = -EINVAL; goto error; + } ret = iss_reset(iss); if (ret < 0) -- 2.30.2