Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 5.10 005/289] KVM: x86/mmu: Remove the defunct
 update_pte() paging hook
To:     Pavel Machek <pavel@denx.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Yu Zhang <yu.c.zhang@intel.com>,
        Sean Christopherson <seanjc@google.com>
References: <20210517140305.140529752@linuxfoundation.org>
 <20210517140305.340027792@linuxfoundation.org> <20210519195651.GA14212@amd>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <02d72616-2e95-f6cd-403c-60d5f2dfb3f1@redhat.com>
Date:   Thu, 20 May 2021 11:57:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210519195651.GA14212@amd>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19/05/21 21:56, Pavel Machek wrote:
> Hi!
> 
>> From: Sean Christopherson <seanjc@google.com>
>>
>> commit c5e2184d1544f9e56140791eff1a351bea2e63b9 upstream.
>>
>> Remove the update_pte() shadow paging logic, which was obsoleted by
>> commit 4731d4c7a077 ("KVM: MMU: out of sync shadow core"), but never
>> removed.  As pointed out by Yu, KVM never write protects leaf page
> 
> First, this is cleanup, not a bugfix.

It was reported to also fix a bug.  Commit 4731d4c7a077 is 2008 vintage, 
so it is certainly in 5.10.

Paolo

> Second, AFAICT 4731d4c7a077 ("KVM: MMU: out of sync shadow core") is
> not in 5.10, so this will break stuff according to the changelog.