Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp403891pxj; Thu, 20 May 2021 12:02:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOwv4AfZXRgKw0uMZN7wEbump87cOPT6X0JuSzPKwp0wtIuGN94u6vRp8zCKlw4TsbVOYM X-Received: by 2002:a05:6e02:1046:: with SMTP id p6mr6885021ilj.86.1621537320076; Thu, 20 May 2021 12:02:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621537320; cv=none; d=google.com; s=arc-20160816; b=xWFVc3tsaqMU1Zx6H57Lmkm22UbwNyUNs1kzMUvac+rA8BhYlFA9+n7v+7DaSYKROV +3YtkYPUlRxpk/7LQnYRYF+tMYu0IlQhhC4nFUg7rg2i4XrgTL/dRMfWx6O4LRz7tbno wl1UIeaFCmYosO8bL0LrpXXaF/jtUWN+6TxgWi2gltZrynK2e6YKSirvxVCuuPNCEb5P hR8JNrujw6PJX+fHj21DJJFWFtNO/neG/1XHjYvND3L9PiirwKA8kLBD9KBCBfBco14T am8yVs0dhNommAfLHRqldTO8d4TYMYIGQEO7LDPaVlRg2vuWK7kNaZl5/HjP1CUmW3hZ Qj3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Uxbg/iShNnNzBWrbITeLyOuwZ3ljbM13wUeG9Ju0n1E=; b=aW1q3mMXQdvKpAZxqIUaPZzTOlP4UbOXd1r2czdwkiGCS5ZtXf/8AXDBTauAIeD4wb WLQOLS/xzx2OKPzcNmaBGw/tYElp2fu1RBmSmJGMuwwVMMYwfl+FI2UQAZwSVn6xIj8+ 11xJEMA7eIRCDVWBMz3of5AamDRk55OM95s6aQDY/52HwCtMlcrc7I9G36xvMawB8y7q l9Pw/xNalfINqW7QfSJ9pVcTVGlXnBIDJBPFqcE3ikCI0xN4yXisfStGeaqKwteFtiuE iEMVUkJjhatBPKDDvwDME0usmbkw/NUH5LQemE2owCETj8qEXIk5yoDsdX901Bn5JoW+ rdMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ro2UF0m6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t10si3217799ilj.54.2021.05.20.12.01.46; Thu, 20 May 2021 12:02:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ro2UF0m6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236270AbhETK2H (ORCPT + 99 others); Thu, 20 May 2021 06:28:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:47630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236469AbhETKPQ (ORCPT ); Thu, 20 May 2021 06:15:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 100E06144E; Thu, 20 May 2021 09:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621503923; bh=W1dfffQwlch8RlK62erStBs4ROP1V/A9EDn3d3+p4hQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ro2UF0m6CBaReWMyVtLRhGtgHRX6x6rUuhp+LoO2GFViMbM0e1bO61ud9ZEPUyWUa W6qEhi7MGTwmelKCpnG8cD04Q6hTZxTJ5vZ3FEhRf8Lm9/2LN2eLxAxq7oyY0qlcQi 9mbjEFKUcWNTfcHMZhoqRr3i2LNVw1520HHmo/Nc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alan Stern , Chris Chiu Subject: [PATCH 4.14 015/323] USB: Add reset-resume quirk for WD19s Realtek Hub Date: Thu, 20 May 2021 11:18:27 +0200 Message-Id: <20210520092120.631746345@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210520092120.115153432@linuxfoundation.org> References: <20210520092120.115153432@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chris Chiu commit ca91fd8c7643d93bfc18a6fec1a0d3972a46a18a upstream. Realtek Hub (0bda:5487) in Dell Dock WD19 sometimes fails to work after the system resumes from suspend with remote wakeup enabled device connected: [ 1947.640907] hub 5-2.3:1.0: hub_ext_port_status failed (err = -71) [ 1947.641208] usb 5-2.3-port5: cannot disable (err = -71) [ 1947.641401] hub 5-2.3:1.0: hub_ext_port_status failed (err = -71) [ 1947.641450] usb 5-2.3-port4: cannot reset (err = -71) Information of this hub: T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 10 Spd=480 MxCh= 5 D: Ver= 2.10 Cls=09(hub ) Sub=00 Prot=02 MxPS=64 #Cfgs= 1 P: Vendor=0bda ProdID=5487 Rev= 1.47 S: Manufacturer=Dell Inc. S: Product=Dell dock C:* #Ifs= 1 Cfg#= 1 Atr=e0 MxPwr= 0mA I: If#= 0 Alt= 0 #EPs= 1 Cls=09(hub ) Sub=00 Prot=01 Driver=hub E: Ad=81(I) Atr=03(Int.) MxPS= 1 Ivl=256ms I:* If#= 0 Alt= 1 #EPs= 1 Cls=09(hub ) Sub=00 Prot=02 Driver=hub E: Ad=81(I) Atr=03(Int.) MxPS= 1 Ivl=256ms The failure results from the ETIMEDOUT by chance when turning on the suspend feature for the specified port of the hub. The port seems to be in an unknown state so the hub_activate during resume fails the hub_port_status, then the hub will fail to work. The quirky hub needs the reset-resume quirk to function correctly. Acked-by: Alan Stern Signed-off-by: Chris Chiu Cc: stable Link: https://lore.kernel.org/r/20210420174651.6202-1-chris.chiu@canonical.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/core/quirks.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -245,6 +245,7 @@ static const struct usb_device_id usb_qu /* Realtek hub in Dell WD19 (Type-C) */ { USB_DEVICE(0x0bda, 0x0487), .driver_info = USB_QUIRK_NO_LPM }, + { USB_DEVICE(0x0bda, 0x5487), .driver_info = USB_QUIRK_RESET_RESUME }, /* Generic RTL8153 based ethernet adapters */ { USB_DEVICE(0x0bda, 0x8153), .driver_info = USB_QUIRK_NO_LPM },