Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp443492pxj; Thu, 20 May 2021 13:03:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMiDcv6yW/oI8LEHFn0b2A1jGf9hictdHNMtnTReqM1l5nWz9iNb56iN0YBdvBQMQfmW3T X-Received: by 2002:a17:906:4704:: with SMTP id y4mr6497448ejq.68.1621541024996; Thu, 20 May 2021 13:03:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621541024; cv=none; d=google.com; s=arc-20160816; b=xduh8ZeaT4tpiy74NpA3ATo7/tC3kIpfAZrXH8Yn7rfyaTXXXuNK0m/glV9uvWW+i+ TBnsU+mO+kt3vS5R9iha4eywQhzDct6mRrzchridEMI351KY2yYBaAawhx4UYkKTMlFF J6MJixyI7CzHIq6wpOUVGyPdSSW/9LZIFTN9NNGTwVh6XA76hL7DsbgG4WODh49Ym7Ug tOvHHns6M5DsCgWNAzV7q/+0u4r/Kr7IL0mqZGLNduAZHTaK8ghS6Rc2s8YK4sqs88yE PaEgIbiO+u+RQJ8Yp8sMNB6J1L1xO3JwQ4IUSALsPn9wTYOajBDveLVS/2zlcTlnH+8f PHAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=tfArZSurceixSAXl2CdOi3/61RekBoJV5Hce7TQXGLo=; b=eGdJqwxie7Q/iRyshjouMhfU6R0PtZSk+hIhCTOEYEZ49DcA9YxNMc1CM60pTk0L/l Az7/WyWbxgi3C4lE62OaYjsG6Ra/WmiRDe1+MGJbp0KMkmJJn49XOQ9OpyQ6QWoi3cwJ uUhYaE46rauk69+c/YhfCF0rH7qzzSzrXUPmDzgF34x/xUXZJKiDqJhn6xn7+zwrKFjH t/ZV4LeCXAT6UB0cWPWBuuql4CpVCT6/nkuOjkLR8eLRplr4SjBPl/Ryqkz7gwdAEMjQ 0tHQKOgzcl6yaMtfsRo4wS5ZUgcqRXMFfdsiyChkppW0DJJ2L1beWzH+p1tdaxA2lMxT yyMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pGjckLlI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p5si3369207ejb.28.2021.05.20.13.03.20; Thu, 20 May 2021 13:03:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pGjckLlI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236413AbhETKpv (ORCPT + 99 others); Thu, 20 May 2021 06:45:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:60472 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237127AbhETK3j (ORCPT ); Thu, 20 May 2021 06:29:39 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 178346023B; Thu, 20 May 2021 09:51:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621504292; bh=nLaZ4mPuYunB74JpKyPuKjcu8B0IQppJM1qCRYgeFOs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pGjckLlITtPe5BZ2j5oyrmH2achuZB1hbfTHWDdQSLn1kMG04ziTcrEgX09xAgym6 UUnhvtjVXXuf6aDi+zji/d+WhhgXKkNfcUKq6hqms9JvXWAutRTCo13u/vYU27EYVV PE9gQMECc7baDU0l0CpYM5NUzyPxZuAtFCGBsZNs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Yang Yingliang , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 180/323] media: omap4iss: return error code when omap4iss_get() failed Date: Thu, 20 May 2021 11:21:12 +0200 Message-Id: <20210520092126.288871152@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210520092120.115153432@linuxfoundation.org> References: <20210520092120.115153432@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 8938c48fa25b491842ece9eb38f0bea0fcbaca44 ] If omap4iss_get() failed, it need return error code in iss_probe(). Fixes: 59f0ad807681 ("[media] v4l: omap4iss: Add support for OMAP4...") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/staging/media/omap4iss/iss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c index c26c99fd4a24..1e10fe204d3b 100644 --- a/drivers/staging/media/omap4iss/iss.c +++ b/drivers/staging/media/omap4iss/iss.c @@ -1244,8 +1244,10 @@ static int iss_probe(struct platform_device *pdev) if (ret < 0) goto error; - if (!omap4iss_get(iss)) + if (!omap4iss_get(iss)) { + ret = -EINVAL; goto error; + } ret = iss_reset(iss); if (ret < 0) -- 2.30.2