Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp546169pxj; Thu, 20 May 2021 15:53:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPHBo/jqo+0T/tlSRzT8kxqicMNJbKyRHkt3laEaggTo1FIa41+AB1X8lWBCw8v92ZY343 X-Received: by 2002:a02:900b:: with SMTP id w11mr8906552jaf.5.1621551204218; Thu, 20 May 2021 15:53:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621551204; cv=none; d=google.com; s=arc-20160816; b=SYDWkIHVKNnZTe3opFPax9aBdvXNO55P7DSfX73vtobHswheQ4wpVQKoaTniGHzI0d 2JHL1CWXyqxGMmGeGlraa6WgvHomqswFm2fXOPf8R4vmJBkSAZtW4utaZglaLZou5ci0 39ZPVBr2j7O4sy02PePXUS4KvXrzIyjpncMMT162eb360FW8csOGkrK8jR5j1FVQWgID PWPcK38gUQfD0jF68g2m7acEQ3LwKMAX4yK0fQYsDe1sSsj1O3W/Oa64vr+3pyo+8jl5 SJKCP+1DwQ/0cFW9nQ2aOULCycoWY2jjnzGgDhYVN7gLhGwDSBezV+ZSo5EOEGiliV77 9Mmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bvP2nyPgO4lHXwTh3sCDbCR887dv6EMsnR3tIgpv3p4=; b=oApzshLXoLGxVIpdEVaW9eWsQiHmavDdyI3sCtRhVdzuhVWC51rR1ifjQBiBsV8vxV 1TotXe4kGsOleQxkbqfGkn9ePOnX1mrh3G9CH4dTeqmyEs17c50qewbylXj5uaJqsn3L i3VRJk/dFGWpoCO9QlcFRiDIL1gEhIQvp8zKPpS1lnA6czbECkbS8V5WaTg2Z7Bv7jke Ra8OXe93UUmZrCPXWUnEcy9i95LIuoOoWsx8B2c7kwgMJAjHh/ADlj8tCugVK3+SKZLl wxuYPhq6sBDqRUMh/g4hCwA+UFHX8Q8pMjcBBVHQ3tA5S1nCyO3yWC+WpH3agGhYTJwK TKww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bajhpbXS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y10si3503042jan.19.2021.05.20.15.53.11; Thu, 20 May 2021 15:53:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bajhpbXS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240418AbhETLQS (ORCPT + 99 others); Thu, 20 May 2021 07:16:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:52232 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238218AbhETK4A (ORCPT ); Thu, 20 May 2021 06:56:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AB56E61CE6; Thu, 20 May 2021 10:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621504895; bh=wEos7WXOMHm+jSsREr1wT7HK3fZ2ULV1lTmouuYlNw4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bajhpbXSMLkGEfDOhRJsHR9xdUuNKeEM++NwteVIwN9tHqrNGFA+qkYOv8PG6OLKS aGatFO8FSpoJkKtrqLGooSMLeHeIdewdJmsZb57tln/nM92XhgXkv8xEUKZawvGlEC p/y8hmo3Nbo4HyvRAJbBO5Sg9WpSk74XyiDAuRpM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.9 129/240] scsi: fcoe: Fix mismatched fcoe_wwn_from_mac declaration Date: Thu, 20 May 2021 11:22:01 +0200 Message-Id: <20210520092112.993458670@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210520092108.587553970@linuxfoundation.org> References: <20210520092108.587553970@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit 5b11c9d80bde81f6896cc85b23aeaa9502a704ed ] An old cleanup changed the array size from MAX_ADDR_LEN to unspecified in the declaration, but now gcc-11 warns about this: drivers/scsi/fcoe/fcoe_ctlr.c:1972:37: error: argument 1 of type ‘unsigned char[32]’ with mismatched bound [-Werror=array-parameter=] 1972 | u64 fcoe_wwn_from_mac(unsigned char mac[MAX_ADDR_LEN], | ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ In file included from /git/arm-soc/drivers/scsi/fcoe/fcoe_ctlr.c:33: include/scsi/libfcoe.h:252:37: note: previously declared as ‘unsigned char[]’ 252 | u64 fcoe_wwn_from_mac(unsigned char mac[], unsigned int, unsigned int); | ~~~~~~~~~~~~~~^~~~~ Change the type back to what the function definition uses. Link: https://lore.kernel.org/r/20210322164702.957810-1-arnd@kernel.org Fixes: fdd78027fd47 ("[SCSI] fcoe: cleans up libfcoe.h and adds fcoe.h for fcoe module") Signed-off-by: Arnd Bergmann Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- include/scsi/libfcoe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/scsi/libfcoe.h b/include/scsi/libfcoe.h index 6be92eede5c0..a911f993219d 100644 --- a/include/scsi/libfcoe.h +++ b/include/scsi/libfcoe.h @@ -261,7 +261,7 @@ int fcoe_ctlr_recv_flogi(struct fcoe_ctlr *, struct fc_lport *, struct fc_frame *); /* libfcoe funcs */ -u64 fcoe_wwn_from_mac(unsigned char mac[], unsigned int, unsigned int); +u64 fcoe_wwn_from_mac(unsigned char mac[MAX_ADDR_LEN], unsigned int, unsigned int); int fcoe_libfc_config(struct fc_lport *, struct fcoe_ctlr *, const struct libfc_function_template *, int init_fcp); u32 fcoe_fc_crc(struct fc_frame *fp); -- 2.30.2