Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp564399pxj; Thu, 20 May 2021 16:20:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTGlXTqFyun2quz1HAjltBWYTqsb9vMTXknj91d7psnB36sMzhYCC57uFUyPOV0hUCYbt7 X-Received: by 2002:a17:906:36d1:: with SMTP id b17mr7284943ejc.235.1621552835203; Thu, 20 May 2021 16:20:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621552835; cv=none; d=google.com; s=arc-20160816; b=ltbg4NMmAt5HFrjW091RXYLKwdshyUvCHcaZ7kpvP5vdbaf6tN8/Ic4g3u8kXAhVx5 oW8ZHZwYwdwyjY1RIBg+le14JpruW3WOnMutJJu9KA8lM09RtDN3mdPrMmRTPTtGm6Sg XZZssyK+5gX/v3Uz3RIjAYl69+c146BdHqECU3NqLjU8gQrX+5dULkIEs7D6Dbr+szf7 3+hmag2edBbhknkwfcH3aOVLRW7tCzKerye/DhD415MbJ7EZQTNC9+XDQ+foupSw5xBH 2MsFbQTZSvdSgOhoQY05EY9AQlNp2jZc9IWzhiQjFnGU9oY3g5GkR9ZoQDcT2x9m8jmz RZ2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=vhfxir8ojqoQNtADOArAUvXUSnmADHCrnXjlraTiLj0=; b=PKWio3anHmSXmGMhY+8R8DLMUCUiHxUnMnsBrsEiSSD2t63NzSa01a+T6yFL4XR5nO /HO7s40KNF/77y7NVm1i9G92OFI6qkMMLz+D8dpvgtedYC+NCg4bru3eINvwJjMIqWbF IjrlMYK8XraiwzMx1KDRUFVIl5XBHu3KhS3A/fblm0pv5i+fAGhHJLWAx2AkuccvNUxJ MTJQK2WVlt3dThnDws+ddIbR5SL+BG9TOSzW4BV3GVx3zYgmFDIHsR7eKY0oBwI3Qz5X JCJfhQjLxu8PhvbauAGFPYX93YToPYNZXNwplG1Bs/0jVZjSCJTEuPp73bAlBSMap1Qu 8Ytg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=BtbNiTFF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 19si3604015ejx.529.2021.05.20.16.20.10; Thu, 20 May 2021 16:20:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=BtbNiTFF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241236AbhETL3I (ORCPT + 99 others); Thu, 20 May 2021 07:29:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:48156 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239820AbhETLJF (ORCPT ); Thu, 20 May 2021 07:09:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2E3BA60C41; Thu, 20 May 2021 10:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621505194; bh=oda4eqHRVFvsClBa5OXXc3KjLxo1xhYRA+i0CkL0TGM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BtbNiTFFdk4ZZNdtiYZynugMLsXxcYAJVGxZlsZe1w9qh7Plrkl/HpKHBxknl64oU 5UHca8c5ZLboitwJuWvCpad8sq7NjClVYjx9a+FC/T4sQb9EeEh/ils7Qjk57vjKN5 U0CLkisxSPvii/KdEmuHLD+9cXebfQ4J7A/oW9A0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mike Christie , Johannes Thumshirn , Chaitanya Kulkarni , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.4 024/190] scsi: target: pscsi: Fix warning in pscsi_complete_cmd() Date: Thu, 20 May 2021 11:21:28 +0200 Message-Id: <20210520092102.975931247@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210520092102.149300807@linuxfoundation.org> References: <20210520092102.149300807@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chaitanya Kulkarni [ Upstream commit fd48c056a32ed6e7754c7c475490f3bed54ed378 ] This fixes a compilation warning in pscsi_complete_cmd(): drivers/target/target_core_pscsi.c: In function ‘pscsi_complete_cmd’: drivers/target/target_core_pscsi.c:624:5: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] ; /* XXX: TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE */ Link: https://lore.kernel.org/r/20210228055645.22253-5-chaitanya.kulkarni@wdc.com Reviewed-by: Mike Christie Reviewed-by: Johannes Thumshirn Signed-off-by: Chaitanya Kulkarni Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/target/target_core_pscsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c index d72a4058fd08..0ce3697ecbd7 100644 --- a/drivers/target/target_core_pscsi.c +++ b/drivers/target/target_core_pscsi.c @@ -629,8 +629,9 @@ static void pscsi_transport_complete(struct se_cmd *cmd, struct scatterlist *sg, unsigned char *buf; buf = transport_kmap_data_sg(cmd); - if (!buf) + if (!buf) { ; /* XXX: TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE */ + } if (cdb[0] == MODE_SENSE_10) { if (!(buf[3] & 0x80)) -- 2.30.2