Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp666034pxj; Thu, 20 May 2021 19:23:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3USIBX4gHAsQS8G45bTDjaTp7dZ+r0MLjKoHl8w/0a1A4Qy7CVhadEwqujEKsjOJZ6+G8 X-Received: by 2002:a5d:9c9a:: with SMTP id p26mr8342166iop.94.1621563835389; Thu, 20 May 2021 19:23:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1621563835; cv=pass; d=google.com; s=arc-20160816; b=rkvbGMUhTomcyR3pFhZ40cwj/vdZwrETBYXxyftZYIKRkGbss9EBUgcuReRlHlnEHV Wr5AYz7pRljt2ATnmo57JmqIRo98diKuWp8ZOv5hwfvFNfiq6Z/MBEI4/Jqs/o/whEG+ cBDI6nfuSrhKUR8rMMvnju2OY1WmaZiBnGeimevg3DD3FX3xB/y7sKwR/UvjyQ3olCjG pBWNUZt1nZtLOl5MILrQM3+8jGJ24/nBku1fB4RKnPpuXZBEBsBt0TfUWdM1PkVpJ5yP toJPv5XWgAuv8KXIU9Lbnc1KKfj/imzra0XN1tas2SPzDcJuPg7pFe2Yxm3amCCwAj+o r8Yg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-language :content-transfer-encoding:in-reply-to:user-agent:date:message-id :from:references:cc:to:subject:dkim-signature; bh=s3wVp/R2XonmvCaDNXNHM46VljccrqXEN4yR1X43KDo=; b=KrvaZ213RijYNPTJAOBvzIbSHYLNRnIqQMKWKfzUv8siZQmROgXTyq7F+1Ti9MMh+e AHMQBz4owx2eJmZSzAG3PqC1FLSsvT5sxKdr4z23CWYAFcX/pDQTI9RCPjISMPVlqGhj xfE5+zSJKQgrv7DnUAK8h4zBXh9qvDJQwGQGsZPGVoi7HWLGEjy0Jys7LZOdMiVyhmd6 2MOulzNTvhqdfDTKmOMxG+uOSjgvzOO+Q+yaVfvCry3chkFYovSWNHUqY9WVUZdGIYXM Rw3iKftXMQAqU08C0eh2uEcWF0zdjpHSXFel6U0xlt1gl02bKYMP/IhQH3IQgnwy8xgy jwcg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=5I5mlgeb; arc=pass (i=1 spf=pass spfdomain=amd.com dkim=pass dkdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amd.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k8si3896584iov.91.2021.05.20.19.23.30; Thu, 20 May 2021 19:23:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=5I5mlgeb; arc=pass (i=1 spf=pass spfdomain=amd.com dkim=pass dkdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242197AbhETMHf (ORCPT + 99 others); Thu, 20 May 2021 08:07:35 -0400 Received: from mail-dm6nam08on2081.outbound.protection.outlook.com ([40.107.102.81]:49233 "EHLO NAM04-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S241306AbhETMHP (ORCPT ); Thu, 20 May 2021 08:07:15 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JgHNW6OS11mqr13Azx9He9D7F4bwcsp0VOJRNIrSI+W/K6QGpjXk9vfZkAAmi/tHVxqRdVo0N0+ZL0uBlcUvzcf2rUpmPOWbI7LRlPojNrF6Ey1kdG2z0kDNM0WLLdIJNO/NITYdhTptlamq4VZgv+NCzvrzvs/MapqEifIPWCYI37+ayf1S0z9i9BFnKadmn2EaFJSlnl+ZxCQ08rQwlmcr+S8EVm17Rgs+CAk9ZvjQ0EoCz+2kLvVL0wRXHHmwva87tlWNCklItob76IcC1cJ6WJ1JpB0itlRCPU2I2pqUxJxwap5GeU7Slss675622Ksu7NuQ+bmr5TaUrAU6lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s3wVp/R2XonmvCaDNXNHM46VljccrqXEN4yR1X43KDo=; b=jkP8XeVs/8Oko8lSm+KH9EbGhlF3jmLcwEm8iWeXrwN45YyTx1aQDlmw7a/RkqscAoHRgZZbWmr790CtOLuDiJTI2pCLaxCWuMwvy64rLNMilkRufti6/Vz9zUesk2mSujKyqAwq7dTR3r2JKOU4jG421DXFNU+/cgoY/CkeJ2I9Bc4yVXODoyavmNqGXgx6V66H95qYXAmiVPojOxTwukKFJc2ZOVhe3DoW0jDul/JBRET1/2bKT4S4EvJ0Y7bZJDPNbI3PKNQY3+K7A1tzlyKCebotB4fQVza5B7ePg3XBa1KHDMxXm9sD4Og73snSS50l/ehPgjIu8MvZ4cbOOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s3wVp/R2XonmvCaDNXNHM46VljccrqXEN4yR1X43KDo=; b=5I5mlgebduupsiVuzOU25nONg9RJTjirPKFuxd/y9lSktl9dfRgmZ215dojcXvo2Z4I10FBXNYr91hOeju8uYxgx9hI2esNgWjLF5cUbmnGL2jgIY/ISK8SOuLbTwQOErh6npC+xm10wYRSFqZG9VmDs4jTuWIkJDOB8LjKYQmo= Authentication-Results: lists.freedesktop.org; dkim=none (message not signed) header.d=none;lists.freedesktop.org; dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB3775.namprd12.prod.outlook.com (2603:10b6:208:159::19) by MN2PR12MB4392.namprd12.prod.outlook.com (2603:10b6:208:264::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.28; Thu, 20 May 2021 12:05:52 +0000 Received: from MN2PR12MB3775.namprd12.prod.outlook.com ([fe80::6d4d:4674:1cf6:8d34]) by MN2PR12MB3775.namprd12.prod.outlook.com ([fe80::6d4d:4674:1cf6:8d34%6]) with mapi id 15.20.4150.023; Thu, 20 May 2021 12:05:52 +0000 Subject: Re: [PATCH 20/38] drm/radeon/radeon_vm: Fix function naming disparities To: Lee Jones Cc: linux-kernel@vger.kernel.org, Alex Deucher , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20210520120248.3464013-1-lee.jones@linaro.org> <20210520120248.3464013-21-lee.jones@linaro.org> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Thu, 20 May 2021 14:05:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <20210520120248.3464013-21-lee.jones@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [2a02:908:1252:fb60:4635:589e:67a4:e02a] X-ClientProxiedBy: AM0PR10CA0023.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:17c::33) To MN2PR12MB3775.namprd12.prod.outlook.com (2603:10b6:208:159::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a02:908:1252:fb60:4635:589e:67a4:e02a] (2a02:908:1252:fb60:4635:589e:67a4:e02a) by AM0PR10CA0023.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:17c::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.33 via Frontend Transport; Thu, 20 May 2021 12:05:51 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 37e8ccbe-7440-4fca-cb2e-08d91b879d47 X-MS-TrafficTypeDiagnostic: MN2PR12MB4392: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:126; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eRYukHiiSkCQSxQInRNXDDs+4W55JfgYX4oCPvkbq/tI7zryrsV4LpGvKsbF9IZ1fTqA1rx84WfnVncwt6yQvUpqA9ruYIfnnaQanOqhxI6fNc4JO65AerEUCOs2j31X4hiHPld8gf8hvYef/2F7Knehu3i1dq32NQQ05mlDPiRmouuq/5/QxnkZDwBWVC0oyhU4CTvN3qxCqk9AXuZUTCuot/fzbr331m+AsehvWTEtdiAifMkRy4XWBBywdPQY0kzDb0VMuqHzu3IAuUvafs5kvgZZt9/0Du71ApLX2kNutDiBXFn3I+ne2uGTHT2H8JTi85jf9gGQhoqj7/MhaE/Z5ctvLW7YDkvhutWblF43kKQPFFooZQHcy6xeg3lPpOFEJMfvKQXXsiPE2ZpLmHOJn1uJ9EkThpdE3ecOlQaA1EtJhLTZmIhlGAXIEcLXRw2OFWmttbf5+vC6Dt4eKl8fYRtCm/ukZpBR6GTmX+triPSeTkko1GhYY/ONZhTA73RnBpqeUta8AETP8OQyUalo+VrnpijfQ/1+rpAAkxm5HT4KovnKIhaxpuTMUT+8sVF+FQ1M6pEGmUVhQ11DdJqC1MerZVv9foWQ7KhmQOfMGgkqXG/vfUiidEYgHUpU+M5abWD/JGtAyloYgOgun3xejgE2W51BVc9t4s895mx1ZQFjIa45oPpHBQ7neIHl X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(396003)(376002)(346002)(39860400002)(2616005)(38100700002)(478600001)(5660300002)(83380400001)(8936002)(186003)(2906002)(4326008)(31696002)(16526019)(54906003)(66946007)(66556008)(66476007)(6916009)(36756003)(52116002)(31686004)(86362001)(6486002)(316002)(8676002)(66574015)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZWoyYlNROGJhbjJEZ3Z3NE9rangxbnhoZmtEcmRiUWViODZsanE4Tk5HMXN0?= =?utf-8?B?ems3ZXVtN0IvY1lFTEw1VkU1OE1RNklxbllxbGFsVTg4UkxRdy9lQjB4VFJN?= =?utf-8?B?Nllzd0xOT0Z1VWlSb0Q1L1ZBZWhNQVZrNUlGNWZ1UGlaZFE0UW1saHhGQTFC?= =?utf-8?B?eC8yUWh2dlBjcVJnNFZrdnZNK1lyMCttTzg3RDlkeHl3Y3FDVkc1cjR0Q3dH?= =?utf-8?B?Y29kdURNdE9kM2RCZ2J4enNtSGNhQnk3aXpPelBUZjNnN0JPRDJKRVZwdFJN?= =?utf-8?B?WWJaMkhDN25lU0pYK3UzUWRpeVh1WkI5ZkxyVVJXN2paam9FaWhYUWRNZERw?= =?utf-8?B?R21SdWxib2s4aFM5b2wzV2dqRTNjVlJlRlZUTDl4V1lrSnJQeXJ1akt5cFRK?= =?utf-8?B?L1BTbHhrTUw5enJDZEs4SnFZRW9tckFoekZWRFBvVWZzeUJ5aWxsNnlHc2ls?= =?utf-8?B?TVp0aHB6Y2lWVGgrMTZQelNNb2p5V0NKUlZJa3AydjgyQmp3TFBUTVN6emFW?= =?utf-8?B?V2N4Q1BLSGJqQ3BnK3JIMStKcktNYmdaeUhxcGcveG9Mc0Z4TVlIU1N3bkJB?= =?utf-8?B?TGI3ZjVZZSt1M3VDK1VoL2FNNmJYYjNOdUtRYy81QjF0MmtCTjNFREhjVUt5?= =?utf-8?B?eVlGc1liR1Vjbm5Pa0x1dmZ1a2Y3UDc1ajdGa1Qyb2JwK3JXOE5DdTZyWkFp?= =?utf-8?B?ZG1RSW13cnpwekwyN3RzeUcyQnJGNmNKOFprOEJvRjlaNEJQck9kbVR2blR0?= =?utf-8?B?UVZlelJFNFNyUkJtelA3T0gxRlkxWFdIaGI3aEVnRm5OLytiWWJNcllLY1hJ?= =?utf-8?B?ZlpMUGNSRGJ6K3hEU3V0RmZ3UVVnKzVGejB6aVY4SVRLQkdxU3RxK2dPbFNF?= =?utf-8?B?NDNUcjlVRXZhRDg0YXZTU3dTMTdQeER3OGpsUTBPQnhVYkRSWk93d1g4ekxn?= =?utf-8?B?dFRMcUtrRGZmbzJvbjh2SXBHNlFjTFRHcWhKZk4wM0ZOejViOHVCeXhBOHlL?= =?utf-8?B?UHU3a0hPV3k0MVNma2l1Y241MmFDYnBaWTNHWUxLK0QyTFA5QWdGNjltRmFU?= =?utf-8?B?VlRqaExJUWVWZTJiR2hvUkgyMEZCeFpZaFp2bURnTEh2a0pNYWZib0JMVk13?= =?utf-8?B?N0NkYklxM1A5eTViRHBucUw4RWpiNDBIK09SQTF4akJ6dExYSEFRK0ZjZWRS?= =?utf-8?B?TWlRVjk0RHFHdDNTWDZDNFlBbE9WUHkwbDN4NWxEUnliUXJtNHRBMk8yN285?= =?utf-8?B?MGFrTXRIbHkrT0lkZzFBbmVGUCtXZUhzUUFxNnNFeEU5c1h3Z1g4akRuSkd3?= =?utf-8?B?Vmp1QWhyYSt3UHJvNVRoVVRSbnNzdDlpcFBUUytUckdvL0RCcG5hdGI1Ry9y?= =?utf-8?B?b1lsM1NrNjZrdWRtMDl1ZEhZWE9hbHc2eGNaSHpVWWM3UGpuOVVhRlV5d2Vr?= =?utf-8?B?R2FVTnJISzE4c2kycUdTZVRlYVVnQTlrUzhBMHpCZE1pL2JHWG9McVdCdnZK?= =?utf-8?B?c3RQTkszblBycGdVU2MvMHJHZzRCY3pSNU9aLzl5azQvWEc1UFl0WFRzUG5U?= =?utf-8?B?V2FXZ2RzeStSR3NraHlZTnRhdlhNNTdSeTMzeVJ2a2poQ3dSQ0Q3ajdMM09Z?= =?utf-8?B?bXdJMXIxUWJZbWluZ09seHNPais2TWdEdDUyZHJveWFWVW1VZHZyb000TlRK?= =?utf-8?B?UjVyME5mZzMvYW9ITjVHZUhWMHVIQm5rZnRjYWJHMHdQcWhDT21WNk9ZbnRQ?= =?utf-8?B?Mml1OEJkR1JLYVJDd1JjZzZnd1plNS9yc1pzRVBWSDMzdm1CUWFSK3REL3h1?= =?utf-8?B?UkQxUEZQZnlCNTJSUGRDV3hxRDR3b0t4REtPRWozbEU0Y0tpS0tZU0M0TlBy?= =?utf-8?Q?cWwjwQLagGbrq?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37e8ccbe-7440-4fca-cb2e-08d91b879d47 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2021 12:05:52.5547 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t6gIgAcAjUfdue6HMv3dRJIMomilw/lgR1T9kgArCUpt7i2snkI3Av8IMkXwKU7K X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4392 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 20.05.21 um 14:02 schrieb Lee Jones: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_vm.c:61: warning: expecting prototype for radeon_vm_num_pde(). Prototype was for radeon_vm_num_pdes() instead > drivers/gpu/drm/radeon/radeon_vm.c:642: warning: expecting prototype for radeon_vm_update_pdes(). Prototype was for radeon_vm_update_page_directory() instead > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Reviewed-by: Christian König > --- > drivers/gpu/drm/radeon/radeon_vm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c > index 2dc9c9f98049b..36a38adaaea96 100644 > --- a/drivers/gpu/drm/radeon/radeon_vm.c > +++ b/drivers/gpu/drm/radeon/radeon_vm.c > @@ -51,7 +51,7 @@ > */ > > /** > - * radeon_vm_num_pde - return the number of page directory entries > + * radeon_vm_num_pdes - return the number of page directory entries > * > * @rdev: radeon_device pointer > * > @@ -626,7 +626,7 @@ static uint32_t radeon_vm_page_flags(uint32_t flags) > } > > /** > - * radeon_vm_update_pdes - make sure that page directory is valid > + * radeon_vm_update_page_directory - make sure that page directory is valid > * > * @rdev: radeon_device pointer > * @vm: requested vm