Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 20 May 2021 16:53:07 +0200 (CEST)
From:   torvic9@mailbox.org
To:     Nick Desaulniers <ndesaulniers@google.com>
Cc:     "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "almaz.alexandrovich@paragon-software.com" 
        <almaz.alexandrovich@paragon-software.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        clang-built-linux <clang-built-linux@googlegroups.com>
Message-ID: <1291339880.1758.1621522387730@office.mailbox.org>
In-Reply-To: <CAKwvOd=Z1ia4ZufDbRsEUkumwkz15TtSb2V1aBT7SN8w86RKYw@mail.gmail.com>
References: <212218590.13874.1621431781547@office.mailbox.org>
 <CAKwvOd=Z1ia4ZufDbRsEUkumwkz15TtSb2V1aBT7SN8w86RKYw@mail.gmail.com>
Subject: Re: [PATCH] fs/ntfs3: make ntfs3 compile with clang-12
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Importance: Normal
Precedence: bulk


> Nick Desaulniers <ndesaulniers@google.com> hat am 20.05.2021 01:06 geschrieben:
> 
>  
> On Wed, May 19, 2021 at 6:43 AM <torvic9@mailbox.org> wrote:
> >
> > Some of the ccflags in the fs/ntfs3 Makefile are for gcc only.
> > Replace them with clang alternatives if necessary.
> >
> > Signed-off-by: Tor Vic <torvic9@mailbox.org>
> 
> Thanks for the patch. +clang-built-linux; please make sure to cc the
> lists from ./scripts/get_maintainer.pl <patch file>.  It should
> recommend our mailing list of the words clang or llvm appear anywhere
> in the patch file. This helps spread around the review burden.
> 

Cool, I didn't know about that script, thanks!

> > ---
> >  fs/ntfs3/Makefile | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/ntfs3/Makefile b/fs/ntfs3/Makefile
> > index b06a06cc0..dae144033 100644
> > --- a/fs/ntfs3/Makefile
> > +++ b/fs/ntfs3/Makefile
> > @@ -4,7 +4,9 @@
> >  #
> >
> >  # to check robot warnings
> > -ccflags-y += -Wunused-but-set-variable -Wold-style-declaration -Wint-to-pointer-cast
> > +ccflags-y += -Wint-to-pointer-cast \
> > +       $(call cc-option,-Wunused-but-set-variable,-Wunused-const-variable) \
> > +       $(call cc-option,-Wold-style-declaration,-Wout-of-line-declaration)
> 
> I think it would be better to leave off the second parameter of both
> of these, which is the fallback.

OK, I will do that.
Thanks for your feedback!

> 
> >
> >  obj-$(CONFIG_NTFS3_FS) += ntfs3.o
> >
> > --
> > 2.31.1
> 
> -- 
> Thanks,
> ~Nick Desaulniers