Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Danielle Ratson <danieller@nvidia.com>
To:     "po-hsu.lin@canonical.com" <po-hsu.lin@canonical.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "shuah@kernel.org" <shuah@kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "skhan@linuxfoundation.org" <skhan@linuxfoundation.org>
Subject: RE: [PATCH] selftests: net: devlink_port_split.py: skip the test if
 no devlink device
Thread-Topic: [PATCH] selftests: net: devlink_port_split.py: skip the test if
 no devlink device
Thread-Index: AddNiMpRdAu6PdslSI2GNdJ2nay2fw==
Date:   Thu, 20 May 2021 15:00:32 +0000
Message-ID: <MN2PR12MB451797BED9B8D96FDD18C255D82A9@MN2PR12MB4517.namprd12.prod.outlook.com>
Accept-Language: he-IL, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 234c5f37-b523-4857-38cd-08d91ba003d8
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2021 15:00:32.1122
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UusaTlXhIS4II9HWNwezhXYumXt6qtGljunXYdOe4wBHV1LUN9WvlVs2vw8sVlCrzqXTEEMHmTUSTc7uPnb3Fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4127
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Po-Hsu Lin <po-hsu.lin@canonical.com>
> Sent: Thursday, May 20, 2021 1:50 PM
> To: linux-kernel@vger.kernel.org; linux-kselftest@vger.kernel.org; netdev=
@vger.kernel.org
> Cc: po-hsu.lin@canonical.com; shuah@kernel.org; kuba@kernel.org; davem@da=
vemloft.net; skhan@linuxfoundation.org
> Subject: [PATCH] selftests: net: devlink_port_split.py: skip the test if =
no devlink device
>=20
> When there is no devlink device, the following command will return:
>   $ devlink -j dev show
>   {dev:{}}
>=20
> This will cause IndexError when trying to access the first element in dev=
 of this json dataset. Use the kselftest framework skip code to
> skip this test in this case.
>=20
> Example output with this change:
>   # selftests: net: devlink_port_split.py
>   # no devlink device was found, test skipped
>   ok 7 selftests: net: devlink_port_split.py # SKIP
>=20
> Link: https://bugs.launchpad.net/bugs/1928889
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>

Reviewed-by: Danielle Ratson <danieller@nvidia.com>