Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp811917pxj; Thu, 20 May 2021 23:04:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJ/oMS9waQwK0UCSLRudupN6oNndm/7XK0LzHhbXrnax1wlhzmTrZYhUyZy9hK/hiStg15 X-Received: by 2002:a17:906:22c6:: with SMTP id q6mr8588560eja.275.1621577051647; Thu, 20 May 2021 23:04:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621577051; cv=none; d=google.com; s=arc-20160816; b=enMHtKlMjDgNwXHV7gi9vJLsoswG9naoWnT7v5S3rodIFlCA8c7rNMap4G1RQTeCiv ibkbLXQSSEs1GAYF7MR3Gixop/krcrGImXs4cqUDbUAPMNHxgW8BwAZf8IrXe1KdUmUZ RzQrC6M7dGGjTFFLRpOM4pkTSYROQxt+EdJ7mNR5EZTlXjVVfzsWyjuXTo0xF85SQW8f aOIlTqdt6Yz88DtwwIFTOB2zID7wWZpMP2O1g/HTDKNlXOYicyHiiz8vWiVgFi5Z4gFZ esaTM5iSj/rQUhXw22TfNYE+nROikPDGt6683lT16Tju7vhLZ2h4K7eaJnMfW/sMMttW ibKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=2thoq06TT4N3hi9RRmUNxgrAVfVdF+93RckPU2uHJgU=; b=cPDYlHxBt1xmcvIthjTCyBZ2qaktPMw6n3O63oOHrts2fSgNYjNEIcYVMrcWy1KRM9 Mph5lz05wX/OW9ge+ayTFj2Nxy8vvl1DqR6KPNfU9hRquyKgifiGoSAXRjQH+y3g7K2Q e25V0DwLgJcBttJ/IQ0E7PWqs9nfyJR3tHwDdIiugQRCGykjzDA9zXvyudgQScM+5E1a YlH2zA7rOq2NhobBSKLqrKM0vZRp85PsA86Muo+vlcSrC0BCtd85zw+wrLE/+KXv1eFv TqxKLaI57TgOIcXanjOJbJbQ0YPObm364ffBgAEdSiuDn0Cx15WntRygdNAlF3Y4Oj1a zPpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm2 header.b="bTJv4oN/"; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=BXMu0zkg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d21si4701100ejm.343.2021.05.20.23.03.47; Thu, 20 May 2021 23:04:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm2 header.b="bTJv4oN/"; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=BXMu0zkg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240141AbhETPFY (ORCPT + 99 others); Thu, 20 May 2021 11:05:24 -0400 Received: from wnew2-smtp.messagingengine.com ([64.147.123.27]:44137 "EHLO wnew2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240413AbhETPFS (ORCPT ); Thu, 20 May 2021 11:05:18 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 971491618; Thu, 20 May 2021 11:03:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 20 May 2021 11:03:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=2thoq06TT4N3h i9RRmUNxgrAVfVdF+93RckPU2uHJgU=; b=bTJv4oN/ATSvtzQ3xHanmd1ZqIbLw tfovHDgG4btu7Xn+kQKsCsLDAl8ORqZX24kGHQK+aQG99+mzMVRb9EWSQyQ8Tq2U NxnQZtoH+Z7+HYybX+krXePhSSPscV+pcW/yrSQoN0nO0zzSHomzU2Huwe+osIog qsA9OlIBd0iQE7mJd3VQwGjFu+sPLSlq3xr+AI3k8qt1w1t0jJCmwNdCu3Ju/wVu cV3JE0OvzsTfQdR28SJArsI9x2hg31rR7Yo3SYEJNpdpXeg/SymERRIjvCmublae dXr4kMp1U3/Ygb3wpVxYeQEYgZhbHdrzGZxEUHYDBLzvM31QhqwebB6Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=2thoq06TT4N3hi9RRmUNxgrAVfVdF+93RckPU2uHJgU=; b=BXMu0zkg xVAXepK60dX8DJ/L5MZZzgpM6H7/FnZyOD5uEsCOcxDqO0UJzger3KNDFYC7m0YR YmUs+47L2XXo4Nd9n+id0bpIinBZhoIu9W3dM4z0xOthk56qqxJhCSyURrQpeIpb xkJqhdrxCuHsx8T5hgeNTwYooCJUU9Wchz/b+KKdbVwwK82zRjUSic+otoedvAFt UdM/SHEVPSFNR3BJw36HM5BHYHLbb+ATSkDCjaSUY7Da+LvXC94nkc/IARlxcgRi jJKQ5Xc3iF9BZb3jsl0sB9TMJUDDLIOkrK9JoESvr716PIsfwNxZ//Pd5bChUW3z GMcmkgyzQZonJQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejuddgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepvdekleevfeffkeejhfffueelteelfeduieefheduudfggffhhfffheevveeh hedvnecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 May 2021 11:03:52 -0400 (EDT) From: Maxime Ripard To: dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard Cc: Florian Fainelli , Maxime Ripard , Eric Anholt , bcm-kernel-feedback-list@broadcom.com, Ray Jui , devicetree@vger.kernel.org, Scott Branden , linux-kernel@vger.kernel.org, Daniel Vetter , Rob Herring , linux-rpi-kernel@lists.infradead.org, Nicolas Saenz Julienne , linux-arm-kernel@lists.infradead.org, Mateusz Kwiatkowski Subject: [PATCH 1/4] drm/vc4: Fix clock source for VEC PixelValve on BCM2711 Date: Thu, 20 May 2021 17:03:41 +0200 Message-Id: <20210520150344.273900-2-maxime@cerno.tech> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210520150344.273900-1-maxime@cerno.tech> References: <20210520150344.273900-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mateusz Kwiatkowski On the BCM2711 (Raspberry Pi 4), the VEC is actually connected to output 2 of pixelvalve3. NOTE: This contradicts the Broadcom docs, but has been empirically tested and confirmed by Raspberry Pi firmware devs. Signed-off-by: Mateusz Kwiatkowski Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index 76657dcdf9b0..665ddf8f347f 100644 --- a/drivers/gpu/drm/vc4/vc4_crtc.c +++ b/drivers/gpu/drm/vc4/vc4_crtc.c @@ -994,7 +994,7 @@ static const struct vc4_pv_data bcm2711_pv3_data = { .fifo_depth = 64, .pixels_per_clock = 1, .encoder_types = { - [0] = VC4_ENCODER_TYPE_VEC, + [PV_CONTROL_CLK_SELECT_VEC] = VC4_ENCODER_TYPE_VEC, }, }; -- 2.31.1