Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210520120248.3464013-1-lee.jones@linaro.org> <20210520120248.3464013-31-lee.jones@linaro.org>
In-Reply-To: <20210520120248.3464013-31-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Thu, 20 May 2021 15:21:39 -0400
Message-ID: <CADnq5_Nx=Zf=tGBP+V0sJEQRfuygyizdQoTZfLiRccvqcrJFtQ@mail.gmail.com>
Subject: Re: [PATCH 30/38] drm/amd/amdgpu/gfx_v9_4_2: Mark functions called by
 reference as static
To:     Lee Jones <lee.jones@linaro.org>
Cc:     David Airlie <airlied@linux.ie>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Thu, May 20, 2021 at 8:03 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c:1008:5: warning: no previous pro=
totype for =E2=80=98gfx_v9_4_2_query_ras_error_count=E2=80=99 [-Wmissing-pr=
ototypes]
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c:1054:6: warning: no previous pro=
totype for =E2=80=98gfx_v9_4_2_reset_ras_error_count=E2=80=99 [-Wmissing-pr=
ototypes]
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c:1063:5: warning: no previous pro=
totype for =E2=80=98gfx_v9_4_2_ras_error_inject=E2=80=99 [-Wmissing-prototy=
pes]
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c:1133:6: warning: no previous pro=
totype for =E2=80=98gfx_v9_4_2_query_ras_error_status=E2=80=99 [-Wmissing-p=
rototypes]
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c:1143:6: warning: no previous pro=
totype for =E2=80=98gfx_v9_4_2_reset_ras_error_status=E2=80=99 [-Wmissing-p=
rototypes]
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c:1153:6: warning: no previous pro=
totype for =E2=80=98gfx_v9_4_2_enable_watchdog_timer=E2=80=99 [-Wmissing-pr=
ototypes]
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c b/drivers/gpu/drm/am=
d/amdgpu/gfx_v9_4_2.c
> index dbad9ef002d59..87ec96a18a5dd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c
> @@ -1641,8 +1641,8 @@ static int gfx_v9_4_2_query_utc_edc_count(struct am=
dgpu_device *adev,
>         return 0;
>  }
>
> -int gfx_v9_4_2_query_ras_error_count(struct amdgpu_device *adev,
> -                                  void *ras_error_status)
> +static int gfx_v9_4_2_query_ras_error_count(struct amdgpu_device *adev,
> +                                           void *ras_error_status)
>  {
>         struct ras_err_data *err_data =3D (struct ras_err_data *)ras_erro=
r_status;
>         uint32_t sec_count =3D 0, ded_count =3D 0;
> @@ -1690,7 +1690,7 @@ static void gfx_v9_4_2_reset_ea_err_status(struct a=
mdgpu_device *adev)
>         mutex_unlock(&adev->grbm_idx_mutex);
>  }
>
> -void gfx_v9_4_2_reset_ras_error_count(struct amdgpu_device *adev)
> +static void gfx_v9_4_2_reset_ras_error_count(struct amdgpu_device *adev)
>  {
>         if (!amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__GFX))
>                 return;
> @@ -1699,7 +1699,7 @@ void gfx_v9_4_2_reset_ras_error_count(struct amdgpu=
_device *adev)
>         gfx_v9_4_2_query_utc_edc_count(adev, NULL, NULL);
>  }
>
> -int gfx_v9_4_2_ras_error_inject(struct amdgpu_device *adev, void *inject=
_if)
> +static int gfx_v9_4_2_ras_error_inject(struct amdgpu_device *adev, void =
*inject_if)
>  {
>         struct ras_inject_if *info =3D (struct ras_inject_if *)inject_if;
>         int ret;
> @@ -1772,7 +1772,7 @@ static void gfx_v9_4_2_query_utc_err_status(struct =
amdgpu_device *adev)
>         }
>  }
>
> -void gfx_v9_4_2_query_ras_error_status(struct amdgpu_device *adev)
> +static void gfx_v9_4_2_query_ras_error_status(struct amdgpu_device *adev=
)
>  {
>         if (!amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__GFX))
>                 return;
> @@ -1782,7 +1782,7 @@ void gfx_v9_4_2_query_ras_error_status(struct amdgp=
u_device *adev)
>         gfx_v9_4_2_query_sq_timeout_status(adev);
>  }
>
> -void gfx_v9_4_2_reset_ras_error_status(struct amdgpu_device *adev)
> +static void gfx_v9_4_2_reset_ras_error_status(struct amdgpu_device *adev=
)
>  {
>         if (!amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__GFX))
>                 return;
> @@ -1792,7 +1792,7 @@ void gfx_v9_4_2_reset_ras_error_status(struct amdgp=
u_device *adev)
>         gfx_v9_4_2_reset_sq_timeout_status(adev);
>  }
>
> -void gfx_v9_4_2_enable_watchdog_timer(struct amdgpu_device *adev)
> +static void gfx_v9_4_2_enable_watchdog_timer(struct amdgpu_device *adev)
>  {
>         uint32_t i;
>         uint32_t data;
> --
> 2.31.1
>