Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp857956pxj; Fri, 21 May 2021 00:19:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9NbAOcio+v5fDuMgbeUzeDTGmNb2BYVlAj8apCtMRzDJPldNMBJ81EWtqVFEDODdhgNNJ X-Received: by 2002:a17:906:e294:: with SMTP id gg20mr8889993ejb.227.1621581565258; Fri, 21 May 2021 00:19:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621581565; cv=none; d=google.com; s=arc-20160816; b=ry6lYjprOcx/C90R4LRNAfWWVVcGKhzunQfoek2g8dw+ZyuY5O3qT3wAeE8At44j1L zwJPmXkJTFcHZXx1LH9LwXmgPyuHO2CRZ+d11zgP4KvdH3LOrDSOlBNoWiEnMcDL88XU 3WtuFOYUUXg6c7/4wPJoL/koGDpsPKTOrp5AW4YV56qZLMy2U277NUN1h4MrMT+qGKUQ yeGHE8lYOTgPevy0Y1z/dlsLW3xuRzdFSbcQjlNHWW57DOxTQOeUSR9L4UmsjTwZ44WE q2lwWO2yRNkygaA3CsH4uXzenMK8Rks62s6NU8kVUFobjiFfuC5xe+J9HPY+wbKeufjS r4wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=k8jbqnkIhb6Scb2ilNgSqrLUoD8EKnp1ewooO1thaYY=; b=0ZnGrjtm33Dhv9Cg1pRn4+MflNdI2He/pLzZMzqgnsiXy8qYRHJaIeGvriROoYgqs1 QwoRiQOoGPmmXq4OOi/RKMJlLt6+5GARkyMXcsQw+8rIckbPBpbXLGh65sNX9t0Wx75J 7QWaQfQDAkYE+pyptGsuZA/F3px/fauu9ReyDAOvOVs8Uq/GmIoLDbuGUGCb2AFxVqbF iQ+DahOyHmQBY7/Gr3900USuLNuvA7/ihZOpnoCIZIblao58CKmj1S47lBYrrv01hjTS G4VZdqAdmmHf45ArJyMSfJ4Dso3O//vw1mmDM9ZzKs/A2lnfGNWjPwngvr/6cGtt4C/t ZuKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ky35ahVt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t12si5288796edc.179.2021.05.21.00.19.00; Fri, 21 May 2021 00:19:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ky35ahVt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237084AbhETTYz (ORCPT + 99 others); Thu, 20 May 2021 15:24:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237886AbhETTYy (ORCPT ); Thu, 20 May 2021 15:24:54 -0400 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D26BDC061574; Thu, 20 May 2021 12:23:31 -0700 (PDT) Received: by mail-oi1-x22a.google.com with SMTP id c196so9248857oib.9; Thu, 20 May 2021 12:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=k8jbqnkIhb6Scb2ilNgSqrLUoD8EKnp1ewooO1thaYY=; b=ky35ahVtuQfQMvjOeiiTTPbXaYneyr4RFONeMzlHZyexsj5rX8XhdDpXsJiz3dYVul wYEKc3B8k42wdypOpMotQdOBiW6RXqUf466s1oEBZQU6IkBUzqApaFH279BKcODv9hry PkF70uZo9+I53o7qHAZUR34SlhlZoBHznh7PXCQFdZ4P27ZO3q0mS1oAkkk6diq9K7wA H0TVgKnJXqieJQMfk5bah0AGLFSycfWfD1VdIj7QrdhLZc3kUcsgrJHYSJ5WnDM3V1ln buTBOgiEZaYLxzGvxv+fah+PD2XV36vh3/drhElt98f6HpQPL7x3i7dthMbIZ7mDX0/o QpRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=k8jbqnkIhb6Scb2ilNgSqrLUoD8EKnp1ewooO1thaYY=; b=r0nyKadkVAFx8nADUa8z2Vk7NZhhhnZH3OKMEwvgWly6yqSzXCFuCbI5Vx1auvx+JJ CZ6DipMmyv+aHdUr2zKVc2B802vGqbw5/eaY2f/W9S6SrV2fKsyFoRIK3GJzRBn142fu cbns3UB071xASMgCU9S914iBGtGw5Ouc6LhcUQCiZqELjp+kqhyQpGAi5y+5QtkFXE6y kuI1EK9TSpnB3rxTDQJCFJ6DcEM+Kpw+Mmb35kgf8Kz17G8bYCpmGJVc1V3M2VManZiO aMyAc82iUl8WwVMfgmUnD6OKv4gjq4+aq7RvpFIRHV09r+xFdwitG25F2XfhidAQmL3X +Jyg== X-Gm-Message-State: AOAM531fbsyZ+tVODq01OUGa0l8jRr9cK2ekc6WXgcdHMoz7JfZ/H3FN ukwpkJF3Gpz20Nu29TXq44bSzwlV2n5d1kyTtlA= X-Received: by 2002:a05:6808:249:: with SMTP id m9mr4210776oie.120.1621538611248; Thu, 20 May 2021 12:23:31 -0700 (PDT) MIME-Version: 1.0 References: <20210520120248.3464013-1-lee.jones@linaro.org> <20210520120248.3464013-33-lee.jones@linaro.org> In-Reply-To: <20210520120248.3464013-33-lee.jones@linaro.org> From: Alex Deucher Date: Thu, 20 May 2021 15:23:20 -0400 Message-ID: Subject: Re: [PATCH 32/38] drm/amd/amdgpu/sdma_v4_0: Realign functions with their headers To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , =?UTF-8?Q?Christian_K=C3=B6nig?= , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Maling list - DRI developers , Alex Deucher , linux-media Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! On Thu, May 20, 2021 at 8:03 AM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:764: warning: expecting prototype= for sdma_v4_0_page_ring_set_wptr(). Prototype was for sdma_v4_0_ring_set_w= ptr() instead > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:830: warning: expecting prototype= for sdma_v4_0_ring_set_wptr(). Prototype was for sdma_v4_0_page_ring_set_w= ptr() instead > > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd= /amdgpu/sdma_v4_0.c > index d197185f77890..ae5464e2535a8 100644 > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > @@ -754,7 +754,7 @@ static uint64_t sdma_v4_0_ring_get_wptr(struct amdgpu= _ring *ring) > } > > /** > - * sdma_v4_0_page_ring_set_wptr - commit the write pointer > + * sdma_v4_0_ring_set_wptr - commit the write pointer > * > * @ring: amdgpu ring pointer > * > @@ -820,7 +820,7 @@ static uint64_t sdma_v4_0_page_ring_get_wptr(struct a= mdgpu_ring *ring) > } > > /** > - * sdma_v4_0_ring_set_wptr - commit the write pointer > + * sdma_v4_0_page_ring_set_wptr - commit the write pointer > * > * @ring: amdgpu ring pointer > * > -- > 2.31.1 >