Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp892102pxj; Fri, 21 May 2021 01:21:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+so4c7do8E6jydLW8JvnoJspdJKh/9haNpSV+AE4QgLngGb1Ct1B/bOnYUgb64XUHoUY/ X-Received: by 2002:a02:3506:: with SMTP id k6mr2731109jaa.39.1621585308453; Fri, 21 May 2021 01:21:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621585308; cv=none; d=google.com; s=arc-20160816; b=em4IBxAg1x4/C/tKwx1JhRz43oQ+Q4Wfy29eGSH6Pbe542ytDz9XkFZLyzFaTZjPtH uoS24lqMW8QRSIVBKXCahj/EqQGS55cwlbnzR2UmASQ6LImd5K4YZ19K5NSannrsfi1t eAXGE1Wujz8hr4B4nncfI42z1DUUDm7dF7ghMX/xOP4zp7dNyUNMNL3nJYZmIKEVkcIz xsRaOO8KntsQGMetJ9eLcSFjmuKB+olltKMJuw7xmRD8/TEqzryOOHXM+rse+AaKxFZj pfRpfEfPPp95WCgrgPZX2WQbaKbJtAIb556mOGZT9h7z1Eoz0qZHc5tFeXDYR7PZ/upt 5beA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=YCAjaobPhU5qICs0q6tK0PgQtF7Mp5xmX07HD2ZCcpY=; b=LtddB/G0RSJAF3ZukURBAqsoQ8cl4YQS52wJARgOg8lJuAPZk4iJJgJp6SB8o0vqgz qVwNwJL6ddAb9JGf3DoZdulgTRcfuN5ZXRle4COXsx6mux5YLeK8kAPP5wJRFkN+PkPT MVrWy589mUo+BAw5+SHPUEswtAXFPaEJ0LFTZPyEm9yJgHSn3p5LxiUh8sSZzbmJChp9 nqXhw/KGhf3mUsMUK6b5tzvddEau2jisRgouibOiiKDJN3QdGCiVcuxmmulquKh6yQea oo9ZV8H6PgkOJidnNo9KPFZV4QIQcHy4yqwb/xTwBBPQyuXMQJ1wKm54s6vyoATz/TIe K13w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g16si4994428jat.43.2021.05.21.01.21.35; Fri, 21 May 2021 01:21:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231493AbhETWZu (ORCPT + 99 others); Thu, 20 May 2021 18:25:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230145AbhETWZt (ORCPT ); Thu, 20 May 2021 18:25:49 -0400 Received: from mail.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDF72C061574; Thu, 20 May 2021 15:24:27 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id 437744F488CC2; Thu, 20 May 2021 15:24:25 -0700 (PDT) Date: Thu, 20 May 2021 15:24:21 -0700 (PDT) Message-Id: <20210520.152421.1110528865195726730.davem@davemloft.net> To: olek2@wp.pl Cc: hauke@hauke-m.de, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: lantiq: fix memory corruption in RX ring From: David Miller In-Reply-To: <20210520184054.38477-1-olek2@wp.pl> References: <20210520184054.38477-1-olek2@wp.pl> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Thu, 20 May 2021 15:24:25 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aleksander Jan Bajkowski Date: Thu, 20 May 2021 20:40:54 +0200 > In a situation where memory allocation or dma mapping fails, an > invalid address is programmed into the descriptor. This can lead > to memory corruption. If the memory allocation fails, DMA should > reuse the previous skb and mapping and drop the packet. This patch > also increments rx drop counter. > > Signed-off-by: Aleksander Jan Bajkowski Please repost this with an appropriate Fixes: tag, thank you.