Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Pavel Begunkov <asml.silence@gmail.com>
CC:     "io-uring@vger.kernel.org" <io-uring@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jens Axboe <axboe@kernel.dk>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
        Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Horst Schirmeier <horst.schirmeier@tu-dortmund.de>,
        "Franz-B . Tuneke" <franz-bernhard.tuneke@tu-dortmund.de>,
        Christian Dietrich <stettberger@dokucode.de>
Subject: Re: [RFC v2 00/23] io_uring BPF requests
Thread-Topic: [RFC v2 00/23] io_uring BPF requests
Thread-Index: AQHXTLk0PY0K4B6IqEqB44IqdJi08qrtGQAA
Date:   Fri, 21 May 2021 00:35:40 +0000
Message-ID: <0A3E3601-76CC-4196-8246-CCAEB8C8AED3@fb.com>
References: <cover.1621424513.git.asml.silence@gmail.com>
In-Reply-To: <cover.1621424513.git.asml.silence@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <71F1770653941A43B98C3FA8B1085457@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6bbc3533-0221-4c28-1d65-08d91bf05ca1
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2021 00:35:40.4882
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8BnZjXaZLkXaKu9s88O+ydNacoRo8pcswiCj9r0UIdDDQgf5/4wcnnCPrQHJBa1UKOvFA3xum3BJC1kFPNr2MA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1348
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: 5ZPrAUlBnQCmZGWJzy6CzHj0dF3062c4
X-Proofpoint-GUID: 5ZPrAUlBnQCmZGWJzy6CzHj0dF3062c4
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761
 definitions=2021-05-20_07:2021-05-20,2021-05-20 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 clxscore=1015
 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 mlxscore=0
 bulkscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 mlxlogscore=999
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2105210000
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On May 19, 2021, at 7:13 AM, Pavel Begunkov <asml.silence@gmail.com> wrot=
e:
>=20
> The main problem solved is feeding completion information of other
> requests in a form of CQEs back into BPF. I decided to wire up support
> for multiple completion queues (aka CQs) and give BPF programs access to
> them, so leaving userspace in control over synchronisation that should
> be much more flexible that the link-based approach.
>=20
> For instance, there can be a separate CQ for each BPF program, so no
> extra sync is needed, and communication can be done by submitting a
> request targeting a neighboring CQ or submitting a CQE there directly
> (see test3 below). CQ is choosen by sqe->cq_idx, so everyone can
> cross-fire if willing.
>=20

[...]

>  bpf: add IOURING program type
>  io_uring: implement bpf prog registration
>  io_uring: add support for bpf requests
>  io_uring: enable BPF to submit SQEs
>  io_uring: enable bpf to submit CQEs
>  io_uring: enable bpf to reap CQEs
>  libbpf: support io_uring
>  io_uring: pass user_data to bpf executor
>  bpf: Add bpf_copy_to_user() helper
>  io_uring: wire bpf copy to user
>  io_uring: don't wait on CQ exclusively
>  io_uring: enable bpf reqs to wait for CQs

Besides the a few comments, these BPF related patches look sane to me.=20
Please consider add some selftests (tools/testing/selftests/bpf).=20

Thanks,
Song=20