Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp914878pxj; Fri, 21 May 2021 02:02:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmpp1iZ3XiDZAE95br+/64FZ/UBcobMNGHTfvwonJZnDOAGG1UdTop4tUcD1A1hcRcmzfH X-Received: by 2002:a17:906:3949:: with SMTP id g9mr9410039eje.7.1621587757849; Fri, 21 May 2021 02:02:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621587757; cv=none; d=google.com; s=arc-20160816; b=APX7ndL37PMDnnLuIIgva8fkh7PjoFQLRFRxYsRjFtgNfCeXk8myjvj6tYcRfpP5zW XwetuffsJ+aqI50WbudQUOpdht3ZKbgys/C8JMgR7/gcCxla9jWPvKzM5EDHTV5Lyosc 77MeSgxTP3ZWkGpXMV7C0IjMgIJRnhepEPgUQLlmQTEJW7hEOfm2Sizw1cgRbas0kURp AKk+0v2s8L2XdwpIV9J/AC9Cxs3vMHaydGLR8jSYvWoAv+tbzGRA4+JRm4mzmTHAG8PT /9u5L/SUF5eg82HQg5HgntIanU5MtycImEe5u5Z+ZwpLo4j3OaGpJLYNo2L5jm4QEuoZ nsTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=JIf7zEjRGFp+aX5aq2XvC/gz4Py3qeQXpX3D2x+m3DQ=; b=DyCWEMrv8AaJOBXzs52o3vn4orv9PlZZ/6ZU6ECtmYAAILQIj/4nMn+kMHOnvN16cO TF0WFHolJ+LCApK7JGSSHLGzm+eg0j9CFSSUADvJd44dMynNVVrBkr3VADnmFhEeaK5f blOMDO9DbNEH0qxEqfvJTY2/OIALfT5/Jl5Hct+jjs44Sin1QivFlLflzGRC2Hvtnwc0 Q5nzRkBSQcT+eu3L3AsD3z1TK8qNCvek27h5OXAIRKPtgnvOQ4Mmr0QnsU7rcsQNHBIW e/9df/IXV88ScsO/NN0Q0muQkz0lnu/27lDCxEg/ALrNNi1fIRiJJS+X9YyBhPso7b7D tT9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gy3si4955219ejb.557.2021.05.21.02.02.14; Fri, 21 May 2021 02:02:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236325AbhEUBMq (ORCPT + 99 others); Thu, 20 May 2021 21:12:46 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:5708 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236065AbhEUBMj (ORCPT ); Thu, 20 May 2021 21:12:39 -0400 Received: from dggems705-chm.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FmT405cFczqVWS; Fri, 21 May 2021 09:07:44 +0800 (CST) Received: from dggemi759-chm.china.huawei.com (10.1.198.145) by dggems705-chm.china.huawei.com (10.3.19.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Fri, 21 May 2021 09:11:16 +0800 Received: from localhost.localdomain (10.67.165.24) by dggemi759-chm.china.huawei.com (10.1.198.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 21 May 2021 09:11:15 +0800 From: Guangbin Huang To: , , , , CC: , , , , Subject: [PATCH net-next 6/6] net: wan: add necessary () to macro argument Date: Fri, 21 May 2021 09:08:17 +0800 Message-ID: <1621559297-9651-7-git-send-email-huangguangbin2@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1621559297-9651-1-git-send-email-huangguangbin2@huawei.com> References: <1621559297-9651-1-git-send-email-huangguangbin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggemi759-chm.china.huawei.com (10.1.198.145) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peng Li Macro argument 'card' and 'port' may be better as '(card)' and '(port)' to avoid precedence issues. Signed-off-by: Peng Li Signed-off-by: Guangbin Huang --- drivers/net/wan/hd64572.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/wan/hd64572.c b/drivers/net/wan/hd64572.c index 7fccf23c8bef..b89b03a6aba7 100644 --- a/drivers/net/wan/hd64572.c +++ b/drivers/net/wan/hd64572.c @@ -41,16 +41,16 @@ #define NAPI_WEIGHT 16 -#define get_msci(port) (port->chan ? MSCI1_OFFSET : MSCI0_OFFSET) -#define get_dmac_rx(port) (port->chan ? DMAC1RX_OFFSET : DMAC0RX_OFFSET) -#define get_dmac_tx(port) (port->chan ? DMAC1TX_OFFSET : DMAC0TX_OFFSET) - -#define sca_in(reg, card) readb(card->scabase + (reg)) -#define sca_out(value, reg, card) writeb(value, card->scabase + (reg)) -#define sca_inw(reg, card) readw(card->scabase + (reg)) -#define sca_outw(value, reg, card) writew(value, card->scabase + (reg)) -#define sca_inl(reg, card) readl(card->scabase + (reg)) -#define sca_outl(value, reg, card) writel(value, card->scabase + (reg)) +#define get_msci(port) ((port)->chan ? MSCI1_OFFSET : MSCI0_OFFSET) +#define get_dmac_rx(port) ((port)->chan ? DMAC1RX_OFFSET : DMAC0RX_OFFSET) +#define get_dmac_tx(port) ((port)->chan ? DMAC1TX_OFFSET : DMAC0TX_OFFSET) + +#define sca_in(reg, card) readb((card)->scabase + (reg)) +#define sca_out(value, reg, card) writeb(value, (card)->scabase + (reg)) +#define sca_inw(reg, card) readw((card)->scabase + (reg)) +#define sca_outw(value, reg, card) writew(value, (card)->scabase + (reg)) +#define sca_inl(reg, card) readl((card)->scabase + (reg)) +#define sca_outl(value, reg, card) writel(value, (card)->scabase + (reg)) static int sca_poll(struct napi_struct *napi, int budget); -- 2.8.1