Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp948974pxj; Fri, 21 May 2021 03:00:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytZW4rr1eR+bdPJVDACxz2ATVYT118VFoyXkFKt3wr3FS9GdC2lO4DG1HQ0JmGOON5RkRw X-Received: by 2002:a17:906:d7ac:: with SMTP id pk12mr9671220ejb.143.1621591221299; Fri, 21 May 2021 03:00:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621591221; cv=none; d=google.com; s=arc-20160816; b=nU+BNkzmIAw4HLWpGPgr8zVjwyTMg5pazsIeLHrj/mhxqV7wXSyFVg9QEgom80fOSq PugWoN1TUqe3fNFWWchyp+/1OeR6G8wnxUmawOYG+yxZdIedBfs+ZDI8tRk5YNwpu4h9 fzd/1Aoz+9QMup09HrPT7EZHomeLoIcd+XndNocrjc8Z+4YCF4R87J3+Zet7kxbsKV5e 09LacxXlhqQoM88weN9SeCbk2UHOLddD6SqQXr/CkecjflohEgDGuS7pP0Bvveot9k/J ZsPDiHovlvaMDoZ+5256QsLbZsmJLX6fzr3pVdRNCXxuQFcLniSKCMyWxDH6hOpILazA 91Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:organization :message-id:date:subject:cc:to:from; bh=RM9S08l+JkmuHQp0V5RDuEgbuO8pmBDD3yERPqoR5m4=; b=Ofs3/LPPX6L6fYfC3Iw5+XEjPou9+qgjon1GmnSmKXHt1fQenTzKZqUkIiUkl+hrMH FJa3gQGcWAoTliPbHDBCdZWYVKjVUx2iIH3ikCgbzJX1TvsOM4XO+1rXCbnEaohtHyyK m9Xm4kjolhnqX/jAO5D3Rqerca4N6F+AVXH6cpis8kVK0/SWiQbRZ300cm1Ps0faMc5h eKerlXwQhuTVwKAj71GzUAsY60ai4c7VUpg0BCJ0TSSFyO2N0/GUnU/LNi8TOl1jCq3S q5n4aLch7RzzZncjzQKiNYZTWONL3HTrhr5MQO3oLrd7v2zNZhQ2cD3+ZTS9+DxXLM61 3IvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c10si4641048edr.581.2021.05.21.02.59.58; Fri, 21 May 2021 03:00:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234399AbhEUGyx (ORCPT + 99 others); Fri, 21 May 2021 02:54:53 -0400 Received: from mx1.emlix.com ([136.243.223.33]:52748 "EHLO mx1.emlix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234422AbhEUGyt (ORCPT ); Fri, 21 May 2021 02:54:49 -0400 Received: from mailer.emlix.com (p5098be52.dip0.t-ipconnect.de [80.152.190.82]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id 6BAB06051C; Fri, 21 May 2021 08:53:25 +0200 (CEST) From: Rolf Eike Beer To: Joerg Roedel , Will Deacon , Lu Baolu Cc: baolu.lu@linux.intel.com, David Woodhouse , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/vt-d: Fix sysfs leak in alloc_domain() Date: Fri, 21 May 2021 08:53:22 +0200 Message-ID: <1889881.5hqWi3GpDC@devpool47> Organization: emlix GmbH In-Reply-To: References: <1716403.SmlLz2RZUD@devpool47> <17411490.HIIP88n32C@mobilepool36.emlix.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3163522.BJEOxDOq7s"; micalg="pgp-sha256"; protocol="application/pgp-signature" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart3163522.BJEOxDOq7s Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8"; protected-headers="v1" From: Rolf Eike Beer To: Joerg Roedel , Will Deacon , Lu Baolu Cc: baolu.lu@linux.intel.com, David Woodhouse , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/vt-d: Fix sysfs leak in alloc_domain() Date: Fri, 21 May 2021 08:53:22 +0200 Message-ID: <1889881.5hqWi3GpDC@devpool47> Organization: emlix GmbH In-Reply-To: References: <1716403.SmlLz2RZUD@devpool47> <17411490.HIIP88n32C@mobilepool36.emlix.com> Am Donnerstag, 22. April 2021, 07:34:17 CEST schrieb Lu Baolu: > Hi Rolf, >=20 > On 4/22/21 1:39 PM, Rolf Eike Beer wrote: > > iommu_device_sysfs_add() is called before, so is has to be cleaned on > > subsequent errors. > >=20 > > Fixes: 39ab9555c2411 ("iommu: Add sysfs bindings for struct iommu_devic= e") > > Cc: stable@vger.kernel.org # 4.11.x > > Signed-off-by: Rolf Eike Beer >=20 > Acked-by: Lu Baolu Ping. Who is going to pick this up, please? Eike =2D-=20 Rolf Eike Beer, emlix GmbH, http://www.emlix.com =46on +49 551 30664-0, Fax +49 551 30664-11 Gothaer Platz 3, 37083 G=C3=B6ttingen, Germany Sitz der Gesellschaft: G=C3=B6ttingen, Amtsgericht G=C3=B6ttingen HR B 3160 Gesch=C3=A4ftsf=C3=BChrung: Heike Jordan, Dr. Uwe Kracke =E2=80=93 Ust-IdNr= =2E: DE 205 198 055 emlix - smart embedded open source --nextPart3163522.BJEOxDOq7s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iLMEAAEIAB0WIQQ/Uctzh31xzAxFCLur5FH7Xu2t/AUCYKdY4gAKCRCr5FH7Xu2t /ACxBADM0v8DMoBMsSIwqGZQTN5UG8+C8zbDs8rpd6pngku/cGNYaHVKaiq9oG41 hXUJEJJVYru+33WKfYb6yLgDogvf7qclfBwqK3Wz180G2nxCqfZ9yAxz4VCexuvY bYUpOruM3oSwnt+j5WDIBANdct//q1fNc9BDPJgROZ7fws16Dg== =OzhT -----END PGP SIGNATURE----- --nextPart3163522.BJEOxDOq7s--