Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1020190pxj; Fri, 21 May 2021 04:45:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxY7dlPFwJ6AloYw/I4X1zadNzm+hHnYVzMe4y3zMN47pAgzGGL3QW9VZpenqJLG+m7nQ/ X-Received: by 2002:a17:907:1b20:: with SMTP id mp32mr10046305ejc.495.1621597521031; Fri, 21 May 2021 04:45:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621597521; cv=none; d=google.com; s=arc-20160816; b=W/mbyiiIbJ+nVLNyXyVNTfHWxdh+VMEiOhW5J+8LM7uB2J0S/KiVR/T+mvFCeOHG+L V4AZ0uzRWRwQnprf4nyG6u8SLtyzyGBY44k7sBmIrhfEB/jvv6+R/xwg6YWrvH2NaRqb 35LRUTEZPP/X2TrLQm65Vfv+Rub+AGn65NhgyoZsP53B3VY33Td7/LnoGs3LUqGHODMv 342VuPF8dsmiDXGM/32WPvNEtH59SueCegpOgn7+uxVag3FGWqUwM0s2nMlcs6I4QkTi nfmP/oPL55AglniqUVNNzXd14VPYKqA3tFLqRw1ZOWQWe+U5B6+jqlc6ai/oj7nNpYky z83g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=2FGyVujyraAaKsH1D5DhmJiuQHm9E1uva7wjZNURhNY=; b=MUK6w7e9WAtYgagRf9xsvt6Uzr1exXkynJBl+puS66Mu5yQAL1/L3jzoKpmsNEq3Rl gv8yKCbxd4f0+f2D7CakSi+VnHnDZW+ywdMaivwtPaxWNQu5Mfrappj+D3xY7zCvbKBz AL0/ZLa0JKs/R8FXtLRoLC1EleT7fYHkKaWLtWbVG3n8z7eO70IqBq2AQvIQVzosOTeM 0j5C2NMgRkasH+Mys1x67LwYcwvklRTE/m2A1DGjxdpEGR4D2RKQ8w/5m7wO5nDsOCUk SGcaoO178Hh6/skNiQTCvQ+BeuEqyN+zQaS9MmmFCaHrHOFhDVL+6KTtDP2nbX+xLixO Ec+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kl4si743263ejc.648.2021.05.21.04.44.57; Fri, 21 May 2021 04:45:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233613AbhEUKH4 (ORCPT + 99 others); Fri, 21 May 2021 06:07:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:44528 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231995AbhEUKHo (ORCPT ); Fri, 21 May 2021 06:07:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 09393AAA6; Fri, 21 May 2021 10:06:20 +0000 (UTC) Date: Fri, 21 May 2021 12:06:19 +0200 From: Jean Delvare To: Lee Jones Cc: linux-kernel@vger.kernel.org, Rudolf Marek , linux-i2c@vger.kernel.org Subject: Re: [PATCH 03/16] i2c: busses: i2c-ali1563: File headers are not good candidates for kernel-doc Message-ID: <20210521120619.503cb7d9@endymion> In-Reply-To: <20210520190105.3772683-4-lee.jones@linaro.org> References: <20210520190105.3772683-1-lee.jones@linaro.org> <20210520190105.3772683-4-lee.jones@linaro.org> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, On Thu, 20 May 2021 20:00:52 +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/i2c/busses/i2c-ali1563.c:24: warning: expecting prototype for i2c(). Prototype was for ALI1563_MAX_TIMEOUT() instead Thanks for taking care of the warnings. I agree that a clean W=1 build would be very nice to have. > Cc: Jean Delvare > Cc: Rudolf Marek > Cc: linux-i2c@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/i2c/busses/i2c-ali1563.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c > index 4d12e3da12f0d..55a9e93fbfeb5 100644 > --- a/drivers/i2c/busses/i2c-ali1563.c > +++ b/drivers/i2c/busses/i2c-ali1563.c > @@ -1,5 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0-only > -/** > +/* > * i2c-ali1563.c - i2c driver for the ALi 1563 Southbridge > * > * Copyright (C) 2004 Patrick Mochel Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support