Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1064166pxj; Fri, 21 May 2021 05:46:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxd/LgHY9PrIUKTJTG3vM0nflLQ9wu0AtVm09yK1gH057eXislpMY/foIVTIwrPMV1iVuKx X-Received: by 2002:a5d:8485:: with SMTP id t5mr11669455iom.89.1621601164677; Fri, 21 May 2021 05:46:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621601164; cv=none; d=google.com; s=arc-20160816; b=QxRVf0PPYywGVU/Bkh9ajHXWhmVvWIGagW8lCLVEpQOQDWVmcbgwVdxnmz6ZIz2WD5 S/tNV9dFP5u6zvQ9CQdO68x1ZOGYN4gXUveIDoA0xTEm2y5xbSHVpkYsWOh6T5Cfl+i2 uICn+ETf1+LXRV5hZj2ifgo4Fa8s4KV/neq3jwurYjkSHaZs+2+7jzl3+HOnNKZDxjf/ oOE270S59Df/Z7AJAj+8qqMfs0nltB2voBDr8ZryDsQZGhBC1XDFihN7cEqsENZLA6Vo zmyJ4uMGu3+DZts5LVRxU5aB3w9jO5Ujmv2hyanA6m3+r4daUgLSKutpUyNnHFd7ZUy7 cW7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=38KdVwDRKeC4PEEnDgdlxKX1IvtilXpiBA6LkIlfIjI=; b=gx6sV4DA92GZQXSOOGhu86HOvwPoiAOHTadlVMOm+Ta9T5IEgxE5ABXf6zkkTXxxHf EsM6OQZKu0/lhXg4d/NV3NMmDyLpodCPT+a+qlFx0sflSEiDphny9qlQTAl1bVuiwJcM DjskqdQt3Sl7r17a/bCy8WBCU4umBypeZMFGv9TNe+zNe4riUfc3S3jPm8wBKZ5G3jWW WGytx2zraf/N2NJETJzD+cjjwtym7DFOkiCc/NuBDqWnyq3iw33g9/0OgnwQz278YCup Sysz7TuCEVV37R+jymuob9KR8pGh+VsKl4nx1jB2BKevPac+D2VI6OR8fn1p7h/TJmEy JWjQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j10si5731812ilc.16.2021.05.21.05.45.51; Fri, 21 May 2021 05:46:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232170AbhEUMAc (ORCPT + 99 others); Fri, 21 May 2021 08:00:32 -0400 Received: from mga11.intel.com ([192.55.52.93]:56835 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbhEUMAc (ORCPT ); Fri, 21 May 2021 08:00:32 -0400 IronPort-SDR: IDLUEa0KXgG51GtPP2rYzQIqL5SVjNeb+zopv8+3GYa63nlgY9t2nGCH7vQ4RrbNbWYffl/Kk1 Z6CeQaFwVOJA== X-IronPort-AV: E=McAfee;i="6200,9189,9990"; a="198383135" X-IronPort-AV: E=Sophos;i="5.82,319,1613462400"; d="scan'208";a="198383135" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2021 04:59:08 -0700 IronPort-SDR: 964GNzNNcueW7f3X+WLXZ13B02Xofd6Gu9fJaDkF68VNSvJ82YDwp/y/0znW57e2L83MY8k6pL SG5vvUXG/BMw== X-IronPort-AV: E=Sophos;i="5.82,319,1613462400"; d="scan'208";a="462463118" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2021 04:59:06 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lk3nz-00Dha1-CT; Fri, 21 May 2021 14:59:03 +0300 Date: Fri, 21 May 2021 14:59:03 +0300 From: Andy Shevchenko To: Andrew Morton Cc: Rikard Falkeborn , Tetsuo Handa , Yury Norov , linux-kernel@vger.kernel.org, Ard Biesheuvel , Peter Zijlstra Subject: Re: [PATCH] linux/bits.h: Fix compilation error with GENMASK Message-ID: References: <20210511203716.117010-1-rikard.falkeborn@gmail.com> <20210520134112.ee15f156f1b7dbd3d8f16471@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210520134112.ee15f156f1b7dbd3d8f16471@linux-foundation.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 20, 2021 at 01:41:12PM -0700, Andrew Morton wrote: > On Tue, 11 May 2021 22:37:15 +0200 Rikard Falkeborn wrote: > > > --- a/include/linux/const.h > > +++ b/include/linux/const.h > > @@ -3,4 +3,12 @@ > > > > #include > > > > +/* > > + * This returns a constant expression while determining if an argument is > > + * a constant expression, most importantly without evaluating the argument. > > + * Glory to Martin Uecker > > + */ > > +#define __is_constexpr(x) \ > > + (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8))) > > Boggle. > > Could someone please sometime enhance that comment a bit? What need > does this thing satisfy and how on earth does it work? Some summary based on (links from) https://vegard.wiki/w/is_constexpr() ? -- With Best Regards, Andy Shevchenko