Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210514085500.10761-1-aardelean@deviqon.com>
In-Reply-To: <20210514085500.10761-1-aardelean@deviqon.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Fri, 21 May 2021 15:28:49 +0200
Message-ID: <CAMpxmJX4DjZ9NE_8BH7kB4jYA+LyLJ=zbXbh7cg37Jaw52ppKQ@mail.gmail.com>
Subject: Re: [PATCH] gpio: gpio-visconti: remove platform_set_drvdata() +
 cleanup probe
To:     Alexandru Ardelean <aardelean@deviqon.com>
Cc:     linux-gpio <linux-gpio@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, May 14, 2021 at 10:55 AM Alexandru Ardelean
<aardelean@deviqon.com> wrote:
>
> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
>  drivers/gpio/gpio-visconti.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/gpio/gpio-visconti.c b/drivers/gpio/gpio-visconti.c
> index 0e3d19828eb1..47455810bdb9 100644
> --- a/drivers/gpio/gpio-visconti.c
> +++ b/drivers/gpio/gpio-visconti.c
> @@ -187,15 +187,7 @@ static int visconti_gpio_probe(struct platform_device *pdev)
>         girq->default_type = IRQ_TYPE_NONE;
>         girq->handler = handle_level_irq;
>
> -       ret = devm_gpiochip_add_data(dev, &priv->gpio_chip, priv);
> -       if (ret) {
> -               dev_err(dev, "failed to add GPIO chip\n");
> -               return ret;
> -       }
> -
> -       platform_set_drvdata(pdev, priv);
> -
> -       return ret;
> +       return devm_gpiochip_add_data(dev, &priv->gpio_chip, priv);
>  }
>
>  static const struct of_device_id visconti_gpio_of_match[] = {
> --
> 2.31.1
>

Applied, thanks!

Bartosz