Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] fpga: generalize updating to partial and full
To:     Moritz Fischer <mdf@kernel.org>
Cc:     hao.wu@intel.com, michal.simek@xilinx.com,
        linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
References: <20210519204256.1975957-1-trix@redhat.com>
 <YKV55XK1Py5YSXZp@epycbox.lan>
From:   Tom Rix <trix@redhat.com>
Message-ID: <2e79a2f8-1917-b7f2-4b19-2a742ba0e28a@redhat.com>
Date:   Thu, 20 May 2021 07:36:53 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <YKV55XK1Py5YSXZp@epycbox.lan>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 5/19/21 1:49 PM, Moritz Fischer wrote:
> Tom,
>
> On Wed, May 19, 2021 at 01:42:56PM -0700, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> There is a need to update the whole card.
>> The user area, the shell and even the card firmware.
>> This needs to be handled differently than the
>> existing partial updating in the fpga manager.
>>
>> Move the write_* ops out of fpga_manager_ops and
>> into a new fpga_manager_update_ops struct.  Add
>> two update_ops back to fpga_manager_ops,
>> partial_update for the exiting functionality and
>> full_update for the new functionity.
> Partial and Full are somewhat loaded terms with FPGAs -- think partial
> reconfiguration vs full reconfiguration.
>
> How about 'persistent' and 'volatile' or something along those lines
> instead?

I think that only applies to xilinx,  its all persistent for dfl.

How about calling it what it is.

partial_update -> partial_reconfiguration

full_update -> board_reimage

Tom

> - Moritz
>