Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210518232858.1535403-1-robh@kernel.org> <20210518232858.1535403-2-robh@kernel.org>
 <72b27bc0-838c-fd7d-32f8-bc00f8508d1d@ti.com>
In-Reply-To: <72b27bc0-838c-fd7d-32f8-bc00f8508d1d@ti.com>
From:   Rob Herring <robh@kernel.org>
Date:   Thu, 20 May 2021 10:19:45 -0500
Message-ID: <CAL_JsqLXK6nY9qHRdYK0VGCjAMmkKktWXe9rjkY6rsveYinhRg@mail.gmail.com>
Subject: Re: [PATCH 1/6] dt-bindings: mfd: ti,j721e-system-controller: Fix mux
 node errors
To:     Kishon Vijay Abraham I <kishon@ti.com>
Cc:     devicetree@vger.kernel.org, Peter Rosin <peda@axentia.se>,
        Wolfram Sang <wsa@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Jacopo Mondi <jacopo+renesas@jmondi.org>,
        Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Lee Jones <lee.jones@linaro.org>,
        =?UTF-8?Q?Niklas_S=C3=B6derlund?= 
        <niklas.soderlund+renesas@ragnatech.se>,
        Jonathan Cameron <jic23@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, May 20, 2021 at 9:42 AM Kishon Vijay Abraham I <kishon@ti.com> wrote:
>
> Hi Rob,
>
> On 19/05/21 4:58 am, Rob Herring wrote:
> > The ti,j721e-system-controller binding does not follow the standard mux
> > controller node name 'mux-controller' and the example is incomplete. Fix
> > these to avoid schema errors before the mux controller binding is
> > converted to schema.
> >
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Kishon Vijay Abraham I <kishon@ti.com>
> > Cc: Roger Quadros <rogerq@ti.com>
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> >  .../mfd/ti,j721e-system-controller.yaml       | 19 +++++++++++++------
> >  1 file changed, 13 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
> > index 19fcf59fd2fe..272832e9f8f2 100644
> > --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
> > @@ -43,12 +43,10 @@ properties:
> >
> >  patternProperties:
> >    # Optional children
> > -  "^serdes-ln-ctrl@[0-9a-f]+$":
> > +  "^mux-controller@[0-9a-f]+$":
> >      type: object
> > -    description: |
> > -      This is the SERDES lane control mux. It should follow the bindings
> > -      specified in
> > -      Documentation/devicetree/bindings/mux/reg-mux.txt
> > +    description:
> > +      This is the SERDES lane control mux.
> >
> >  required:
> >    - compatible
> > @@ -68,9 +66,18 @@ examples:
> >          #size-cells = <1>;
> >          ranges;
> >
> > -        serdes_ln_ctrl: serdes-ln-ctrl@4080 {
> > +        serdes_ln_ctrl: mux-controller@4080 {
> >              compatible = "mmio-mux";
> >              reg = <0x00004080 0x50>;
>
> "mmio-mux" compatible doesn't define using "reg" property. But a system
> can have multiple mux-controllers which would require us to use
> mux-controller@0, mux-controller@1,..

It does now in patch 3 as part of the schema conversion. It's optional
as getting folks to use 'reg' for syscon child nodes is an uphill
battle.

Rob
>
> And IIRC if we have "@", 'reg' will be a required required property.
> Would it be an issue here?
>
> Thanks
> Kishon