Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 20 May 2021 17:11:47 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Xiaofei Tan <tanxiaofei@huawei.com>
Cc:     jirislaby@kernel.org, linux-kernel@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, linuxarm@openeuler.org
Subject: Re: [PATCH 0/9] tty: hvc_console: Fix some coding style issues
Message-ID: <YKZ8M8j5/bUJxLq5@kroah.com>
References: <1621233433-27094-1-git-send-email-tanxiaofei@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1621233433-27094-1-git-send-email-tanxiaofei@huawei.com>
Precedence: bulk

On Mon, May 17, 2021 at 02:37:04PM +0800, Xiaofei Tan wrote:
> Fix some issues reported by checkpatch.pl. All of them are
> coding style issues, no function changes.
> 
> Xiaofei Tan (9):
>   tty: hvc_console: Fix spaces required around that '='
>   tty: hvc_console: Fix "foo * bar" should be "foo *bar"
>   tty: hvc_console: Remove trailing whitespace
>   tty: hvc_console: Fix issues of code indent should use tabs
>   tty: hvc_console: Delete spaces prohibited around open parenthesis '('
>     and ')'
>   tty: hvc_console: Fix coding style issues of block comments
>   tty: hvc_console: Add a blank line after declarations
>   tty: hvc_console: Remove the repeated words 'no' and 'from'
>   tty: hvc_console: Move open brace { on the previous line
> 
>  drivers/tty/hvc/hvc_console.c | 37 ++++++++++++++++++++++---------------
>  1 file changed, 22 insertions(+), 15 deletions(-)

Do you use this driver?  If so, great, I'm sure there are other "real"
issues in it that need some work.  But as Johan points out, doing
drive-by checkpatch cleanups on random files that you do not use, isn't
the best thing to do.

If you just want to do this type of work, please do so in
drivers/staging/ as it is most welcome there if you wish to get involved
in kernel work to get experience before doing "real" stuff.

thanks,
g
reg k-h