Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161340AbWJ3R6n (ORCPT ); Mon, 30 Oct 2006 12:58:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965349AbWJ3R6n (ORCPT ); Mon, 30 Oct 2006 12:58:43 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:48859 "EHLO mx2.mail.elte.hu") by vger.kernel.org with ESMTP id S964855AbWJ3R6m (ORCPT ); Mon, 30 Oct 2006 12:58:42 -0500 Date: Mon, 30 Oct 2006 18:57:44 +0100 From: Ingo Molnar To: Arjan van de Ven Cc: Jens Axboe , Mark Lord , IDE/ATA development list , Linux Kernel Subject: Re: 2.6.19-rc3-git7: scsi_device_unbusy: inconsistent lock state Message-ID: <20061030175744.GA384@elte.hu> References: <45460D52.3000404@rtr.ca> <20061030144315.GG4563@kernel.dk> <1162220239.2948.27.camel@laptopd505.fenrus.org> <20061030154444.GH4563@kernel.dk> <1162225002.2948.45.camel@laptopd505.fenrus.org> <20061030162621.GK4563@kernel.dk> <1162225915.2948.49.camel@laptopd505.fenrus.org> <20061030175224.GB14055@kernel.dk> <1162230993.2948.60.camel@laptopd505.fenrus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1162230993.2948.60.camel@laptopd505.fenrus.org> User-Agent: Mutt/1.4.2.2i X-ELTE-SpamScore: -2.8 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.8 required=5.9 tests=ALL_TRUSTED,AWL,BAYES_50 autolearn=no SpamAssassin version=3.0.3 -3.3 ALL_TRUSTED Did not pass through any untrusted hosts 0.5 BAYES_50 BODY: Bayesian spam probability is 40 to 60% [score: 0.5000] -0.0 AWL AWL: From: address is in the auto white-list X-ELTE-VirusStatus: clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 998 Lines: 34 * Arjan van de Ven wrote: > > struct rb_node *parent; > > struct cfq_io_context *__cic; > > + unsigned long flags; > > void *k; > > > > cic->ioc = ioc; > > @@ -1384,9 +1385,9 @@ restart: > > rb_link_node(&cic->rb_node, parent, p); > > rb_insert_color(&cic->rb_node, &ioc->cic_root); > > > > - spin_lock_irq(cfqd->queue->queue_lock); > > + spin_lock_irqsave(cfqd->queue->queue_lock, flags); > > list_add(&cic->queue_list, &cfqd->cic_list); > > - spin_unlock_irq(cfqd->queue->queue_lock); > > + spin_unlock_irqrestore(cfqd->queue->queue_lock, flags); > > } > > this looks entirely reasonable and correct > > Acked-By: Arjan van de Ven yep. Acked-by: Ingo Molnar Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/