Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 20 May 2021 14:14:15 -0700
From:   Matthias Kaehlcke <mka@chromium.org>
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        Michal Simek <michal.simek@xilinx.com>,
        devicetree@vger.kernel.org,
        Douglas Anderson <dianders@chromium.org>,
        linux-usb@vger.kernel.org, Peter Chen <peter.chen@kernel.org>,
        linux-kernel@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
        Ravi Chandra Sadineni <ravisadineni@chromium.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Bastien Nocera <hadess@hadess.net>,
        Al Cooper <alcooperx@gmail.com>,
        "Alexander A. Klimov" <grandmaster@al2klimov.de>,
        Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [PATCH v10 2/5] USB: misc: Add onboard_usb_hub driver
Message-ID: <YKbRJylHrDiuSRGH@google.com>
References: <20210511225223.550762-1-mka@chromium.org>
 <20210511155152.v10.2.I7c9a1f1d6ced41dd8310e8a03da666a32364e790@changeid>
 <YKPz7a68duMyXU5x@google.com>
 <20210518194511.GA1137841@rowland.harvard.edu>
 <YKQ0XxhIWaN37HMr@google.com>
 <20210519144356.GB1165692@rowland.harvard.edu>
 <YKWaJdrpj1ixx9+v@google.com>
 <20210520020521.GB1186755@rowland.harvard.edu>
 <YKZnA2bifn346bPa@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YKZnA2bifn346bPa@google.com>
Precedence: bulk

On Thu, May 20, 2021 at 06:41:23AM -0700, Matthias Kaehlcke wrote:
> On Wed, May 19, 2021 at 10:05:21PM -0400, Alan Stern wrote:
> > On Wed, May 19, 2021 at 04:07:17PM -0700, Matthias Kaehlcke wrote:
> > > On Wed, May 19, 2021 at 10:43:56AM -0400, Alan Stern wrote:
> > > > On Tue, May 18, 2021 at 02:40:47PM -0700, Matthias Kaehlcke wrote:
> > > > > 
> > > > > Could you also have a look at "[4/5] usb: host: xhci-plat:
> > > > > Create platform device for onboard hubs in probe()"
> > > > > (https://lore.kernel.org/patchwork/patch/1425453/)? It's a
> > > > > relatively short patch that creates the platform device for
> > > > > the driver from xhci-plat as you suggested in the v4
> > > > > discussion.
> > > > 
> > > > I'm not the maintainer for xhci-related drivers.
> > > > 
> > > > However, there is at least one thing about this patch which looks 
> > > > suspicious: Adding the onboard_hub_dev pointer to struct usb_hcd instead 
> > > > of to struct xhci_plat_priv, where it would make a lot more sense.
> > > 
> > > I can move it to struct usb_hcd if that's preferred
> > 
> > Thinko: The patch already has it in struct usb_hcd.  I suggested moving 
> > it to struct xhci_plat_priv.
> 
> Ah, didn't actively recall to which struct I added it to, it has been a
> while since I wrote that patch ;-)

> Agreed that struct xhci_plat_priv is a better place.

Or not, xhci_plat_priv is optional, which doesn't make it a good candidate
for holding a field that could be used by any xHCI controller.

Should I move the field to struct xhci_hcd instead?