Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <832ccdcd6b199f45b64fc10a70b9b7962071badd.camel@suse.com>
Subject: Re: [PATCH] Move VMEnter and VMExit tracepoints closer to the
 actual event
From:   Dario Faggioli <dfaggioli@suse.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        Stefano De Venuto <stefano.devenuto99@gmail.com>,
        linux-kernel@vger.kernel.org
Cc:     pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com,
        wanpengli@tencent.com, jmattson@google.com, x86@kernel.org,
        hpa@zytor.com, kvm@vger.kernel.org, rostedt@goodmis.org,
        y.karadz@gmail.com
Date:   Fri, 21 May 2021 09:13:31 +0200
In-Reply-To: <875yzddg5n.ffs@nanos.tec.linutronix.de>
References: <20210519182303.2790-1-stefano.devenuto99@gmail.com>
         <875yzddg5n.ffs@nanos.tec.linutronix.de>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-Ps9gwJ7uHHce6z6Gcj4m"
User-Agent: Evolution 3.40.1 (by Flathub.org) 
MIME-Version: 1.0
Precedence: bulk


--=-Ps9gwJ7uHHce6z6Gcj4m
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Thomas,=20

And thanks a lot for the review!

On Thu, 2021-05-20 at 09:21 +0200, Thomas Gleixner wrote:
> On Wed, May 19 2021 at 20:23, Stefano De Venuto wrote:
> > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> > index 05eca131eaf2..c77d4866e239 100644
> > --- a/arch/x86/kvm/svm/svm.c
> > +++ b/arch/x86/kvm/svm/svm.c
> > @@ -3707,6 +3705,8 @@ static noinstr void
> > svm_vcpu_enter_exit(struct kvm_vcpu *vcpu)
> > =C2=A0
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0kvm_guest_enter_irqoff(=
);
> > =C2=A0
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0trace_kvm_entry(vcpu);
>=20
> No. This violates the noinstr rules and will make objtool complain on
> a
> full validation run.
>=20
Ok, I see, sorry for not noticing it.

Well, in this specific case --considering others' reviews-- it seems
that the tracepoints will be moved to somewhere else anyway, but we'll
make sure to run all the proper validation steps next time.

Thanks again and Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-Ps9gwJ7uHHce6z6Gcj4m
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmCnXZsACgkQFkJ4iaW4
c+69DA/+KRP2R8sKIOrew4DW30xOJLfRdrUsRiL6M4bQ/eUuw3ZGOgHADzN9GnhL
cIu8stZAKIxrSWcjpXrdELiIv/TFUJ1m5uH1Z7oi4ovku9E1AQDlV57iFCv61oTy
3use73BZyttv2pCSlUGjOz8bcmzxNkn5mBA3I69aMJQIygMcpEybwGG2Z+b5VzQW
cBI8a7YoE3dM7TN8lyluevg5Mry9DTRXKSb06dX/uGTX5vhwTHQEOJe2FCnqhyVG
GMTQjMOI9lIxrOdb68g4jAi+LeNTzVOimU7KSTDROLSkz2gLNST2/Jhc04rxmdbe
4IojvuzDDdgp9gWI+x3OOuRVSt/tlm7x80Mp/H2HalbeKh8VQLp9w+DUWO3/nbrt
8ASIC60HJSwFgBBz+g/0wypOpBOV2RH4AqdmuKyTWvSwJ8ifiezE6N0L6d4LmfWW
t4SInT+8BZU45D05xdkrv29hSIyjlCEL2W8naCO+vwVvTn/Pj5LjP9vOiklrSXEs
YclrK3y0Iu6fokYqWrkWCHXh/vLQLwvafk2lw5wXIKRhH0AVxm1PtbmW43gwpZru
iyabmiP2Oi3gVZsXA5wqWBR5guFGFSJT7cdzYn1Mh+0C5n+KJtqswhAo+r/wmgh9
8n8//T+zKdxj5tf8ZzkD2dPkqOvjyg4KvhdrVX43nS2n4a69qzc=
=PjA0
-----END PGP SIGNATURE-----

--=-Ps9gwJ7uHHce6z6Gcj4m--