Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1393759pxj; Fri, 21 May 2021 13:08:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4fOYjPtBhEo+UNbqQhATpxvdXgGLiUQ8xfYnO91jJGZIrUp/6u6DxPldxCGPh/KPNNyhW X-Received: by 2002:a05:6602:14c4:: with SMTP id b4mr577599iow.82.1621627738978; Fri, 21 May 2021 13:08:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621627738; cv=none; d=google.com; s=arc-20160816; b=ZlpeiGfdPqz50HhCd7i4WSIRCGUcOfBcVDjcpVUGETNrK2erKmeImCi3eC6Z8nD5+v N9b5YXEJUkQwOx6I4cRwSVL7PByStu90QU7M32jv6DMUQv5T6fVztjfMhT9GjXADha2u dDKf7Eyn9lkSv5xuvRp03MT04beZkEOoJkBy0EJEU8PWZQyQq9FZLH+bArJtz5eMBC7N BESGXpHLv+ZGEql2jeuV9pdd2No1CNWX0HmnSIJEnkNp9bAIbP4ctpktj/tE6qrvVXZ4 5TEer/cTZ6trJdhkljd6NfcOIYU1yHSoUg+gYLvWls1Yew2+xGpN5HAGSz+1KmEWm/sc W3Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=WAoGYY/IZ06EOl2sgqeBHp4au5PF0E3H2r0EKWA9o4I=; b=mPC7MR5JwJNRYt/RVoUS3zgTGJwqS+8GF+UHI5yW4Z+fUMuhhZHlrXBixYq597YOGw k7dDlmAKYmJ81xaKhFDkYAZLOpHZ5c+QAyZ41s1gyJh0o4+iXq8m5OHI7kUiqJoilmm2 kDh0nlhvdRH16jqjCg+//2YmhiqVf3AyqSmzrsEhzoBR407fUGYgJMXJcQFfTJzXpVAL 6uHkPxHcAfbkmNIqsEF55HBDLMQS0zOx8p+CCYUMDbtUV1wEhJjXfOc09aXMlaED5eJW Ng/Uk4LTzlWJpXiECDrYF+bls/RqyTa1ArMVu/A3Esc4suPbkx37eTdp/iaELx65xoSB KK+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=RSqrkjnp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b18si7132144ile.24.2021.05.21.13.08.46; Fri, 21 May 2021 13:08:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=RSqrkjnp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232935AbhEUIHs (ORCPT + 99 others); Fri, 21 May 2021 04:07:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232744AbhEUIHr (ORCPT ); Fri, 21 May 2021 04:07:47 -0400 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C6F9C0613CE for ; Fri, 21 May 2021 01:06:24 -0700 (PDT) Received: by mail-il1-x129.google.com with SMTP id e10so15882531ilu.11 for ; Fri, 21 May 2021 01:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WAoGYY/IZ06EOl2sgqeBHp4au5PF0E3H2r0EKWA9o4I=; b=RSqrkjnpNv3xOnHZ57xV85Uq945ViwHco45Lb/nK/s/aRNbcF9pCLsb4Y/mHIA3IYC Je32opFAc0+tjj+OFJinHjPHi+Z6Eveu98JACjdv/T0YIZTwGfNRfn7QoGIU6u0xBgi4 kZo5mUmgF8CHehv0XiTKyEvKYc3YNgsBDXDqbt+kjVgG15OM/j8KAkYcu+n2T5Os1kyD Agszq5EsRdHn8bEYnTwe5g9ZABpyl2rZxFP9/FXYrB10YlXSEICIC4Ov2ahNXLmk9rhP 4D6bQthjeF7dN4B8gfI0pGsqR0GP8sWzQM0lVItc/wBdFGwnlSuFFl5ZbnMiyviYnEL3 lwSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WAoGYY/IZ06EOl2sgqeBHp4au5PF0E3H2r0EKWA9o4I=; b=jEQM9uGAh434tp6NBfKuLKt3D7yiwEyC6n037CwRIKWpnW7rvfUMKTsB24pgCm9Ms2 eRS2FPfhns4mBPUwn8dI4SW8PP+cfx1lPlz88SEkm6KNHMLMW/bXN24o8A8wHRWnHFzo JdXxQjgm/JKB8iYZso++11N4820AUqSWCkOSUqC4nMHNAxKMuCct3laRSbIkk2JWNQ9b lOyAMdOg8VhLg9hgfpPYfh0VI1xRXdGLA61FPjHv3mnmZj0w0R5bC2QngN8MWCkJRgVa AsRFNTb2IvoT5T+2F7e06WRz/Te/AVYmznoCNh49u+rNOyTneX4mosKL8xlv+yzRqZYy +BiA== X-Gm-Message-State: AOAM531ufS32Goud87jGFOpaMNiwGYHclrFXjDwMc9RxUHVoDZwnjANz HColigYY+5eO72MpsfuPwebtsBlMmMBPTw0hxK0e2A== X-Received: by 2002:a92:520e:: with SMTP id g14mr10448898ilb.218.1621584383431; Fri, 21 May 2021 01:06:23 -0700 (PDT) MIME-Version: 1.0 References: <20210521070139.20644-1-irui.wang@mediatek.com> <20210521070139.20644-4-irui.wang@mediatek.com> In-Reply-To: <20210521070139.20644-4-irui.wang@mediatek.com> From: Tzung-Bi Shih Date: Fri, 21 May 2021 16:06:12 +0800 Message-ID: Subject: Re: [PATCH v4,3/6] media: mtk-vcodec: Support 4GB~8GB range iova space for venc To: Irui Wang Cc: Alexandre Courbot , Hans Verkuil , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Maoguang Meng , Longfei Wang , Yong Wu , Yunfei Dong , Fritz Koenig , Tzung-Bi Shih , linux-media@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , "moderated list:ARM/Mediatek SoC support" , srv_heupstream@mediatek.com, "moderated list:ARM/Mediatek SoC support" , Project_Global_Chrome_Upstream_Group@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 21, 2021 at 3:02 PM Irui Wang wrote: > + if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL)) > + dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34)); > + From your previous dt-bindings patch[1], it has 4 banks. > 0~4G; 4G~8G; 8G~12G; 12G~16G. But, the code treats it as a boolean. I.e. 0~4GB if non-existent; otherwise, 4GB~8GB. [1]: https://patchwork.linuxtv.org/project/linux-media/patch/20210521070139.20644-3-irui.wang@mediatek.com/