Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Guenter Roeck <linux@roeck-us.net>,
        Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Subject: RE: [PATCH v2 1/1] usb: typec: tcpm: Use LE to CPU conversion when
 accessing msg->header
Thread-Topic: [PATCH v2 1/1] usb: typec: tcpm: Use LE to CPU conversion when
 accessing msg->header
Thread-Index: AQHXTJZF+W3sWXeUpUmHF3giSUjCIKrtoXiQ
Date:   Fri, 21 May 2021 08:44:12 +0000
Message-ID: <PR3PR10MB4142574B559A4452C99FB85A80299@PR3PR10MB4142.EURPRD10.PROD.OUTLOOK.COM>
References: <20210519100358.64018-1-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20210519100358.64018-1-andriy.shevchenko@linux.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [147.161.166.124]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e9914d47-2fc5-4561-df7e-08d91c349bcc
x-ms-traffictypediagnostic: PAXPR10MB4750:
x-ms-exchange-sharedmailbox-routingagent-processed: True
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <PAXPR10MB475071D5A95CFA3FBB3B8A26A7299@PAXPR10MB4750.EURPRD10.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:4714;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: hQaDvFuMDeWaHbgBVI32fQvJFEEh85q9EjoYt1r3THW4lf1+Pbb12yiZZAlSrfEXVeHW3imOB/a9vo71HjENMc5gDfVJyrMU1M9tIVPrl3Jdqaf6I1HePNZp6zVTyb4QG13+QmGeh1VVd/rHZItGyK2jE6e7yC4vkyEKlJMmM/qe4WOXR2MTxs8UPtTe691lhuJ2xYxnZVSUdsoy6Z5mWAnDuQlcQjVpCFXwBhRYA5zWkWXcZBJ477jX4YGNjF+PTOtjLgoEI4RYsPPlwnqOOEz5RADIkd3j+BNoeiwo5bJDL5otHw+pBKQSGSN8D1vao6uXDRk2XtdG7d7uFwUb9tDTyrTLmZCNYW2gYZ3oKDGx8CVFB2KOv+l5tEzxYo3CLaqyiE24wKPa/Gmpk8UTLWjvdl+wH3TJN4kAX8QblvKGRdP8HWKklhrhxQYw1VAjw5fg1plXBWYB64SYs0vkI8+oGJ9+NwLyhDjQJJJMB+g2846bNK2P2+EX1L8JBTC+DiczRbcoJ3cMvvl6cVxMpdHrYF1N9NmVOjkoFrA4Fa28aswYrEZhRCLJVMuhyIRJ1mGDu2UjzvWYg+hZcwD6whFGykWYW+sRyRPXeuqeaXY=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PR3PR10MB4142.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(136003)(366004)(376002)(39860400002)(52536014)(316002)(33656002)(122000001)(66556008)(5660300002)(71200400001)(86362001)(107886003)(64756008)(66476007)(66946007)(66446008)(38100700002)(83380400001)(9686003)(76116006)(7696005)(26005)(55016002)(110136005)(8676002)(478600001)(186003)(4326008)(6506007)(54906003)(2906002)(8936002)(53546011);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata: =?us-ascii?Q?P2x4BgobSBn/Mew+MC2P/TwFTuVEbVvuRGL2PXPbRN+GPJugogamycvW297i?=
 =?us-ascii?Q?HKIT09skKeQsJSMwQ9yQP5F4SSl0JfdKvzLYITjpoSgSjOLTpISORROB5++C?=
 =?us-ascii?Q?pJ8JZUHniz4bIiSIvehuzyHK5cGf89fSWVlI7PkxYd2SFTAYYHZ1Gsv9OEzx?=
 =?us-ascii?Q?b6uGMmmAFDtKjd3rDAs6yzoRsSmI3vNmofk3NsbT1N/YyL36cXheGZsHLffT?=
 =?us-ascii?Q?FCnIbphXTDLZRNr6TgQ+4wAIgQPkLePd3kX7wOw1zUvNSU3rQFt5w3ro0U+5?=
 =?us-ascii?Q?OUP0SneVRRVxlLmsIt+y5DZQy71o+e0BVC0WbkpHMZWA+d4qT5+lx8NDHUyn?=
 =?us-ascii?Q?JUeSpAtGDeV/3wKzjDvq5/vSPSPW/gc69m52K4MVBbK5Br2dNOnXuKPBb7YX?=
 =?us-ascii?Q?KVqgXBextBdXoqBojkbQ6aZ02FEAGblXPykBb2KI8zowNxKYtwJUZZ1dKx7U?=
 =?us-ascii?Q?Pz6/dW26YHYamm9A4KpBAA5o7mLRT6DAtr2LIR3mHxFG/fkmMfwmp3oGGu7r?=
 =?us-ascii?Q?isVsjV5QgTTxipm7UgUDaADJxLrQSZ1ps4NHeEjxvYl0u1fGTbTb3HvK0WyP?=
 =?us-ascii?Q?hVKx+EdbOBBL+KYamurhjcVcwhWPhIed2BtGsYM+H6HRS5D4Ny8Z9BBjEzFU?=
 =?us-ascii?Q?ZPAgB6D1GE0nF1sxc4QV9ylMiR/t/iHaun3JBId+Kas8mpwB8FmSYgWL2+rZ?=
 =?us-ascii?Q?0PW8mRznm3ncH0qSYPs6wbDpgONgCI06snorNVP/maFGTj9Z0J7dBC5XdJsE?=
 =?us-ascii?Q?2qzTgQOSQSCrEHmVZiX2NgP/oY+3vsDFj7ALYvpKvcAcWhvA80JQ+5UYoshz?=
 =?us-ascii?Q?zsbxE3z6/PQBRAaZ0l96Ta4OzWViAw0Xs1HLCd3tLxTyoY7rCXF/ZIpaVFHe?=
 =?us-ascii?Q?cCLxXhAM2Zl457dBlPEQQDGonPsbwqWXybpi+kwxNx4ea04sPkunLD7Nc6n2?=
 =?us-ascii?Q?6OLf83gwWcrgXGi6H6oCoZqVKCScJgdL3U1POLjEUfYqSjYXESvw8dAiSb/c?=
 =?us-ascii?Q?fB9KIsMRXPS1KZ7OfSmlAjrGGeBrFveHOdEX7jjJonzjY1livaIKNPheDXt3?=
 =?us-ascii?Q?Azcteow7vFMR6+7OPL+rFFS3vChY5tGy9rXr9+syygBZt++Uhe/Z4ZukAv9q?=
 =?us-ascii?Q?bNrF/pkpdnvshyWIiZJ8ctq/XpvSt0s1IZZK1Zf2+j/n4ILbPPNSYPPC9qXh?=
 =?us-ascii?Q?oK6x2zvtA1lTel4KHlk57Y98yhFuptsTAHu0zYy6VVdIIFCFooag7Zbq7/Lu?=
 =?us-ascii?Q?zksjI+CEKdK7aJWZcpOrpNy10ja4pqnq1GtuMgRpgB5sLIndrUpmiPKzU47b?=
 =?us-ascii?Q?lEtsPirsJ39Zco3j11bDB5i3?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: diasemi.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PR3PR10MB4142.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: e9914d47-2fc5-4561-df7e-08d91c349bcc
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2021 08:44:12.6452
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 511e3c0e-ee96-486e-a2ec-e272ffa37b7c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Eum4G4n8FRs6QqzhxM6bNuLwzlCOxVenV80ig3QrgoZ9B8Zb8ftQrl6W3kysa8FcuVgDBbbS7So1t4Nvrg0q1WQiJtPjQYcsJECFpg/Iz1w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR10MB4750
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19 May 2021 11:04, Andy Shevchenko wrote:

> Sparse is not happy about strict type handling:
>   .../typec/tcpm/tcpm.c:2720:27: warning: restricted __le16 degrades to i=
nteger
>   .../typec/tcpm/tcpm.c:2814:32: warning: restricted __le16 degrades to i=
nteger
>=20
> Fix this by converting LE to CPU before use.
>=20
> Fixes: ae8a2ca8a221 ("usb: typec: Group all TCPCI/TCPM code together")
> Fixes: 64f7c494a3c0 ("typec: tcpm: Add support for sink PPS related messa=
ges")
> Cc: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

> ---
> v2: fixed subject prefix
>  drivers/usb/typec/tcpm/tcpm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.=
c
> index 64133e586c64..8fdfd7f65ad7 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -2717,7 +2717,7 @@ static void tcpm_pd_ext_msg_request(struct
> tcpm_port *port,
>  	enum pd_ext_msg_type type =3D pd_header_type_le(msg->header);
>  	unsigned int data_size =3D pd_ext_header_data_size_le(msg-
> >ext_msg.header);
>=20
> -	if (!(msg->ext_msg.header & PD_EXT_HDR_CHUNKED)) {
> +	if (!(le16_to_cpu(msg->ext_msg.header) & PD_EXT_HDR_CHUNKED)) {
>  		tcpm_pd_handle_msg(port, PD_MSG_CTRL_NOT_SUPP,
> NONE_AMS);
>  		tcpm_log(port, "Unchunked extended messages unsupported");
>  		return;
> @@ -2811,7 +2811,7 @@ static void tcpm_pd_rx_handler(struct kthread_work
> *work)
>  				 "Data role mismatch, initiating error recovery");
>  			tcpm_set_state(port, ERROR_RECOVERY, 0);
>  		} else {
> -			if (msg->header & PD_HEADER_EXT_HDR)
> +			if (le16_to_cpu(msg->header) & PD_HEADER_EXT_HDR)
>  				tcpm_pd_ext_msg_request(port, msg);
>  			else if (cnt)
>  				tcpm_pd_data_request(port, msg);
> --
> 2.30.2