Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?utf-8?Q?Aur=C3=A9lien?= Aptel <aaptel@suse.com>
To:     Hyunchul Lee <hyc.lee@gmail.com>, Steve French <sfrench@samba.org>,
        David Howells <dhowells@redhat.com>
Cc:     kernel-team@lge.com, Namjae Jeon <linkinjeon@kernel.org>,
        linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org,
        samba-technical@lists.samba.org, Hyunchul Lee <hyc.lee@gmail.com>
Subject: Re: [PATCH v2] cifs: decoding negTokenInit with generic ASN1 decoder
In-Reply-To: <20210521020051.196434-1-hyc.lee@gmail.com>
References: <20210521020051.196434-1-hyc.lee@gmail.com>
Date:   Fri, 21 May 2021 10:43:01 +0200
Message-ID: <87o8d4qxyi.fsf@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost (2003:fa:713:d396:524:65d3:25:9e8c) by ZR0P278CA0085.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23 via Frontend Transport; Fri, 21 May 2021 08:43:03 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 317da4f8-39f9-4985-6087-08d91c3472dc
X-MS-TrafficTypeDiagnostic: VI1PR04MB5392:
X-Microsoft-Antispam-PRVS: <VI1PR04MB5392CADBD4E8853E908EF0B1A8299@VI1PR04MB5392.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 44MnZZ9YTXBMtBqM3WE/Rq4bU8tE5neUKyDgUi41DPLm6rZDOYzW+q5w1cTQAp2LzL0U8uH5zWGnnfldHiItf3M/Ta0QGRnAL6e2UcE1TwyMEqBXO3JD6kQmLsqhc3Zw/F/eQN0E9VNRR+2s+pegALfcriYlCIt0wBIBhe3Yo3cz/8KM4XHJxMo8IgjXAfk0p8cDmshG0oumsOfLm4rqn8W50NQKdGIZcELOvzXXgWAXsn6wa7HDJOkBfDSeD3L6U77Ok6ctDH3zH4OFZrO9DABnB37tIStg4zl2u2mhHH20HHhJq775Ny3XKUwug6IE5QH/4pj2HZVQIhoTXdtdF58KpLTEd3uKf3fWTB4lepUS041mKHHInuKQ+dyuXKuyQ/e0zO3lixwD/yCDBKziilif5/DjpDXA9vcfxGnDQ1gK7zWR7AZhAczUlmPXVUrqnKwzu5zvs2D/iU1bykKcq3YbkJ7w6fp0nUajuOr6Z1NpBc7V4hZ/aQZUV4EVaRgSPST1F+iVeHhQX7VFw2Ga4OD2xijjZXsVgg3Is2ShELv7m6AaAURjcENwVWVhZ+2tuViV79kAPEZsNfFPfk47PCJsALP2xu5HWYT503ajwZOQKeCrniZyXMzwHLqhvyI8u5ybens3N1x2WP1GFr3zAQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0402MB3359.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(39860400002)(376002)(396003)(366004)(346002)(36756003)(52116002)(6496006)(2616005)(2906002)(6486002)(83380400001)(86362001)(66476007)(66946007)(66556008)(54906003)(38100700002)(316002)(4326008)(110136005)(478600001)(16526019)(4744005)(186003)(66574015)(8676002)(5660300002)(8936002)(41533002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?V0M0c1RUWldha0U0cWNMdUdZZU5Ba1ZzQmxLVk1hRDVBNkxURENQakl3YWVM?=
 =?utf-8?B?c2F3ZHRBRlBJSlpMbDFBUng1Vll5NFhpanZGMHlyWnB6RXlheEJoLzEvRGtE?=
 =?utf-8?B?MW13U1c0cHdIamRkZUY1ZWZ3MVJFTCtsUFBXbzIwMjBoNTEzUVFhTjJjREFM?=
 =?utf-8?B?UVkvUjlDbkRsL3lMRWprU2NnU200RzVZQ25RaVZkTGxGTVMzZGRrWGlGcDRI?=
 =?utf-8?B?ME9aWEk1TnhtdUN2N2JCajZCZjJFOWQ4UnlYZlJzaGxnMXhyUmF1L1NsZ2Q1?=
 =?utf-8?B?ZW1vMnVSS3JLcTJqenhOc1dNV2tLTmFpRmkrYXBUM0Fyc3NxQ1VuMnFsellX?=
 =?utf-8?B?YytFYXpSekdZMGNBZU4vZk1qMW54dC9mbU9LK2VnSzZaOU5UbndHbkZnVXk0?=
 =?utf-8?B?Y3dXK2VQUk0vS29hb3JQdnVVaUF4VjZUbFJKWHk4K3pVWDRWbU55bVhHM1J0?=
 =?utf-8?B?MUJhWEp1RGxpT2RyeU95b2RCeVhYc2x3VytiUjdIb2ZmOXpvWEk4ckdxSU5M?=
 =?utf-8?B?Nzc0bWFEUWhvQWtydDg3d2JKOGpSOGc2Rk84NVl6ZUVOdDJGYmFBaG9UTWV3?=
 =?utf-8?B?K2F6SjdFb0lvT3hUYXI5eVdiRnJUMGwrUzJMaEMxRVRINk1OdGtDNmhhUEVx?=
 =?utf-8?B?T3F0ZnhGSkQwZFpYSkQ4MGtpelBwZDJGS2xEN3JwV2k2MVh4M3R3WlJ1TUhX?=
 =?utf-8?B?Vk45Tis0ZVh1RDg5akVETzU1R2pOSjV2bFlKYUV5Z1pQWEtQeE5tenkwaVVQ?=
 =?utf-8?B?VWtiYlNQWDZzZXhTc0ZtUERzRjA4blJST2pPN1RKdjJYSjlVZWo3c0hzMUNh?=
 =?utf-8?B?VlZseHJYb3FZTXA5cU42RXRiZXRsVXY1R0wyaVhVR0dLaW9SbUZ4c0g2R1hV?=
 =?utf-8?B?VHJ4UlFpK2ZGUFZJNEEwcGZ2SUFmZ3FTOGNaQzVKczNXWUhyZzNSWlNrV2F1?=
 =?utf-8?B?YkxyMFdLMmlIaGdXU2tEZ01OY3Z1QThCd2tzeW0xZm1pbW1jL0JST1pmbHE4?=
 =?utf-8?B?bGhEVHE2SktZaExmTW1IVXdkdFc5S0FvbVEzcFdaekZlSU1raTNPU3Z6YjRN?=
 =?utf-8?B?N0FxaWRKbTBGTGVaNDNxUXVMMkYvamwrNXFxeGRRbjdUNHh2QXpya1ZJSzFm?=
 =?utf-8?B?YXlSR3hOTXNvWlVSTWFvM2FoT0xGQUJ5Uk56OWoydS9tUDBtdzJGR3lTc2dU?=
 =?utf-8?B?cWlhWVpGLzNXVzV2ajNlY05RbjB3QjJ1MHF6dEczUDNwczAzd1FDOGpZNEVZ?=
 =?utf-8?B?Rmx5M1ZtZ1F5NiswanV2NThIdzNLSFp2a1VxUVZYa0h1ZXhVaHU5UFUwYXd2?=
 =?utf-8?B?YUVHWitJdlVQTHNROEUxZWJESkhaQ0NzMzRCZisxRWFBaExYa0JWQjhwNHlm?=
 =?utf-8?B?VXZMS3ppRUJCK29pMVBEZ1ptNVM1dStPazJQUU1keW13eXowKzR6N0oyWVhi?=
 =?utf-8?B?U29jTWREZDZGRXE4WGsxQ3pHSVg3MnAxeWs2d1F3M2ZFMnlLb3J5QjhDNkRL?=
 =?utf-8?B?ZjN2d1UzeUNlbE1jUWRkdG0wNjFZWHJQNUNHcytGanh0bnhybUM4UUNBUGd0?=
 =?utf-8?B?U25LRlJ3bjhzTXBsK1AzYTdCcEF2V2UzZytQa2NQRy9OcDVaOTNWWnBNQ3FW?=
 =?utf-8?B?eEY0NFpISUNxWnNJOEdQL0hVQy9EdCtHTEY5MDV0bjdWU0EzNmFjWHVMNXN4?=
 =?utf-8?B?dWVVMUVMaHluRUVRcTFxSitKbUZVWXVQM0lBVlB3Q1BjMDJnSUp1T0RZcUJW?=
 =?utf-8?B?NlM4Vm9uT3VrNjNXSUtqMnpsaHZsNFJ4SWR1N01jSi9JUnByTlgxOURZQ00x?=
 =?utf-8?Q?r1po3rdRhz4vvcOULEzH82pwbp4c06DuaQeyY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 317da4f8-39f9-4985-6087-08d91c3472dc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3359.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2021 08:43:04.1957
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: apVMKv+fPgp77BDTJU5UojP9yYXHRCjdk+EC/mMnCjkBsrk4qF87bZw2GxIvOEuQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5392
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Hyunchul,

The existence of multiple ASN1 decoder has been a regular complaint,
this looks nice. Have you tested it against any servers?

I think we need to make sure it works with Windows Server (including
increased ones with the increased security flag, Steve do you remember
the name of that flag?) and Samba at least.

There is the SDC EMEA plugfest coming up, might be a good time to try it
out against other vendors as well.

Cheers,
--=20
Aur=C3=A9lien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, D=
E
GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 247165 (AG M=C3=BC=
nchen)