Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 21 May 2021 16:17:57 +0200
From:   Alain Volmat <alain.volmat@foss.st.com>
To:     Lee Jones <lee.jones@linaro.org>
CC:     <linux-kernel@vger.kernel.org>,
        Patrice Chotard <patrice.chotard@foss.st.com>,
        Maxime Coquelin <maxime.coquelin@st.com>,
        <linux-arm-kernel@lists.infradead.org>, <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH 13/16] i2c: busses: i2c-st: Fix copy/paste function
 misnaming issues
Message-ID: <20210521141757.GA17641@gnbcxd0016.gnb.st.com>
Mail-Followup-To: Lee Jones <lee.jones@linaro.org>,
        linux-kernel@vger.kernel.org,
        Patrice Chotard <patrice.chotard@foss.st.com>,
        Maxime Coquelin <maxime.coquelin@st.com>,
        linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
References: <20210520190105.3772683-1-lee.jones@linaro.org>
 <20210520190105.3772683-14-lee.jones@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20210520190105.3772683-14-lee.jones@linaro.org>
Precedence: bulk

Thanks for the fix. I was about to propose it ;)

On Thu, May 20, 2021 at 08:01:02PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/i2c/busses/i2c-st.c:531: warning: expecting prototype for st_i2c_handle_write(). Prototype was for st_i2c_handle_read() instead
>  drivers/i2c/busses/i2c-st.c:566: warning: expecting prototype for st_i2c_isr(). Prototype was for st_i2c_isr_thread() instead
> 
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Maxime Coquelin <maxime.coquelin@st.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-i2c@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/i2c/busses/i2c-st.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c
> index faa81a95551fe..30089b38044b5 100644
> --- a/drivers/i2c/busses/i2c-st.c
> +++ b/drivers/i2c/busses/i2c-st.c
> @@ -524,7 +524,7 @@ static void st_i2c_handle_write(struct st_i2c_dev *i2c_dev)
>  }
>  
>  /**
> - * st_i2c_handle_write() - Handle FIFO enmpty interrupt in case of read
> + * st_i2c_handle_read() - Handle FIFO enmpty interrupt in case of read

Could you also fix the typo enmpty -> empty at the same time ?

>   * @i2c_dev: Controller's private data
>   */
>  static void st_i2c_handle_read(struct st_i2c_dev *i2c_dev)
> @@ -558,7 +558,7 @@ static void st_i2c_handle_read(struct st_i2c_dev *i2c_dev)
>  }
>  
>  /**
> - * st_i2c_isr() - Interrupt routine
> + * st_i2c_isr_thread() - Interrupt routine
>   * @irq: interrupt number
>   * @data: Controller's private data
>   */
> -- 
> 2.31.1
> 

Regards,
Alain