Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 21 May 2021 16:19:59 +0200
Message-ID: <s5hv97cf9tc.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Johan Hovold <johan@kernel.org>
Cc:     Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
        "Geoffrey D. Bennett" <g@b4.vu>, alsa-devel@alsa-project.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: fix control-request direction
In-Reply-To: <20210521133742.18098-1-johan@kernel.org>
References: <20210521133742.18098-1-johan@kernel.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 21 May 2021 15:37:42 +0200,
Johan Hovold wrote:
> 
> The direction of the pipe argument must match the request-type direction
> bit or control requests may fail depending on the host-controller-driver
> implementation.
> 
> Fix the UAC2_CS_CUR request which erroneously used usb_sndctrlpipe().
> 
> Fixes: 93db51d06b32 ("ALSA: usb-audio: Check valid altsetting at parsing rates for UAC2/3")
> Cc: stable@vger.kernel.org      # 5.10
> Signed-off-by: Johan Hovold <johan@kernel.org>

Thanks, applied now.

> ---
> 
> There's a related bug in sound/usb/mixer_scarlett_gen2.c, which
> Geoffrey reported and said he was preparing a patch for here:
> 
> 	https://lore.kernel.org/r/20210520180819.GA95348@m.b4.vu

Yes, I'm going to apply them now, too.


Takashi