Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1400874pxj; Fri, 21 May 2021 13:20:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwd03SMG2wGgCkye8R3F4q6RuY2WpfaGd69e9J3LMa0Awqjl08YUfTCFASt44PcDyQ1PQr/ X-Received: by 2002:a5e:c744:: with SMTP id g4mr683766iop.26.1621628426838; Fri, 21 May 2021 13:20:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621628426; cv=none; d=google.com; s=arc-20160816; b=pMsdfqHdAp4gVdspY+9lhvJsiTWVcZgUZazGTN5Y30ParlYoH1kaGYwIJ6I3B/0haF B5DlayXmN5Cx+FrWrRDkC3OCwmBuQrZ5TA7/7KsDsYuG8ecAhC5HyzLwQBZSVpyEI+6w CnEtCDwv+9vls/SUOocJMHsNmGRPXy4qxH+1SmBH7D0kj4Sto5QdEt/LhBYCz38McZuh 9I1nDGkcCRoOAAPP/wX/fdTvWaT4efskv6S3HStHOdz7JFmWvwuNYiLet6DJYkn5WEqJ WxJgXA2jAKsackWyvFsm8076AfTBBoVY+joIQtddMa5Peo4oZe5ynm6uJe5sITg29ar0 Qe0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=sJeDUI0J+oq0D7dh3wrfUI0y+Q+Lg8JbwyOwoEBBows=; b=Dsmr3S4H9z/wO+xfMvM6xELtXkUfXndHOlYzJsoWzfZQFrJ30qIoEj1bRqlJy2nu+z eMrh7Wadlyec/zNHu9dCYes0u3eaoSf+JlqvxLlTITj4zhto2zBHeKMesQxqqYjj37OO I9URXRYXvQproN/kn1TwkW9h4ob4IPRRVR4W7ksKsItyHHzJnQWhYzJ//PMoa/lmifLs 1E/zkWqDF+JNrJC3yIN0XInYfn2h0UH7KfVDYCbLzgbGNz8O57HMdENg4osSbDYHJ7rA oBezMqL94L4sQFaW5TyyxiPCEDrL4kM9L1d93UFPWR3TU8eex+O8SqTgBOLVJhc1ldmp uoPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d1si7608308ilg.93.2021.05.21.13.20.14; Fri, 21 May 2021 13:20:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237140AbhEUOxx (ORCPT + 99 others); Fri, 21 May 2021 10:53:53 -0400 Received: from mga05.intel.com ([192.55.52.43]:21068 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232057AbhEUOxw (ORCPT ); Fri, 21 May 2021 10:53:52 -0400 IronPort-SDR: FOXPFyPNAjcE2CXF9SL27yKug9UBnajkIzwziwBxa5rX8J58Gd2VU4cSkEyhn6IAlgZxzjWOz7 1bFz2KBTKhxw== X-IronPort-AV: E=McAfee;i="6200,9189,9990"; a="287040184" X-IronPort-AV: E=Sophos;i="5.82,319,1613462400"; d="scan'208";a="287040184" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2021 07:52:29 -0700 IronPort-SDR: ZefJEzXEiUWQHBcRR4lw36LzYwpJ7zEPfbnpxytcSmXb8mmM7rR7WzKi2uxoFfyjrWoZzT1S/S H00O/akNSkAA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,319,1613462400"; d="scan'208";a="440957277" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga008.jf.intel.com with ESMTP; 21 May 2021 07:52:25 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 20DD023A; Fri, 21 May 2021 17:52:47 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Felipe Balbi , Greg Kroah-Hartman Subject: [PATCH v1 1/1] usb: phy: isp1301: Deduplicate of_find_i2c_device_by_node() Date: Fri, 21 May 2021 17:52:43 +0300 Message-Id: <20210521145243.87911-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver is using open-coded variant of of_find_i2c_device_by_node(). Replace it by the actual call to the above mentioned API. Signed-off-by: Andy Shevchenko --- drivers/usb/phy/phy-isp1301.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/usb/phy/phy-isp1301.c b/drivers/usb/phy/phy-isp1301.c index 6cf6fbd39237..ad3d57f1c273 100644 --- a/drivers/usb/phy/phy-isp1301.c +++ b/drivers/usb/phy/phy-isp1301.c @@ -142,24 +142,17 @@ static struct i2c_driver isp1301_driver = { module_i2c_driver(isp1301_driver); -static int match(struct device *dev, const void *data) -{ - const struct device_node *node = (const struct device_node *)data; - return (dev->of_node == node) && - (dev->driver == &isp1301_driver.driver); -} - struct i2c_client *isp1301_get_client(struct device_node *node) { - if (node) { /* reference of ISP1301 I2C node via DT */ - struct device *dev = bus_find_device(&i2c_bus_type, NULL, - node, match); - if (!dev) - return NULL; - return to_i2c_client(dev); - } else { /* non-DT: only one ISP1301 chip supported */ - return isp1301_i2c_client; - } + struct i2c_client *client; + + /* reference of ISP1301 I2C node via DT */ + client = of_find_i2c_device_by_node(node); + if (client) + return client; + + /* non-DT: only one ISP1301 chip supported */ + return isp1301_i2c_client; } EXPORT_SYMBOL_GPL(isp1301_get_client); -- 2.30.2