Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1402108pxj; Fri, 21 May 2021 13:22:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+7uhXhN9s9hrYLHkdG69l/TACIZbxOria/MOOTaRLSVdMV7usO+IIYGAk1DGkDFKyPAWk X-Received: by 2002:a17:906:3c1a:: with SMTP id h26mr11861466ejg.22.1621628552023; Fri, 21 May 2021 13:22:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621628552; cv=none; d=google.com; s=arc-20160816; b=aVOOKVzPaEzwFoDr4GcONSNR2hSSfXgmuGPfj7D+RMuoVbVsUc6ulK6oSDHQIFE3kA /gtRrz6RuwR9HE9AY+vPpuHb1S1Mu1+PAjLI2PnoCF0lHvrCfEa9AWbBtEs2nfUe7Sa9 9TIgOP443cIpybDWd7GqmNvtGXPEVJu6xGA173/dgNH68Y2cjK0dT7cSghEqhIuUM4yN ZrtblYyyBRk+3sAgJNLInqtxWW66JKscELLhWOx2KL0qoGQwn0bkKP4TvzJiEq2qZTHD Nc9WuNJo8GFyuvA15DAJFWFY6CZEAbTUPt+1U6GAKBKuyLnTS6LBSM51G1Exo+woH932 A90g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=vb3caAt/tKr79nkmDUGEd2unVM3Vh/hFlp4bXuoFTXo=; b=f0txVPoLtSDyJgVwyin8l/XgbB8CKCPQoWsKTpyTpFTrNiOmRqHvQW044EMfqqnm9K abaDYO4tENDF/OO94vSdT3xC4sQJnQfqF4SvawKo319TWGXEh9dVN92JGdEFRnmcyDvH gmH+Man7qi23MhLuU8Z8bqmbEhnkODzNcBpTEHZpkdzDTxDHqfTYqjNNiUSaL6c2/bvZ mZQm4++KU666OejH5wZzSSvaSbYaplAnYnFc8H8Va2kh9XoeV75f5BC9/P2fW0v9htf6 8kPWXfnmphGsk80thZAJX3gI4gMw5KIouaqnv1ssX9FeOZ0roj0+ZeVfuelsaLLure/l ayog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=NACigRTX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f11si6419297eje.327.2021.05.21.13.22.08; Fri, 21 May 2021 13:22:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=NACigRTX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237318AbhEUPLN (ORCPT + 99 others); Fri, 21 May 2021 11:11:13 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:38778 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230420AbhEUPLM (ORCPT ); Fri, 21 May 2021 11:11:12 -0400 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14LF6weW004704; Fri, 21 May 2021 10:09:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=vb3caAt/tKr79nkmDUGEd2unVM3Vh/hFlp4bXuoFTXo=; b=NACigRTXcoFNMy5gvvel/FK2kHfv2VsCyXohh12TaHxXFtC8z2LLCL4IwIEmlG5dLykv +NrwgP6QjmAtPPDlW5is0TIrdj6DcJjZ5eqYxeYiqvaWqYW5x2MFAP466dF71j7T84zC UEUonuQdEDxOJGqqCEyxiKzcy+l3eXA36JOYk+zcv761HYam2sfvmixbkYVu0/W3WS5D ippFR0SZItfCITc5GeRuSgkKOWI4wKiZQ7J8Bzde0wmykumx7rC9XqdP8IBOS1wjG0lp lrZaL03Fsw/srHyMGBcLm3mybiMO+fIAdexA5w2c4Ruy1/gTwVMtuTq7STWAy6JoKBYG BA== Received: from ediex02.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 38p6errkag-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 21 May 2021 10:09:37 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 21 May 2021 16:09:35 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2242.4 via Frontend Transport; Fri, 21 May 2021 16:09:35 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 9A1BB11D6; Fri, 21 May 2021 15:09:35 +0000 (UTC) Date: Fri, 21 May 2021 15:09:35 +0000 From: Charles Keepax To: Hans de Goede CC: Lee Jones , Liam Girdwood , Mark Brown , , , Subject: Re: [PATCH] mfd: arizona: Allow building arizona MFD-core as module Message-ID: <20210521150935.GL64205@ediswmail.ad.cirrus.com> References: <20210521135023.192688-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210521135023.192688-1-hdegoede@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: _ZjdkWqRT1n5vZnloVNu9f9e3IUvFRPt X-Proofpoint-ORIG-GUID: _ZjdkWqRT1n5vZnloVNu9f9e3IUvFRPt X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 priorityscore=1501 spamscore=0 mlxscore=0 phishscore=0 mlxlogscore=874 clxscore=1015 bulkscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105210083 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 21, 2021 at 03:50:23PM +0200, Hans de Goede wrote: > There is no reason why the arizona core,irq and codec model specific > regmap bits cannot be build as a module. All they do is export symbols > which are used by the arizona-spi/i2c and arizona-codec modules, which > themselves can be built as module. > > Change the Kconfig and Makefile arizona bits so that the arizona MFD-core > can be built as a module. > > This is especially useful on x86 platforms with a WM5102 codec, this > allows the arizona MFD driver necessary for the WM5102 codec to be > enabled in generic distro-kernels without growing the base kernel-image > size. > > Note this also adds an explicit "depends on MFD_ARIZONA" to all the > arizona codec Kconfig options. The codec drivers use functions from mfd > arizona-core. These new depends are necessary to disallow the codec > drivers being builtin when the arizona-core is build as a module, > otherwise we end up with missing symbol errors when building vmlinuz. > > Signed-off-by: Hans de Goede > --- Acked-by: Charles Keepax Thanks, Charles