Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Kees Cook <keescook@chromium.org>
To:     Marco Elver <elver@google.com>
Cc:     Kees Cook <keescook@chromium.org>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        linux-kernel@vger.kernel.org, ojeda@kernel.org,
        akpm@linux-foundation.org, joe@perches.com, johan@kernel.org,
        masahiroy@kernel.org, Nathan Chancellor <nathan@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, samitolvanen@google.com
Subject: Re: [PATCH] init: verify that function is initcall_t at compile-time
Date:   Fri, 21 May 2021 10:59:51 -0700
Message-Id: <162161998941.2029023.3745497110832316703.b4-ty@chromium.org>
In-Reply-To: <20210521072610.2880286-1-elver@google.com>
References: <20210521072610.2880286-1-elver@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 21 May 2021 09:26:10 +0200, Marco Elver wrote:
> In the spirit of making it hard to misuse an interface, add a
> compile-time assertion in the CONFIG_HAVE_ARCH_PREL32_RELOCATIONS case
> to verify the initcall function matches initcall_t, because the inline
> asm bypasses any type-checking the compiler would otherwise do. This
> will help developers catch incorrect API use in all configurations.
> 
> A recent example of this is:
> https://lkml.kernel.org/r/20210514140015.2944744-1-arnd@kernel.org

Since this touches on CFI, I've taken this patch.

Applied to for-next/clang/features, thanks!

[1/1] init: verify that function is initcall_t at compile-time
      https://git.kernel.org/kees/c/72a12a91a634

-- 
Kees Cook