Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1404918pxj; Fri, 21 May 2021 13:27:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXMkv6StVSc7KpMNom9AI/emvGjqpho0CmevTpIyuDFrlZrdhLFPdtM378UY9wVbm+3eMI X-Received: by 2002:a92:340a:: with SMTP id b10mr636045ila.301.1621628827883; Fri, 21 May 2021 13:27:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621628827; cv=none; d=google.com; s=arc-20160816; b=LCZinQWxyKaSyalujHmp+hlPVeHGpTyJ5hj2Mrxnhm0qSKv7d93P7U6gMjfzN7XYFS MgYxhMe3YQrIUzawJdvd7jQL5UTY6Tgh0VayDoioNSlWOF+thnrIWKAVjYnNkgbcV+en F4ZT4coxi1dXjnfHEe+gmTRBiBFLOdjD5ihvofxkrzCe5scNX/X+WfSxYvNfUapadNZO MIOMDY1/FqQDmomFgE+GXctjOz+tqp/6PII/9lrOYeCJwZ6EXEGGNuglmJX/HHQHox/d R6k101jhZFG6Su9DJ6XkGW+TtBbk5KzqC7EPlIvgF4p3AES6IomC3Favmmt/J0beCBGG ppsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xkROTNt6AI31m2jdBOyiECteV9VsPpyw0WnUQpk+Wzc=; b=jwJtepEp+elWvxW4HDs2qnJ3tUtXB9lcn0la3+ctXOQkzuznP7TMSPRIZwkesuCJK0 8XmoB9DTOMLgDh7bs9xwD3ojCZDsvmERRq1VKyzvDrf1mut7SlJ95Z1W4dQfDpRZgDTr Rg3Yed3UPW01LZf/CvO7zpeGW6Ydobkyl/agC+ldnFqFJ9hQTa/l+GMr2aJ9+ZpsqX/u C9sO8vr9dkJVhR/HAdXmRE16xvujsVRIR1kKlvZ7bJbmADSB7d1aj7IROwsR04zD0zHe PeDiXlLsBTNU2UqlwHGMwHhcgoDZCNuOZj5sRJHjUx1+m3F5rYXLfVXY38CofI4ry28R /k+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=VaADoicO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g8si6734383ilq.40.2021.05.21.13.26.55; Fri, 21 May 2021 13:27:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=VaADoicO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234065AbhEUSmM (ORCPT + 99 others); Fri, 21 May 2021 14:42:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbhEUSmL (ORCPT ); Fri, 21 May 2021 14:42:11 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85FE1C061574; Fri, 21 May 2021 11:40:48 -0700 (PDT) Received: from zn.tnic (p200300ec2f0ea400fbcd5718c7a034c2.dip0.t-ipconnect.de [IPv6:2003:ec:2f0e:a400:fbcd:5718:c7a0:34c2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id AFE9D1EC06F6; Fri, 21 May 2021 20:40:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1621622445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=xkROTNt6AI31m2jdBOyiECteV9VsPpyw0WnUQpk+Wzc=; b=VaADoicO3S+yFEcIUtcM3sOjNaJE0WZ+C0kd7zHM3NhGF6PJSn5GjYz2Si/yXNYyn+xuPE Yjpcj0qOk95X1N65SeP8DvLIA2jvzUiMMIOlr4cobPuJN3EvD0c0YoQVE4zqjWaqGVRoXK yz9AePJ4Z/wC7pgXgLxPK4UBY8FQDeE= Date: Fri, 21 May 2021 20:40:39 +0200 From: Borislav Petkov To: "Yu, Yu-cheng" Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang Subject: Re: [PATCH v26 24/30] x86/cet/shstk: Introduce shadow stack token setup/verify routines Message-ID: References: <20210427204315.24153-1-yu-cheng.yu@intel.com> <20210427204315.24153-25-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 21, 2021 at 09:17:24AM -0700, Yu, Yu-cheng wrote: > If !IS_ALIGNED(ssp, 4), then certainly !IS_ALIGNED(ssp, 8). ... but the reverse is true: when it is aligned by 8, it is already aligned by 4. Whoops, that's tricky. Pls put a comment over it so that we don't forget. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette